From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pavan Deolasee <pavan.deolasee@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Failure in commit_ts tap tests
Date: Tue, 24 Jan 2017 05:06:34 -0500
Message-ID: <e6084b89-07a7-7e57-51ee-d7b8fc9ec864@2ndQuadrant.com> (raw)
In-Reply-To: <160290f8-ae98-b122-0b48-44805495f172@2ndQuadrant.com>
References: <CABOikdPhsHM+pX8skoEY1_T0OtKdO1udzUj4VCjU5VEt+bj4eA@mail.gmail.com>
<19348.1484936537@sss.pgh.pa.us>
<24cf2b76-9b9f-bba9-7e8b-89b9d0ba2471@2ndQuadrant.com>
<17741.1485180194@sss.pgh.pa.us>
<644bd551-33c0-13bf-ba04-415a39367d6a@2ndQuadrant.com>
<21624.1485181348@sss.pgh.pa.us>
<160290f8-ae98-b122-0b48-44805495f172@2ndQuadrant.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 01/24/2017 03:18 AM, Andrew Dunstan wrote:
>
> On 01/23/2017 09:22 AM, Tom Lane wrote:
>> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>>> On 01/23/2017 09:03 AM, Tom Lane wrote:
>>>> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>>>>> On 01/20/2017 01:22 PM, Tom Lane wrote:
>>>>>> It looks like at least part of the answer is that the buildfarm isn't
>>>>>> running this test. AFAICS, it runs "make installcheck" not
>>>>>> "make check" in src/test/modules.
>>> OK, so should we just change "make installcheck" to "make check"?
>> I'm in favor (just for src/test/modules, to be clear).
>>
>>
>
>
> Yes. There will be some consequent buildfarm code cleanup, but this will
> test shortly on crake.
>
Well, that crashed. The DDL deparse comment test should not assume that
contrib_regression exists. Possibly it should create it if it doesn't
exist. The buildfarm mostly runs with USE_DB_MODULE=1 so we don't
constantly overwrite the same db.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andrew.dunstan@2ndquadrant.com, tgl@sss.pgh.pa.us, pavan.deolasee@gmail.com
Subject: Re: Failure in commit_ts tap tests
In-Reply-To: <e6084b89-07a7-7e57-51ee-d7b8fc9ec864@2ndQuadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox