From: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
To: pgsql-hackers@postgresql.org
Subject: Missing comment for create_modifytable_path
Date: Thu, 15 Jun 2017 17:40:37 +0900
Message-ID: <e87c4a6d-23d7-5e7c-e8db-44ed418eb5d1@lab.ntt.co.jp> (raw)
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
While working on adding support for tuple routing for foreign
partitions, I noticed that in create_modifytable_path, we forgot to add
a comment on its new argument 'partitioned_rels'. Attached a patch for
including that in the comments for that function.
Best regards,
Etsuro Fujita
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackersAttachments:create_modifytable_path-comment.patch (text/plain, 818B) downloaddiff --git a/src/backend/optimizer/util/pathnode.c b/src/backend/optimizer/util/pathnode.cindex ec4a093..46bc1df 100644--- a/src/backend/optimizer/util/pathnode.c+++ b/src/backend/optimizer/util/pathnode.c@@ -3159,6 +3159,8 @@ create_lockrows_path(PlannerInfo *root, RelOptInfo *rel,
* 'operation' is the operation type
* 'canSetTag' is true if we set the command tag/es_processed
* 'nominalRelation' is the parent RT index for use of EXPLAIN
+ * 'partitioned_rels' is an integer list of RT indexes of non-leaf tables in+ * the partition tree if UPDATE/DELETE to a partitioned table, else NIL
* 'resultRelations' is an integer list of actual RT indexes of target rel(s)
* 'subpaths' is a list of Path(s) producing source data (one per rel)
* 'subroots' is a list of PlannerInfo structs (one per rel)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: fujita.etsuro@lab.ntt.co.jp
Subject: Re: Missing comment for create_modifytable_path
In-Reply-To: <e87c4a6d-23d7-5e7c-e8db-44ed418eb5d1@lab.ntt.co.jp>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox