From: Alexander Lakhin <exclusion@gmail.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Fix typos and inconsistencies for v16
Date: Fri, 21 Apr 2023 12:00:00 +0300
Message-ID: <e8c38840-596a-83d6-bd8d-cebc51111572@gmail.com> (raw)
In-Reply-To: <CAApHDvqUdoxzLaVU16Ktx83qiroYrmxNTpwvd5GAcLH+ZH51Pg@mail.gmail.com>
References: <d5f68d19-c0fc-91a9-118d-7c6a5a3f5fad@gmail.com>
<ZD3D1QxoccnN8A1V@telsasoft.com>
<699beab4-a6ca-92c9-f152-f559caf6dc25@gmail.com>
<CAApHDvqUdoxzLaVU16Ktx83qiroYrmxNTpwvd5GAcLH+ZH51Pg@mail.gmail.com>
Hi David,
21.04.2023 01:49, David Rowley wrote:
> On Wed, 19 Apr 2023 at 07:00, Alexander Lakhin <exclusion@gmail.com> wrote:
>> please look at the similar list for v15+ (596b5af1d..HEAD).
> I've now pushed most of these but didn't include the following ones:
Thank you!
>> 3. BufFileOpenShared -> BufFileOpenFileSet // see dcac5e7ac
> Maybe I need to spend longer, but I just didn't believe the command
> that claimed that "BufFiles opened using BufFileOpenFileSet() are
> read-only by definition". Looking at the code for that, it seems to
> depend on if O_RDONLY is included in the mode flags.
I've found the following explanation for that:
1) As of dcac5e7ac~1 function ltsConcatWorkerTapes() contained:
...
file = BufFileOpenShared(fileset, filename, O_RDONLY);
...
* The only thing that currently prevents writing to the leader tape from
* working is the fact that BufFiles opened using BufFileOpenShared() are
* read-only by definition, but that could be changed if it seemed
...
2) A patch [1], which eventually resulted in c4649cce3, initially started
with the change:
-ltsConcatWorkerTapes(LogicalTapeSet *lts, TapeShare *shared,
...
- * working is the fact that BufFiles opened using BufFileOpenShared() are
...
+LogicalTapeImport(LogicalTapeSet *lts, int worker, TapeShare *shared)
...
+ file = BufFileOpenShared(lts->fileset, filename, O_RDONLY);
...
+ * the fact that BufFiles opened using BufFileOpenShared() are read-only
3) The commit dcac5e7ac (pushed 2021-08-30) renamed the function
BufFileOpenShared() to BufFileOpenFileSet() and changed the comment:
...
* The only thing that currently prevents writing to the leader tape from
- * working is the fact that BufFiles opened using BufFileOpenShared() are
+ * working is the fact that BufFiles opened using BufFileOpenFileSet() are
* read-only by definition, but that could be changed if it seemed
...
4) The commit c4649cce3 (pushed 2021-10-18) removed the comment referencing
BufFileOpenFileSet() and added that somewhat distant comment
referencing BufFileOpenShared():
$ git show c4649cce3 src/backend/utils/sort/logtape.c | grep 'BufFiles opened'
- * working is the fact that BufFiles opened using BufFileOpenFileSet() are
+ * the fact that BufFiles opened using BufFileOpenShared() are read-only
So I still believe that the "BufFileOpenShared -> BufFileOpenFileSet" change
is correct and that comment can be read now as referencing to the line:
file = BufFileOpenFileSet(<s->fileset->fs, filename, O_RDONLY, false);
in LogicalTapeImport(). Although it could be improved, for sure.
Please look at the following two bunches for v14+ and v13+ (split to ease
back-patching if needed). Having processed them, I've reached the state that
could be considered "clean" ([2], [3]); at least I don't see how to detect
yet more errors of this class in dozens, so it's my last run for now (though I
have several entities left, which I couldn't find replacements for).
v14+:
1. AsyncCtl -> NotifyCtl // renamed in 5da14938f
2. ATExecConstrRecurse -> ATExecAlterConstrRecurse
3. attlocal -> attislocal
4. before_shmem_access -> before_shmem_exit
5. bodys -> bodies
6. can_getnextslot_tidrange -> scan_getnextslot_tidrange
7. DISABLE_ATOMICS -> HAVE_ATOMICS
8. FETCH_H -> REWIND_SOURCE_H
9. filed -> field
10. find_minmax_aggs_walker -> can_minmax_aggs // renamed in 0a2bc5d61e
11. GroupExprInfo -> GroupVarInfo //// a4d75c86b
12. LD_DEAD -> LP_DEAD
13. libpq-trace.c -> fe-trace.c
14. lowerItem -> lowestItem //// bb437f995
15. has_privs -> has_privs_of_role
16. heap_hot_prune_opt -> heap_page_prune_opt
17. MAX_CONVERSION_LENGTH -> MAX_CONVERSION_INPUT_LENGTH //// ea1b99a66
18. MAX_FLUSH_BUFFERS -> MAX_WRITEALL_BUFFERS // renamed in dee663f78
19. myscheam -> myschema // doc/ -- maybe should be backpatched
20. pgbestat_beinit -> pgstat_beinit
21. pgWALUsage -> pgWalUsage
22. point-in-time-recovery -> point-in-time recovery
23. PQnotify -> PGnotify
24. QUERYJUBLE_H -> QUERYJUMBLE_H
25. rd_partdesc_nodetach -> rd_partdesc_nodetached
26. ReadNewTransactionid -> GetNewTransactionId
27. RelationBuildDescr -> RelationBuildDesc
28. SnapBuildCommittedTxn -> SnapBuildCommitTxn // see DecodeCommit()
29. subscription_rel -> pg_subscription_rel
30. tap_rep -> tab_rep
31. total_heap_blks -> heap_blks_total
32. tuple_cids -> tuplecids
33. WatchLatch -> WaitLatch
34. WriteAll -> SimpleLruWriteAll
35. PageIsPrunable -- remove // that define and the PageIsPrunable() check above were removed in dc7420c2c
Candidates for removal:
BARRIER_SHOULD_CHECK //unused since a3ed4d1ef
EXE_EXT // unused since f06b1c598
get_toast_for // unused since 860593ec3
SizeOfCommitTsSet // unused since 08aa89b32
v13+:
1. agg_init_trans_check -> agg_trans
2. agg_strict_trans_check -> agg_trans
3. amopclassopts -> amoptsprocnum //// since 911e70207
4. CommitTSBuffer -> CommitTsBuffer // the inconsistency exists since 5da14938f; maybe this change should be backpatched
5. gist_intbig_ops -> gist__intbig_ops
6. gist_int_ops -> gist__int_ops
7. laftleft -> lastleft
8. lc_message -> locale_name // in accordance with the search_locale_enum() description
9. leftype -> lefttype
10. mksafefunc -> mkfunc // see 1f474d299
11. openSegment -> segment_open // in accordance with the WALRead() description
12. parse_util.c -> parse_utilcmd.c
13. process_innerer_partition -> process_inner_partition
14. read_spilled_tuple -> hashagg_batch_read
15. SortGroupNode -> SortGroupClause
16. SWITCH_WAL -> XLOG_SWITCH
17. tts_attr -> ttc_attr
18. tts_oldvalues -> ttc_oldvalues
19. tts_oldisnull -> ttc_oldisnull
20. tts_rel -> ttc_rel
21. taget -> target
22. WALSnd -> WalSnd
23. XLogRoutine -> XLogReaderRoutine
Candidates for removal:
endterm // see 60c90c16c -- Use xreflabel attributes instead of endterm attributes ...
package_tarname // not used since introduction in 1933ae629
my $clearpass = "FooBaR1"; // unreferenced since b846091fd
[1] https://www.postgresql.org/message-id/91284957-3cb2-944e-5f14-5c2ff86b49fa%40iki.fi
(0001-Refactor-LogicalTapeSet-LogicalTape-interface.patch)
[2] https://www.postgresql.org/message-id/flat/5da8e325-c665-da95-21e0-c8a99ea61fbf%40gmail.com
[3] https://www.postgresql.org/message-id/flat/CALDaNm0ni%2BGAOe4%2BfbXiOxNrVudajMYmhJFtXGX-zBPoN8ixhw%4...
Best regards,
Alexander
Attachments:
[text/x-patch] typo-fixes-for-v14+.1-10.patch (5.3K, ../e8c38840-596a-83d6-bd8d-cebc51111572@gmail.com/2-typo-fixes-for-v14+.1-10.patch)
download | inline diff:diff --git a/config/config.sub b/config/config.subindex de4259e404..3c26ae98b2 100644--- a/config/config.sub+++ b/config/config.sub@@ -1721,7 +1721,7 @@ case $os in
# Likewise for "kernel-abi"
eabi* | gnueabi*)
;;
- # VxWorks passes extra cpu info in the 4th filed.+ # VxWorks passes extra cpu info in the 4th field.
simlinux | simwindows | spe)
;;
# Now accept the basic system types.
diff --git a/src/backend/access/transam/slru.c b/src/backend/access/transam/slru.cindex 5ab86238a9..bf3a2b843a 100644--- a/src/backend/access/transam/slru.c+++ b/src/backend/access/transam/slru.c@@ -1478,7 +1478,7 @@ SlruPagePrecedesTestOffset(SlruCtl ctl, int per_page, uint32 offset)
*
* This assumes every uint32 >= FirstNormalTransactionId is a valid key. It
* assumes each value occupies a contiguous, fixed-size region of SLRU bytes.
- * (MultiXactMemberCtl separates flags from XIDs. AsyncCtl has+ * (MultiXactMemberCtl separates flags from XIDs. NotifyCtl has
* variable-length entries, no keys, and no random access. These unit tests
* do not apply to them.)
*/
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.cindex 343fe61115..6536cf2418 100644--- a/src/backend/commands/tablecmds.c+++ b/src/backend/commands/tablecmds.c@@ -8017,7 +8017,7 @@ ATPrepDropExpression(Relation rel, AlterTableCmd *cmd, bool recurse, bool recurs
* is a bit complicated. GENERATED clauses must be attached to the column
* definition and cannot be added later like DEFAULT, so if a child table
* has a generation expression that the parent does not have, the child
- * column will necessarily be an attlocal column. So to implement ONLY+ * column will necessarily be an attislocal column. So to implement ONLY
* here, we'd need extra code to update attislocal of the direct child
* tables, somewhat similar to how DROP COLUMN does it, so that the
* resulting state can be properly dumped and restored.
@@ -10930,7 +10930,7 @@ ATExecAlterConstraint(Relation rel, AlterTableCmd *cmd, bool recurse,
}
/*
- * ATExecConstrRecurse already invalidated relcache for the relations+ * ATExecAlterConstrRecurse already invalidated relcache for the relations
* having the constraint itself; here we also invalidate for relations
* that have any triggers that are part of the constraint.
*/
diff --git a/src/backend/optimizer/plan/planagg.c b/src/backend/optimizer/plan/planagg.cindex d168620665..a6090167f5 100644--- a/src/backend/optimizer/plan/planagg.c+++ b/src/backend/optimizer/plan/planagg.c@@ -386,7 +386,7 @@ build_minmax_path(PlannerInfo *root, MinMaxAggInfo *mminfo,
ntest = makeNode(NullTest);
ntest->nulltesttype = IS_NOT_NULL;
ntest->arg = copyObject(mminfo->target);
- /* we checked it wasn't a rowtype in find_minmax_aggs_walker */+ /* we checked it wasn't a rowtype in can_minmax_aggs */
ntest->argisrow = false;
ntest->location = -1;
diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.yindex acf6cf4866..a723d9db78 100644--- a/src/backend/parser/gram.y+++ b/src/backend/parser/gram.y@@ -957,7 +957,7 @@ stmtmulti: stmtmulti ';' toplevel_stmt
/*
* toplevel_stmt includes BEGIN and END. stmt does not include them, because
- * those words have different meanings in function bodys.+ * those words have different meanings in function bodies.
*/
toplevel_stmt:
stmt
diff --git a/src/backend/storage/file/fd.c b/src/backend/storage/file/fd.cindex 277a28fc13..4f86d44d6e 100644--- a/src/backend/storage/file/fd.c+++ b/src/backend/storage/file/fd.c@@ -3069,7 +3069,7 @@ AtEOXact_Files(bool isCommit)
/*
* BeforeShmemExit_Files
*
- * before_shmem_access hook to clean up temp files during backend shutdown.+ * before_shmem_exit hook to clean up temp files during backend shutdown.
* Here, we want to clean up *all* temp files including interXact ones.
*/
static void
diff --git a/src/backend/storage/lmgr/spin.c b/src/backend/storage/lmgr/spin.cindex e406bea201..6052779d9c 100644--- a/src/backend/storage/lmgr/spin.c+++ b/src/backend/storage/lmgr/spin.c@@ -37,7 +37,7 @@
#define NUM_EMULATION_SEMAPHORES (NUM_SPINLOCK_SEMAPHORES + NUM_ATOMICS_SEMAPHORES)
#else
#define NUM_EMULATION_SEMAPHORES (NUM_SPINLOCK_SEMAPHORES)
-#endif /* DISABLE_ATOMICS */+#endif /* HAVE_ATOMICS */
PGSemaphore *SpinlockSemaArray;
diff --git a/src/bin/pg_rewind/rewind_source.h b/src/bin/pg_rewind/rewind_source.hindex 69ad0e495f..98af3b58ee 100644--- a/src/bin/pg_rewind/rewind_source.h+++ b/src/bin/pg_rewind/rewind_source.h@@ -83,4 +83,4 @@ extern rewind_source *init_libpq_source(PGconn *conn);
/* in local_source.c */
extern rewind_source *init_local_source(const char *datadir);
-#endif /* FETCH_H */+#endif /* REWIND_SOURCE_H */diff --git a/src/include/access/tableam.h b/src/include/access/tableam.hindex bb6d4f0315..b19d50ecc2 100644--- a/src/include/access/tableam.h+++ b/src/include/access/tableam.h@@ -358,7 +358,7 @@ typedef struct TableAmRoutine
* allowed by the AM.
*
* Implementations can assume that scan_set_tidrange is always called
- * before can_getnextslot_tidrange or after scan_rescan and before any+ * before scan_getnextslot_tidrange or after scan_rescan and before any
* further calls to scan_getnextslot_tidrange.
*/
void (*scan_set_tidrange) (TableScanDesc scan,
[text/x-patch] typo-fixes-for-v14+.11-20.patch (6.6K, ../e8c38840-596a-83d6-bd8d-cebc51111572@gmail.com/3-typo-fixes-for-v14+.11-20.patch)
download | inline diff:diff --git a/doc/src/sgml/ref/pg_amcheck.sgml b/doc/src/sgml/ref/pg_amcheck.sgmlindex cfef6c0465..20c2897acc 100644--- a/doc/src/sgml/ref/pg_amcheck.sgml+++ b/doc/src/sgml/ref/pg_amcheck.sgml@@ -160,7 +160,7 @@ PostgreSQL documentation
Patterns may be unqualified, e.g. <literal>myrel*</literal>, or they
may be schema-qualified, e.g. <literal>myschema*.myrel*</literal> or
database-qualified and schema-qualified, e.g.
- <literal>mydb*.myscheam*.myrel*</literal>. A database-qualified+ <literal>mydb*.myschema*.myrel*</literal>. A database-qualified
pattern will add matching databases to the list of databases to be
checked.
</para>
diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.cindex b300a4675e..0124f37911 100644--- a/src/backend/access/heap/heapam.c+++ b/src/backend/access/heap/heapam.c@@ -1223,7 +1223,7 @@ heap_set_tidrange(TableScanDesc sscan, ItemPointer mintid,
* Calculate the first block and the number of blocks we must scan. We
* could be more aggressive here and perform some more validation to try
* and further narrow the scope of blocks to scan by checking if the
- * lowerItem has an offset above MaxOffsetNumber. In this case, we could+ * lowestItem has an offset above MaxOffsetNumber. In this case, we could
* advance startBlk by one. Likewise, if highestItem has an offset of 0
* we could scan one fewer blocks. However, such an optimization does not
* seem worth troubling over, currently.
diff --git a/src/backend/access/heap/pruneheap.c b/src/backend/access/heap/pruneheap.cindex 3f0342351f..087424d37a 100644--- a/src/backend/access/heap/pruneheap.c+++ b/src/backend/access/heap/pruneheap.c@@ -490,7 +490,7 @@ heap_page_prune(Relation relation, Buffer buffer,
*
* Due to its cost we also only want to call
* TransactionIdLimitedForOldSnapshots() if necessary, i.e. we might not have
- * done so in heap_hot_prune_opt() if pd_prune_xid was old enough. But we+ * done so in heap_page_prune_opt() if pd_prune_xid was old enough. But we
* still want to be able to remove rows that are too new to be removed
* according to prstate->vistest, but that can be removed based on
* old_snapshot_threshold. So we call TransactionIdLimitedForOldSnapshots() on
diff --git a/src/backend/access/heap/vacuumlazy.c b/src/backend/access/heap/vacuumlazy.cindex 0a9ebd22bd..a03a7ce453 100644--- a/src/backend/access/heap/vacuumlazy.c+++ b/src/backend/access/heap/vacuumlazy.c@@ -2571,7 +2571,7 @@ lazy_vacuum_heap_page(LVRelState *vacrel, BlockNumber blkno, Buffer buffer,
END_CRIT_SECTION();
/*
- * Now that we have removed the LD_DEAD items from the page, once again+ * Now that we have removed the LP_DEAD items from the page, once again
* check if the page has become all-visible. The page is already marked
* dirty, exclusively locked, and, if needed, a full page image has been
* emitted.
diff --git a/src/backend/access/transam/slru.c b/src/backend/access/transam/slru.cindex bf3a2b843a..9ddd5b811e 100644--- a/src/backend/access/transam/slru.c+++ b/src/backend/access/transam/slru.c@@ -864,7 +864,7 @@ SlruPhysicalWritePage(SlruCtl ctl, int pageno, int slotno, SlruWriteAll fdata)
else
{
/*
- * In the unlikely event that we exceed MAX_FLUSH_BUFFERS,+ * In the unlikely event that we exceed MAX_WRITEALL_BUFFERS,
* fall back to treating it as a standalone write.
*/
fdata = NULL;
diff --git a/src/backend/utils/activity/backend_status.c b/src/backend/utils/activity/backend_status.cindex 391d5de043..a8f927f540 100644--- a/src/backend/utils/activity/backend_status.c+++ b/src/backend/utils/activity/backend_status.c@@ -283,7 +283,7 @@ pgstat_beinit(void)
*
* Apart from auxiliary processes, MyBackendId, MyDatabaseId,
* session userid, and application_name must be set for a
- * backend (hence, this cannot be combined with pgbestat_beinit).+ * backend (hence, this cannot be combined with pgstat_beinit).
* Note also that we must be inside a transaction if this isn't an aux
* process, as we may need to do encoding conversion on some strings.
* ----------
diff --git a/src/backend/utils/adt/acl.c b/src/backend/utils/adt/acl.cindex 729ebd86d1..c660fd3e70 100644--- a/src/backend/utils/adt/acl.c+++ b/src/backend/utils/adt/acl.c@@ -4717,8 +4717,8 @@ pg_has_role_id_id(PG_FUNCTION_ARGS)
* Convert text string to AclMode value.
*
* We use USAGE to denote whether the privileges of the role are accessible
- * (has_privs), MEMBER to denote is_member, and MEMBER WITH GRANT OPTION- * (or ADMIN OPTION) to denote is_admin. There is no ACL bit corresponding+ * (has_privs_of_role), MEMBER to denote is_member, and MEMBER WITH GRANT+ * (or ADMIN) OPTION to denote is_admin. There is no ACL bit corresponding
* to MEMBER so we cheat and use ACL_CREATE for that. This convention
* is shared only with pg_role_aclcheck, below.
*/
diff --git a/src/backend/utils/adt/selfuncs.c b/src/backend/utils/adt/selfuncs.cindex fe37e65af0..c4fcd0076e 100644--- a/src/backend/utils/adt/selfuncs.c+++ b/src/backend/utils/adt/selfuncs.c@@ -4210,7 +4210,7 @@ estimate_multivariate_ndistinct(PlannerInfo *root, RelOptInfo *rel,
* Process complex expressions, not just simple Vars.
*
* First, we search for an exact match of an expression. If we
- * find one, we can just discard the whole GroupExprInfo, with all+ * find one, we can just discard the whole GroupVarInfo, with all
* the variables we extracted from it.
*
* Otherwise we inspect the individual vars, and try matching it
diff --git a/src/backend/utils/mb/mbutils.c b/src/backend/utils/mb/mbutils.cindex 033647011b..67a1ab2ab2 100644--- a/src/backend/utils/mb/mbutils.c+++ b/src/backend/utils/mb/mbutils.c@@ -453,7 +453,7 @@ pg_do_encoding_conversion(unsigned char *src, int len,
*
* The output is null-terminated.
*
- * If destlen < srclen * MAX_CONVERSION_LENGTH + 1, the converted output+ * If destlen < srclen * MAX_CONVERSION_INPUT_LENGTH + 1, the converted output
* wouldn't necessarily fit in the output buffer, and the function will not
* convert the whole input.
*
diff --git a/src/interfaces/libpq/libpq-int.h b/src/interfaces/libpq/libpq-int.hindex ce0167c1b6..3c9f589278 100644--- a/src/interfaces/libpq/libpq-int.h+++ b/src/interfaces/libpq/libpq-int.h@@ -872,7 +872,7 @@ extern ssize_t pg_GSS_write(PGconn *conn, const void *ptr, size_t len);
extern ssize_t pg_GSS_read(PGconn *conn, void *ptr, size_t len);
#endif
-/* === in libpq-trace.c === */+/* === in fe-trace.c === */
extern void pqTraceOutputMessage(PGconn *conn, const char *message,
bool toServer);
[text/x-patch] typo-fixes-for-v14+.21-30.patch (6.4K, ../e8c38840-596a-83d6-bd8d-cebc51111572@gmail.com/4-typo-fixes-for-v14+.21-30.patch)
download | inline diff:diff --git a/src/backend/commands/subscriptioncmds.c b/src/backend/commands/subscriptioncmds.cindex 56eafbff10..8b3de032ee 100644--- a/src/backend/commands/subscriptioncmds.c+++ b/src/backend/commands/subscriptioncmds.c@@ -974,8 +974,8 @@ AlterSubscription_refresh(Subscription *sub, bool copy_data,
*
* Even if new worker for this particular rel is restarted it
* won't be able to make any progress as we hold exclusive
- * lock on subscription_rel till the transaction end. It will- * simply exit as there is no corresponding rel entry.+ * lock on pg_subscription_rel till the transaction end. It+ * will simply exit as there is no corresponding rel entry.
*
* This locking also ensures that the state of rels won't
* change till we are done with this refresh operation.
diff --git a/src/backend/partitioning/partdesc.c b/src/backend/partitioning/partdesc.cindex de06caccd2..7a2b5e57ff 100644--- a/src/backend/partitioning/partdesc.c+++ b/src/backend/partitioning/partdesc.c@@ -55,7 +55,7 @@ static PartitionDesc RelationBuildPartitionDesc(Relation rel,
* RelationGetPartitionDesc -- get partition descriptor, if relation is partitioned
*
* We keep two partdescs in relcache: rd_partdesc includes all partitions
- * (even those being concurrently marked detached), while rd_partdesc_nodetach+ * (even those being concurrently marked detached), while rd_partdesc_nodetached
* omits (some of) those. We store the pg_inherits.xmin value for the latter,
* to determine whether it can be validly reused in each case, since that
* depends on the active snapshot.
diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.cindex 9f44974473..d6d48210ce 100644--- a/src/backend/replication/logical/reorderbuffer.c+++ b/src/backend/replication/logical/reorderbuffer.c@@ -4010,7 +4010,7 @@ ReorderBufferStreamTXN(ReorderBuffer *rb, ReorderBufferTXN *txn)
* After that we need to reuse the snapshot from the previous run.
*
* Unlike DecodeCommit which adds xids of all the subtransactions in
- * snapshot's xip array via SnapBuildCommittedTxn, we can't do that here+ * snapshot's xip array via SnapBuildCommitTxn, we can't do that here
* but we do add them to subxip array instead via ReorderBufferCopySnap.
* This allows the catalog changes made in subtransactions decoded till
* now to be visible.
diff --git a/src/backend/storage/ipc/procarray.c b/src/backend/storage/ipc/procarray.cindex fc05e2e293..db50301a63 100644--- a/src/backend/storage/ipc/procarray.c+++ b/src/backend/storage/ipc/procarray.c@@ -1760,7 +1760,7 @@ ComputeXidHorizons(ComputeXidHorizonsResult *h)
* current top-level xid any.
*
* Without an assigned xid we could use a horizon as aggressive as
- * ReadNewTransactionid(), but we can get away with the much cheaper+ * GetNewTransactionId(), but we can get away with the much cheaper
* latestCompletedXid + 1: If this backend has no xid there, by
* definition, can't be any newer changes in the temp table than
* latestCompletedXid.
diff --git a/src/backend/utils/activity/pgstat_wal.c b/src/backend/utils/activity/pgstat_wal.cindex 94f1a3b06e..bcaed14d02 100644--- a/src/backend/utils/activity/pgstat_wal.c+++ b/src/backend/utils/activity/pgstat_wal.c@@ -24,7 +24,7 @@
PgStat_PendingWalStats PendingWalStats = {0};
/*
- * WAL usage counters saved from pgWALUsage at the previous call to+ * WAL usage counters saved from pgWalUsage at the previous call to
* pgstat_report_wal(). This is used to calculate how much WAL usage
* happens between pgstat_report_wal() calls, by subtracting
* the previous counters from the current ones.
diff --git a/src/include/nodes/queryjumble.h b/src/include/nodes/queryjumble.hindex 204b8f74fd..3499bfd4a0 100644--- a/src/include/nodes/queryjumble.h+++ b/src/include/nodes/queryjumble.h@@ -11,8 +11,8 @@
*
*-------------------------------------------------------------------------
*/
-#ifndef QUERYJUBLE_H-#define QUERYJUBLE_H+#ifndef QUERYJUMBLE_H+#define QUERYJUMBLE_H
#include "nodes/parsenodes.h"
diff --git a/src/include/pg_config_manual.h b/src/include/pg_config_manual.hindex 33ec6102c1..a1a93ad706 100644--- a/src/include/pg_config_manual.h+++ b/src/include/pg_config_manual.h@@ -317,7 +317,7 @@
/*
* Recover memory used for relcache entries when invalidated. See
- * RelationBuildDescr() in src/backend/utils/cache/relcache.c.+ * RelationBuildDesc() in src/backend/utils/cache/relcache.c.
*
* This is active automatically for clobber-cache builds when clobbering is
* active, but can be overridden here by explicitly defining
diff --git a/src/interfaces/libpq/fe-protocol3.c b/src/interfaces/libpq/fe-protocol3.cindex 8ab6a88416..698124e887 100644--- a/src/interfaces/libpq/fe-protocol3.c+++ b/src/interfaces/libpq/fe-protocol3.c@@ -1500,7 +1500,7 @@ getNotify(PGconn *conn)
}
/*
- * Store the strings right after the PQnotify structure so it can all be+ * Store the strings right after the PGnotify structure so it can all be
* freed at once. We don't use NAMEDATALEN because we don't want to tie
* this interface to a specific server name length.
*/
diff --git a/src/test/recovery/t/023_pitr_prepared_xact.pl b/src/test/recovery/t/023_pitr_prepared_xact.plindex 6f5a33623f..e55098ef7f 100644--- a/src/test/recovery/t/023_pitr_prepared_xact.pl+++ b/src/test/recovery/t/023_pitr_prepared_xact.pl@@ -1,7 +1,7 @@
# Copyright (c) 2021-2023, PostgreSQL Global Development Group
-# Test for point-in-time-recovery (PITR) with prepared transactions+# Test for point-in-time recovery (PITR) with prepared transactions
use strict;
use warnings;
use PostgreSQL::Test::Cluster;
diff --git a/src/test/subscription/t/004_sync.pl b/src/test/subscription/t/004_sync.plindex 87381c0829..aa7714c533 100644--- a/src/test/subscription/t/004_sync.pl+++ b/src/test/subscription/t/004_sync.pl@@ -149,7 +149,7 @@ $node_publisher->safe_psql('postgres', "DROP TABLE tab_rep_next");
$node_subscriber->safe_psql('postgres', "DROP TABLE tab_rep_next");
$node_subscriber->safe_psql('postgres', "DROP SUBSCRIPTION tap_sub");
-# Table tap_rep already has the same records on both publisher and subscriber+# Table tab_rep already has the same records on both publisher and subscriber
# at this time. Recreate the subscription which will do the initial copy of
# the table again and fails due to unique constraint violation.
$node_subscriber->safe_psql('postgres',
[text/x-patch] typo-fixes-for-v14+.31-35.patch (2.9K, ../e8c38840-596a-83d6-bd8d-cebc51111572@gmail.com/5-typo-fixes-for-v14+.31-35.patch)
download | inline diff:diff --git a/src/backend/access/heap/heapam_handler.c b/src/backend/access/heap/heapam_handler.cindex e2e35b71ea..cbb35aa73d 100644--- a/src/backend/access/heap/heapam_handler.c+++ b/src/backend/access/heap/heapam_handler.c@@ -816,7 +816,7 @@ heapam_relation_copy_for_cluster(Relation OldHeap, Relation NewHeap,
* If the last pages of the scan were empty, we would go to
* the next phase while heap_blks_scanned != heap_blks_total.
* Instead, to ensure that heap_blks_scanned is equivalent to
- * total_heap_blks after the table scan phase, this parameter+ * heap_blks_total after the table scan phase, this parameter
* is manually updated to the correct value when the table
* scan finishes.
*/
diff --git a/src/backend/access/heap/pruneheap.c b/src/backend/access/heap/pruneheap.cindex 087424d37a..20df39c149 100644--- a/src/backend/access/heap/pruneheap.c+++ b/src/backend/access/heap/pruneheap.c@@ -198,8 +198,7 @@ heap_page_prune_opt(Relation relation, Buffer buffer)
/*
* Now that we have buffer lock, get accurate information about the
* page's free space, and recheck the heuristic about whether to
- * prune. (We needn't recheck PageIsPrunable, since no one else could- * have pruned while we hold pin.)+ * prune.
*/
if (PageIsFull(page) || PageGetHeapFreeSpace(page) < minfree)
{
diff --git a/src/backend/access/transam/slru.c b/src/backend/access/transam/slru.cindex 9ddd5b811e..edea06827d 100644--- a/src/backend/access/transam/slru.c+++ b/src/backend/access/transam/slru.c@@ -809,7 +809,7 @@ SlruPhysicalWritePage(SlruCtl ctl, int pageno, int slotno, SlruWriteAll fdata)
}
/*
- * During a WriteAll, we may already have the desired file open.+ * During a SimpleLruWriteAll, we may already have the desired file open.
*/
if (fdata)
{
diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.cindex d6d48210ce..b85b890010 100644--- a/src/backend/replication/logical/reorderbuffer.c+++ b/src/backend/replication/logical/reorderbuffer.c@@ -1885,7 +1885,7 @@ ReorderBufferStreamCommit(ReorderBuffer *rb, ReorderBufferTXN *txn)
/*
* This is a PREPARED transaction, part of a two-phase commit. The
* full cleanup will happen as part of the COMMIT PREPAREDs, so now
- * just truncate txn by removing changes and tuple_cids.+ * just truncate txn by removing changes and tuplecids.
*/
ReorderBufferTruncateTXN(rb, txn, true);
/* Reset the CheckXidAlive */
diff --git a/src/backend/storage/ipc/latch.c b/src/backend/storage/ipc/latch.cindex f4123e7de7..cdb95c1931 100644--- a/src/backend/storage/ipc/latch.c+++ b/src/backend/storage/ipc/latch.c@@ -151,7 +151,7 @@ struct WaitEventSet
#endif
};
-/* A common WaitEventSet used to implement WatchLatch() */+/* A common WaitEventSet used to implement WaitLatch() */
static WaitEventSet *LatchWaitSet;
/* The position of the latch in LatchWaitSet. */
[text/x-patch] typo-fixes-for-v13+.1-10.patch (4.9K, ../e8c38840-596a-83d6-bd8d-cebc51111572@gmail.com/6-typo-fixes-for-v13+.1-10.patch)
download | inline diff:diff --git a/contrib/intarray/_int.h b/contrib/intarray/_int.hindex a52ec38ba4..0352cbd368 100644--- a/contrib/intarray/_int.h+++ b/contrib/intarray/_int.h@@ -15,7 +15,7 @@
((GISTIntArrayOptions *) PG_GET_OPCLASS_OPTIONS())->num_ranges : \
G_INT_NUMRANGES_DEFAULT)
-/* gist_int_ops opclass options */+/* gist__int_ops opclass options */
typedef struct
{
int32 vl_len_; /* varlena header (do not touch directly!) */
@@ -80,7 +80,7 @@ typedef char *BITVECP;
#define HASHVAL(val, siglen) (((unsigned int)(val)) % SIGLENBIT(siglen))
#define HASH(sign, val, siglen) SETBIT((sign), HASHVAL(val, siglen))
-/* gist_intbig_ops opclass options */+/* gist__intbig_ops opclass options */
typedef struct
{
int32 vl_len_; /* varlena header (do not touch directly!) */
diff --git a/src/backend/access/nbtree/nbtsplitloc.c b/src/backend/access/nbtree/nbtsplitloc.cindex ecb49bb471..43b67893d9 100644--- a/src/backend/access/nbtree/nbtsplitloc.c+++ b/src/backend/access/nbtree/nbtsplitloc.c@@ -119,7 +119,7 @@ static inline IndexTuple _bt_split_firstright(FindSplitData *state,
* righthand page (which is called firstrightoff), plus a boolean
* indicating whether the new tuple goes on the left or right page. You
* can think of the returned state as a point _between_ two adjacent data
- * items (laftleft and firstright data items) on an imaginary version of+ * items (lastleft and firstright data items) on an imaginary version of
* origpage that already includes newitem. The bool is necessary to
* disambiguate the case where firstrightoff == newitemoff (i.e. it is
* sometimes needed to determine if the firstright tuple for the split is
diff --git a/src/backend/commands/opclasscmds.c b/src/backend/commands/opclasscmds.cindex 864e35e45b..5f7ee23886 100644--- a/src/backend/commands/opclasscmds.c+++ b/src/backend/commands/opclasscmds.c@@ -819,7 +819,7 @@ AlterOpFamily(AlterOpFamilyStmt *stmt)
Oid amoid, /* our AM's oid */
opfamilyoid; /* oid of opfamily */
int maxOpNumber, /* amstrategies value */
- optsProcNumber, /* amopclassopts value */+ optsProcNumber, /* amoptsprocnum value */
maxProcNumber; /* amsupport value */
HeapTuple tup;
Form_pg_am amform;
@@ -1321,7 +1321,7 @@ assignProcTypes(OpFamilyMember *member, Oid amoid, Oid typeoid,
/*
* pg_amproc functions are indexed by (lefttype, righttype), but
* an equalimage function can only be called at CREATE INDEX time.
- * The same opclass opcintype OID is always used for leftype and+ * The same opclass opcintype OID is always used for lefttype and
* righttype. Providing a cross-type routine isn't sensible.
* Reject cross-type ALTER OPERATOR FAMILY ... ADD FUNCTION 4
* statements here.
diff --git a/src/backend/jit/llvm/llvmjit_expr.c b/src/backend/jit/llvm/llvmjit_expr.cindex daefe66f40..cc6e4a8575 100644--- a/src/backend/jit/llvm/llvmjit_expr.c+++ b/src/backend/jit/llvm/llvmjit_expr.c@@ -2121,8 +2121,8 @@ llvm_compile_expr(ExprState *state)
/*
* pergroup = &aggstate->all_pergroups
- * [op->d.agg_strict_trans_check.setoff]- * [op->d.agg_init_trans_check.transno];+ * [op->d.agg_trans.setoff]+ * [op->d.agg_trans.transno];
*/
v_allpergroupsp =
l_load_struct_gep(b, v_aggstatep,
diff --git a/src/backend/storage/lmgr/lwlock.c b/src/backend/storage/lmgr/lwlock.cindex d2ec396045..59347ab951 100644--- a/src/backend/storage/lmgr/lwlock.c+++ b/src/backend/storage/lmgr/lwlock.c@@ -135,7 +135,7 @@ static const char *const BuiltinTrancheNames[] = {
/* LWTRANCHE_XACT_BUFFER: */
"XactBuffer",
/* LWTRANCHE_COMMITTS_BUFFER: */
- "CommitTSBuffer",+ "CommitTsBuffer",
/* LWTRANCHE_SUBTRANS_BUFFER: */
"SubtransBuffer",
/* LWTRANCHE_MULTIXACTOFFSET_BUFFER: */
diff --git a/src/backend/utils/adt/pg_locale.c b/src/backend/utils/adt/pg_locale.cindex 51df570ce9..f0b6567da1 100644--- a/src/backend/utils/adt/pg_locale.c+++ b/src/backend/utils/adt/pg_locale.c@@ -1012,7 +1012,7 @@ search_locale_enum(LPWSTR pStr, DWORD dwFlags, LPARAM lparam)
{
/*
* If the enumerated locale does not have a hyphen ("en") OR the
- * lc_message input does not have an underscore ("English"), we only+ * locale_name input does not have an underscore ("English"), we only
* need to compare the <Language> tags.
*/
if (wcsrchr(pStr, '-') == NULL || wcsrchr(argv[0], '_') == NULL)
diff --git a/src/pl/plperl/plperl.c b/src/pl/plperl/plperl.cindex d7d9c1bee3..3f343fff16 100644--- a/src/pl/plperl/plperl.c+++ b/src/pl/plperl/plperl.c@@ -2109,7 +2109,7 @@ plperl_create_sub(plperl_proc_desc *prodesc, const char *s, Oid fn_oid)
/*
* G_KEEPERR seems to be needed here, else we don't recognize compile
* errors properly. Perhaps it's because there's another level of eval
- * inside mksafefunc?+ * inside mkfunc?
*/
count = call_pv("PostgreSQL::InServer::mkfunc",
G_SCALAR | G_EVAL | G_KEEPERR);
[text/x-patch] typo-fixes-for-v13+.11-20.patch (4.7K, ../e8c38840-596a-83d6-bd8d-cebc51111572@gmail.com/7-typo-fixes-for-v13+.11-20.patch)
download | inline diff:diff --git a/src/backend/access/gist/gistxlog.c b/src/backend/access/gist/gistxlog.cindex 9a86fb3fef..8e9afaff30 100644--- a/src/backend/access/gist/gistxlog.c+++ b/src/backend/access/gist/gistxlog.c@@ -580,7 +580,7 @@ gistXLogAssignLSN(void)
int dummy = 0;
/*
- * Records other than SWITCH_WAL must have content. We use an integer 0 to+ * Records other than XLOG_SWITCH must have content. We use an integer 0 to
* follow the restriction.
*/
XLogBeginInsert();
diff --git a/src/backend/access/transam/xlogreader.c b/src/backend/access/transam/xlogreader.cindex cadea21b37..133b09dd69 100644--- a/src/backend/access/transam/xlogreader.c+++ b/src/backend/access/transam/xlogreader.c@@ -1513,7 +1513,7 @@ WALRead(XLogReaderState *state,
/*
* If the data we want is not in a segment we have open, close what we
* have (if anything) and open the next one, using the caller's
- * provided openSegment callback.+ * provided segment_open callback.
*/
if (state->seg.ws_file < 0 ||
!XLByteInSeg(recptr, state->seg.ws_segno, state->segcxt.ws_segsize) ||
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.cindex 6536cf2418..c7a8a689b7 100644--- a/src/backend/commands/tablecmds.c+++ b/src/backend/commands/tablecmds.c@@ -2984,7 +2984,7 @@ MergeAttributes(List *schema, List *supers, char relpersistence,
* generated column, we'll take its generation expression in
* preference to the parent's. We must check that the child
* column doesn't specify a default value or identity, which
- * matches the rules for a single column in parse_util.c.+ * matches the rules for a single column in parse_utilcmd.c.
*
* Conversely, if the parent column is not generated, the
* child column can't be either. (We used to allow that, but
diff --git a/src/backend/executor/nodeAgg.c b/src/backend/executor/nodeAgg.cindex 3aab5a0e80..e71911aa46 100644--- a/src/backend/executor/nodeAgg.c+++ b/src/backend/executor/nodeAgg.c@@ -3006,7 +3006,7 @@ hashagg_batch_new(LogicalTape *input_tape, int setno,
}
/*
- * read_spilled_tuple+ * hashagg_batch_read
* read the next tuple from a batch's tape. Return NULL if no more.
*/
static MinimalTuple
diff --git a/src/backend/partitioning/partbounds.c b/src/backend/partitioning/partbounds.cindex cf1156b842..c685621416 100644--- a/src/backend/partitioning/partbounds.c+++ b/src/backend/partitioning/partbounds.c@@ -2340,7 +2340,7 @@ merge_default_partitions(PartitionMap *outer_map,
/*
* The default partitions have to be joined with each other, so merge
* them. Note that each of the default partitions isn't merged yet
- * (see, process_outer_partition()/process_innerer_partition()), so+ * (see, process_outer_partition()/process_inner_partition()), so
* they should be merged successfully. The merged partition will act
* as the default partition of the join relation.
*/
diff --git a/src/include/access/toast_helper.h b/src/include/access/toast_helper.hindex 96d8e5a685..e971bd2c8e 100644--- a/src/include/access/toast_helper.h+++ b/src/include/access/toast_helper.h@@ -43,7 +43,7 @@ typedef struct
/*
* Before calling toast_tuple_init, the caller must initialize the
* following fields. Each array must have a length equal to
- * ttc_rel->rd_att->natts. The tts_oldvalues and tts_oldisnull fields+ * ttc_rel->rd_att->natts. The ttc_oldvalues and ttc_oldisnull fields
* should be NULL in the case of an insert.
*/
Relation ttc_rel; /* the relation that contains the tuple */
@@ -53,9 +53,9 @@ typedef struct
bool *ttc_oldisnull; /* null flags from previous tuple */
/*
- * Before calling toast_tuple_init, the caller should set tts_attr to+ * Before calling toast_tuple_init, the caller should set ttc_attr to
* point to an array of ToastAttrInfo structures of a length equal to
- * tts_rel->rd_att->natts. The contents of the array need not be+ * ttc_rel->rd_att->natts. The contents of the array need not be
* initialized. ttc_flags also does not need to be initialized.
*/
uint8 ttc_flags;
diff --git a/src/include/nodes/nodeFuncs.h b/src/include/nodes/nodeFuncs.hindex e63b399b8d..20921b45b9 100644--- a/src/include/nodes/nodeFuncs.h+++ b/src/include/nodes/nodeFuncs.h@@ -29,7 +29,7 @@ struct PlanState; /* avoid including execnodes.h too */
#define QTW_EXAMINE_RTES_AFTER 0x20 /* examine RTE nodes after their
* contents */
#define QTW_DONT_COPY_QUERY 0x40 /* do not copy top Query */
-#define QTW_EXAMINE_SORTGROUP 0x80 /* include SortGroupNode lists */+#define QTW_EXAMINE_SORTGROUP 0x80 /* include SortGroupClause lists */
/* callback function for check_functions_in_node */
typedef bool (*check_function_callback) (Oid func_id, void *context);
[text/x-patch] typo-fixes-for-v13+.21-23.patch (1.7K, ../e8c38840-596a-83d6-bd8d-cebc51111572@gmail.com/8-typo-fixes-for-v13+.21-23.patch)
download | inline diff:diff --git a/contrib/amcheck/verify_nbtree.c b/contrib/amcheck/verify_nbtree.cindex eb280d4893..6979aff727 100644--- a/contrib/amcheck/verify_nbtree.c+++ b/contrib/amcheck/verify_nbtree.c@@ -104,7 +104,7 @@ typedef struct BtreeCheckState
/*
* The rightlink and incomplete split flag of block one level down to the
- * target page, which was visited last time via downlink from taget page.+ * target page, which was visited last time via downlink from target page.
* We use it to check for missing downlinks.
*/
BlockNumber prevrightlink;
diff --git a/src/backend/access/transam/xlogreader.c b/src/backend/access/transam/xlogreader.cindex 133b09dd69..631f260f79 100644--- a/src/backend/access/transam/xlogreader.c+++ b/src/backend/access/transam/xlogreader.c@@ -1476,7 +1476,7 @@ err:
}
/*
- * Helper function to ease writing of XLogRoutine->page_read callbacks.+ * Helper function to ease writing of XLogReaderRoutine->page_read callbacks.
* If this function is used, caller must supply a segment_open callback in
* 'state', as that is used here.
*
diff --git a/src/backend/replication/syncrep.c b/src/backend/replication/syncrep.cindex 889e20b5dd..c263a59690 100644--- a/src/backend/replication/syncrep.c+++ b/src/backend/replication/syncrep.c@@ -804,7 +804,7 @@ standby_priority_comparator(const void *a, const void *b)
/*
* We might have equal priority values; arbitrarily break ties by position
- * in the WALSnd array. (This is utterly bogus, since that is arrival+ * in the WalSnd array. (This is utterly bogus, since that is arrival
* order dependent, but there are regression tests that rely on it.)
*/
return sa->walsnd_index - sb->walsnd_index;
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: exclusion@gmail.com, dgrowleyml@gmail.com, pryzby@telsasoft.com
Subject: Re: Fix typos and inconsistencies for v16
In-Reply-To: <e8c38840-596a-83d6-bd8d-cebc51111572@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox