From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
To: Alexey Kondratov <a.kondratov@postgrespro.ru>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: Kuntal Ghosh <kuntalghosh.2007@gmail.com>
Cc: Liudmila Mantrova <l.mantrova@postgrespro.ru>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: David Steele <david@pgmasters.net>
Cc: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: vladimirlesk@yandex-team.ru
Cc: dsarafan@yandex-team.ru
Subject: Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line
Date: Sat, 6 Jun 2020 19:48:57 +0200
Message-ID: <e9766d71-8655-ac86-bdf6-77e0e7169977@2ndquadrant.com> (raw)
In-Reply-To: <20200331064821.GA1549@paquier.xyz>
References: <20200326073458.GJ1471@paquier.xyz>
<20200326215636.GA18768@alvherre.pgsql>
<20200326224729.GB1836@paquier.xyz>
<20200330015648.GA43995@paquier.xyz>
<750ea0322cd68c0973d9ff248909811d@postgrespro.ru>
<20200331064821.GA1549@paquier.xyz>
On 2020-03-31 08:48, Michael Paquier wrote:
> On Mon, Mar 30, 2020 at 05:00:01PM +0300, Alexey Kondratov wrote:
>> What do think about adding following sanity check into xlogarchive.c?
>>
>> +#ifdef FRONTEND
>> +#error "This file is not expected to be compiled for frontend code"
>> +#endif
>>
>> It would prevent someone from adding typedefs and any other common
>> definitions into xlogarchive.h in the future, leading to the accidental
>> inclusion of both xlogarchive.h and fe_archive.h in the same time.
> I don't see much the point as this would fail to compile anyway, and
> that's not project-style. Note that we have already a clear
> separation here between the backend and the frontend code here as
> xlogarchive.h is backend-only and fe_archive.h is frontend-only.
Why is fe_archive.c in src/common/ and not in src/fe_utils/? It is not
"common" to frontend and backend.
It actually defines functions that clash with functions in the backend,
so this seems doubly wrong.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, michael@paquier.xyz, a.kondratov@postgrespro.ru, alvherre@2ndquadrant.com, a.korotkov@postgrespro.ru, kuntalghosh.2007@gmail.com, l.mantrova@postgrespro.ru, thomas.munro@gmail.com, x4mmm@yandex-team.ru, david@pgmasters.net, andres@anarazel.de, 9erthalion6@gmail.com, vladimirlesk@yandex-team.ru, dsarafan@yandex-team.ru
Subject: Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line
In-Reply-To: <e9766d71-8655-ac86-bdf6-77e0e7169977@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox