From: Jeff Davis <pgsql@j-davis.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_dump --with-* options
Date: Tue, 29 Jul 2025 11:24:54 -0700
Message-ID: <f379d0aeefe8effe13302a436bc28f549f09e924.camel@j-davis.com> (raw)
In-Reply-To: <031558c60e84362898922caa6a90587e7fdf2a57.camel@j-davis.com>
References: <7cc52488-f876-4ad3-affd-6e4b0ef0cb09@eisentraut.org>
<aEMLzPQtjRbj2R7X@nathan>
<CA+TgmoactJEUHeXuxHLKNXHzm6-XrQFigPur-4nHTMFSiSRkiQ@mail.gmail.com>
<aErpuM6RXSlK1FBW@nathan>
<7bf0246542713d80f12c738c1d365d1365750c18.camel@j-davis.com>
<5e398522803da9bf3f9fc33ca43084ec21ab0fcd.camel@j-davis.com>
<aFLenfMRS9jFINxq@nathan>
<031558c60e84362898922caa6a90587e7fdf2a57.camel@j-davis.com>
On Wed, 2025-06-18 at 10:21 -0700, Jeff Davis wrote:
> On Wed, 2025-06-18 at 10:43 -0500, Nathan Bossart wrote:
> > IIUC the current proposal is to:
> >
> > * Dump/restore stats by default.
We don't have a consensus for that, so unless a few people make an
abrupt turnaround, this will remain off for v18.
> > * Keep the --no-statistics, --no-schema, and --no-data options.
> > * Keep the --statistics-only, --schema-only, and --data-only
> > options.
> > * Remove the --with-statistics, --with-schema, and --with-data
> > options.
The other parts of the proposal are very similar with mine below:
> * delete the --with-data and --with-schema options as unnecessary
> * (maybe?) rename --with-statistics to --statistics
> * keep --no-statistics, --no-data, --no-schema (or use "without"
> instead?)
> * (maybe?) keep --statistics-only
> * reject the combination of an "only" option and a "with" option
The main difference is whether we:
(a) keep both --statistics and --no-statistics in pg_dump and
pg_restore; or
(b) for pg_dump have --statistics but not --no-statistics and for
pg_restore have --no-statistics but not --statistics.
Option (a) creates redundancies whereas (b) creates a divergence. I
suppose I prefer (a), but I don't have a terribly strong opinion and if
more people prefer (b) then I'll go with that.
Regards,
Jeff Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pgsql@j-davis.com, nathandbossart@gmail.com, robertmhaas@gmail.com, peter@eisentraut.org
Subject: Re: pg_dump --with-* options
In-Reply-To: <f379d0aeefe8effe13302a436bc28f549f09e924.camel@j-davis.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox