pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrey V. Lepikhov <a.lepikhov@postgrespro.ru>
To: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Subject: Extra code in commit_ts.h
Date: Tue, 3 Aug 2021 14:36:34 +0500
Message-ID: <f49aefb5-edbb-633a-af07-3e777023a94d@postgrespro.ru> (raw)

Hi,

I found two extra code lines in commit_ts.h (see attachment).
They confused me during exploring of the code. If they still needed, may 
be add some comments?

-- 
regards,
Andrey Lepikhov
Postgres Professional

Attachments:

excess_code.patch (text/x-patch, 654B) download diff --git a/src/include/access/commit_ts.h b/src/include/access/commit_ts.h index e045dd416f..a1538978c6 100644 --- a/src/include/access/commit_ts.h +++ b/src/include/access/commit_ts.h @@ -15,14 +15,10 @@ #include "datatype/timestamp.h" #include "replication/origin.h" #include "storage/sync.h" -#include "utils/guc.h" extern PGDLLIMPORT bool track_commit_timestamp; -extern bool check_track_commit_timestamp(bool *newval, void **extra, - GucSource source); - extern void TransactionTreeSetCommitTsData(TransactionId xid, int nsubxids, TransactionId *subxids, TimestampTz timestamp, RepOriginId nodeid);

view thread (5+ messages)  latest in thread

Message-ID: <f49aefb5-edbb-633a-af07-3e777023a94d@postgrespro.ru>
Permalink:  ../f49aefb5-edbb-633a-af07-3e777023a94d@postgrespro.ru/
Also on:    postgresql.org/message-id/f49aefb5-edbb-633a-af07-3e777023a94d@postgrespro.ru

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: a.lepikhov@postgrespro.ru, pgsql-hackers@lists.postgresql.org
  Subject: Re: Extra code in commit_ts.h
  In-Reply-To: <f49aefb5-edbb-633a-af07-3e777023a94d@postgrespro.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox