From: Alexander Lakhin <exclusion@gmail.com>
To: Peter Geoghegan <pg@bowt.ie>
To: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #17197: Assert failed on inserting index tuples after VACUUM
Date: Tue, 21 Sep 2021 08:00:01 +0300
Message-ID: <f76a292c-9170-1aef-91a0-59d9443b99a3@gmail.com> (raw)
In-Reply-To: <CAH2-WzkKtu=o=H_xFD1NS1pp-KDUq_akMVnLuYOAN+z4=sZTxA@mail.gmail.com>
References: <17197-9438f31f46705182@postgresql.org>
<CAH2-Wz=37_B-QwOrm1huKF0Dce=7y8kjSq2QhMePLVxaqB+EZQ@mail.gmail.com>
<CAH2-WzkKtu=o=H_xFD1NS1pp-KDUq_akMVnLuYOAN+z4=sZTxA@mail.gmail.com>
Hello Peter,
21.09.2021 00:03, Peter Geoghegan wrote:
> On Mon, Sep 20, 2021 at 1:35 PM Peter Geoghegan <pg@bowt.ie> wrote:
> Before commit 3c3b8a4b our failing offset number would have at least
> found an LP_UNUSED item -- so no assertion failure. After that commit
> the offset's line pointer might actually be positioned "past the end
> of the line pointer array". But that is a valid state for a heap
> page/HOT chain to have -- so the assertion has it wrong.
>
> I'll push a fix soon. Thanks for the report!
Thanks for the fix!
But if that is a valid (or sane) state, then shouldn't the comment "Some
sanity checks" be removed (or updated) too?
Best regards,
Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: exclusion@gmail.com, pg@bowt.ie, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17197: Assert failed on inserting index tuples after VACUUM
In-Reply-To: <f76a292c-9170-1aef-91a0-59d9443b99a3@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox