From: a.akenteva@postgrespro.ru
To: pgsql-hackers@postgresql.org
Subject: A weird bit in pg_upgrade/exec.c
Date: Thu, 09 Nov 2017 18:07:35 +0300
Message-ID: <f9266a85d918a3cf3a386b5148aee666@postgrespro.ru> (raw)
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Hello!
I've came across a weird bit in pg_upgrade/exec.c
We have a function check_bin_dir() which goes like this (old_cluster and
new_cluster are global variables):
void check_bin_dir(ClusterInfo *cluster)
{
...
get_bin_version(&old_cluster);
get_bin_version(&new_cluster);
...
}
This function has two calls:
check_bin_dir(&old_cluster);
check_bin_dir(&new_cluster);
I'd like to substitute these last two lines with this:
get_bin_version(cluster);
Doing it would simplify the patch I'm writing, but I'm worried I might
break something that's been there for a long time and has been working
fine. Is there maybe a reason for it to be this way that I don't happen
to understand?
Also, there's the exact same situation with the get_bin_version()
function in the same file.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: a.akenteva@postgrespro.ru
Subject: Re: A weird bit in pg_upgrade/exec.c
In-Reply-To: <f9266a85d918a3cf3a386b5148aee666@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox