pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alexander Lakhin <exclusion@gmail.com>
To: David Rowley <dgrowleyml@gmail.com>
To: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Use generation memory context for tuplestore.c
Date: Fri, 5 Jul 2024 07:00:00 +0300
Message-ID: <fe7fc8fb-86e5-ecb0-3cb2-dd2c9a6c482f@gmail.com> (raw)
In-Reply-To: <CAApHDvpwG5w1YeHLPD1M-nZ=k1omFUCAmLGNMSctHFR_f8-NYw@mail.gmail.com>
References: <CAApHDvp5Py9g4Rjq7_inL3-MCK1Co2CRt_YWFwTU2zfQix0p4A@mail.gmail.com>
	<CAEze2WiusMw4Ern1HriocdMdt-r+zjw3tKoQn3hCSDRjt5VOyA@mail.gmail.com>
	<CAApHDvr72_Nur=3Zq3_R-V5JB8u-EFeApTQ2mFVDOtB59=aS=w@mail.gmail.com>
	<CAEze2Wjzoo+DXcvYwtbPiKCK5sqjT5WvWXftS9LTiLkzOFbyCw@mail.gmail.com>
	<CAApHDvpwG5w1YeHLPD1M-nZ=k1omFUCAmLGNMSctHFR_f8-NYw@mail.gmail.com>

Hello David,

03.07.2024 13:41, David Rowley wrote:
>
>> Lastly, I think this would benefit from a test in
>> regress/sql/explain.sql, as the test changes that were included
>> removed the only occurrance of a Materialize node from the regression
>> tests' EXPLAIN outputs.
> I've modified the tests where the previous patch disabled
> enable_material to enable it again and mask out the possibly unstable
> part. Do you think that's an ok level of testing?

Please look at a segfault crash introduced with 1eff8279d:
CREATE TABLE t1(i int);
CREATE TABLE t2(i int) PARTITION BY RANGE (i);
CREATE TABLE t2p PARTITION OF t2 FOR VALUES FROM (1) TO (2);

EXPLAIN ANALYZE SELECT * FROM t1 JOIN t2 ON t1.i > t2.i;

Leads to:
Core was generated by `postgres: law regression [local] EXPLAIN                                      '.
Program terminated with signal SIGSEGV, Segmentation fault.

#0  0x000055c36dbac2f7 in tuplestore_storage_type_name (state=0x0) at tuplestore.c:1476
1476            if (state->status == TSS_INMEM)

Best regards,
Alexander





view thread (16+ messages)  latest in thread

Message-ID: <fe7fc8fb-86e5-ecb0-3cb2-dd2c9a6c482f@gmail.com>
Permalink:  ../fe7fc8fb-86e5-ecb0-3cb2-dd2c9a6c482f@gmail.com/
Also on:    postgresql.org/message-id/fe7fc8fb-86e5-ecb0-3cb2-dd2c9a6c482f@gmail.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: exclusion@gmail.com, dgrowleyml@gmail.com, boekewurm+postgres@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Use generation memory context for tuplestore.c
  In-Reply-To: <fe7fc8fb-86e5-ecb0-3cb2-dd2c9a6c482f@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox