pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: David Steele <david@pgmasters.net>
Cc: Andres Freund <andres@anarazel.de>
Cc: Noah Misch <noah@leadboat.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Suraj Kharage <suraj.kharage@enterprisedb.com>
Cc: tushar <tushar.ahuja@enterprisedb.com>
Cc: Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>
Cc: Rushabh Lathia <rushabh.lathia@gmail.com>
Cc: Tels <nospam-pg-abuse@bloodgate.com>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Cc: Jeevan Chalke <jeevan.chalke@enterprisedb.com>
Cc: vignesh C <vignesh21@gmail.com>
Subject: Re: backup manifests
Date: Thu, 23 Apr 2020 01:21:40 +0900
Message-ID: <ff4710f7-2331-4f6b-012e-d76da3275e91@oss.nttdata.com> (raw )
In-Reply-To: <3286f87b-d396-1c35-1f49-463af10de637@oss.nttdata.com >
References: <20200330185944.42bxysvem6b757ew@alap3.anarazel.de >
<CA+Tgmob+xDcvEUTznkvianyJzKK8nUM6bWfkrnZQkL-XEa3NEA@mail.gmail.com >
<20200402172318.3kvfrrewxmemzpia@alap3.anarazel.de >
<CA+Tgmoa2_8Ti9xez8wEH7Z_RJQv=cwPC=MeqUXcdVW=5-uMCig@mail.gmail.com >
<20200402182346.6iffoadxu2hsbi2s@alap3.anarazel.de >
<CA+TgmoboTL8cBt_P5Jx6RjL=Hk3Y8PbpGsh9KcH_MZuswVqdYA@mail.gmail.com >
<CA+TgmoaGoQM74CMJhqg3_M7osWgkT2xSxo9aGVu9E4Nt+8Z4sg@mail.gmail.com >
<20200402194750.7ze74b4t6b6o4cui@alap3.anarazel.de >
<e3101c23-26b7-6fa2-14a8-af24c96602b5@pgmasters.net >
<CA+TgmoaKhxPr0FWsEiZoXpMER44pMJ28L-Z7wcRrOKoGFwjiUQ@mail.gmail.com >
<78f76a3d-1a28-a97d-0394-5c96985dd1c0@oss.nttdata.com >
<CA+TgmobHMS6z2A5Sa+C7WD86bDjKOt6fbmueoWyoQa3kEVgbtA@mail.gmail.com >
<777d236e-f46c-8099-bb5e-a6e4efc43999@oss.nttdata.com >
<01e3ed3a-8729-5aaa-ca84-e60e3ca59db8@oss.nttdata.com >
<CA+Tgmoaw1xTsc+psHFEh2kstdivNW2wOiNpCk18OK=nOhmY-0g@mail.gmail.com >
<3286f87b-d396-1c35-1f49-463af10de637@oss.nttdata.com >
On 2020/04/15 11:18, Fujii Masao wrote:
>
>
> On 2020/04/14 0:15, Robert Haas wrote:
>> On Sun, Apr 12, 2020 at 10:09 PM Fujii Masao
>> <masao.fujii@oss.nttdata.com> wrote:
>>> I found other minor issues.
>>
>> I think these are all correct fixes. Thanks for the post-commit
>> review, and sorry for this mistakes.
>
> Thanks for the review, Michael and Robert. Pushed the patches!
I found three minor issues in pg_verifybackup.
+ {"print-parse-wal", no_argument, NULL, 'p'},
This is unused option, so this line should be removed.
+ printf(_(" -m, --manifest=PATH use specified path for manifest\n"));
Typo: --manifest should be --manifest-path
pg_verifybackup accepts --quiet option, but its usage() doesn't
print any message for --quiet option.
Attached is the patch that fixes those issues.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
diff --git a/src/bin/pg_verifybackup/pg_verifybackup.c b/src/bin/pg_verifybackup/pg_verifybackup.c
index 9c0a8c5550..340765526d 100644
--- a/src/bin/pg_verifybackup/pg_verifybackup.c
+++ b/src/bin/pg_verifybackup/pg_verifybackup.c
@@ -162,7 +162,6 @@ main(int argc, char **argv)
{"ignore", required_argument, NULL, 'i'},
{"manifest-path", required_argument, NULL, 'm'},
{"no-parse-wal", no_argument, NULL, 'n'},
- {"print-parse-wal", no_argument, NULL, 'p'},
{"quiet", no_argument, NULL, 'q'},
{"skip-checksums", no_argument, NULL, 's'},
{"wal-directory", required_argument, NULL, 'w'},
@@ -894,8 +893,9 @@ usage(void)
printf(_("Options:\n"));
printf(_(" -e, --exit-on-error exit immediately on error\n"));
printf(_(" -i, --ignore=RELATIVE_PATH ignore indicated path\n"));
- printf(_(" -m, --manifest=PATH use specified path for manifest\n"));
+ printf(_(" -m, --manifest-path=PATH use specified path for manifest\n"));
printf(_(" -n, --no-parse-wal do not try to parse WAL files\n"));
+ printf(_(" -q, --quiet do not print any output, except for errors\n"));
printf(_(" -s, --skip-checksums skip checksum verification\n"));
printf(_(" -w, --wal-directory=PATH use specified path for WAL files\n"));
printf(_(" -V, --version output version information, then exit\n"));
Attachments:
[text/plain] pg_verifybackup_options_v1.patch (1.3K, ../ff4710f7-2331-4f6b-012e-d76da3275e91@oss.nttdata.com/2-pg_verifybackup_options_v1.patch)
download | inline diff:
diff --git a/src/bin/pg_verifybackup/pg_verifybackup.c b/src/bin/pg_verifybackup/pg_verifybackup.c
index 9c0a8c5550..340765526d 100644
--- a/src/bin/pg_verifybackup/pg_verifybackup.c
+++ b/src/bin/pg_verifybackup/pg_verifybackup.c
@@ -162,7 +162,6 @@ main(int argc, char **argv)
{"ignore", required_argument, NULL, 'i'},
{"manifest-path", required_argument, NULL, 'm'},
{"no-parse-wal", no_argument, NULL, 'n'},
- {"print-parse-wal", no_argument, NULL, 'p'},
{"quiet", no_argument, NULL, 'q'},
{"skip-checksums", no_argument, NULL, 's'},
{"wal-directory", required_argument, NULL, 'w'},
@@ -894,8 +893,9 @@ usage(void)
printf(_("Options:\n"));
printf(_(" -e, --exit-on-error exit immediately on error\n"));
printf(_(" -i, --ignore=RELATIVE_PATH ignore indicated path\n"));
- printf(_(" -m, --manifest=PATH use specified path for manifest\n"));
+ printf(_(" -m, --manifest-path=PATH use specified path for manifest\n"));
printf(_(" -n, --no-parse-wal do not try to parse WAL files\n"));
+ printf(_(" -q, --quiet do not print any output, except for errors\n"));
printf(_(" -s, --skip-checksums skip checksum verification\n"));
printf(_(" -w, --wal-directory=PATH use specified path for WAL files\n"));
printf(_(" -V, --version output version information, then exit\n"));
view thread (243+ messages) latest in thread
Message-ID: <ff4710f7-2331-4f6b-012e-d76da3275e91@oss.nttdata.com>
Permalink: ../ff4710f7-2331-4f6b-012e-d76da3275e91@oss.nttdata.com/
Also on: postgresql.org/message-id/ff4710f7-2331-4f6b-012e-d76da3275e91@oss.nttdata.com
copy link · copy postgr.es · copy git am
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: masao.fujii@oss.nttdata.com, robertmhaas@gmail.com, david@pgmasters.net, andres@anarazel.de, noah@leadboat.com, sfrost@snowman.net, amit.kapila16@gmail.com, suraj.kharage@enterprisedb.com, tushar.ahuja@enterprisedb.com, rajkumar.raghuwanshi@enterprisedb.com, rushabh.lathia@gmail.com, nospam-pg-abuse@bloodgate.com, andrew.dunstan@2ndquadrant.com, jeevan.chalke@enterprisedb.com, vignesh21@gmail.com
Subject: Re: backup manifests
In-Reply-To: <ff4710f7-2331-4f6b-012e-d76da3275e91@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox