agora inbox for pgsql-hackers@postgresql.org  
help / color / mirror / Atom feed
From: zengman <zengman@halodbtech.com>
To: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Subject: Copy-paste error in hash_record_extended() ― args[1].isnull not set
Date: Sat, 30 May 2026 12:38:02 +0800
Message-ID: <tencent_7818173C01E01836109848C3@qq.com> (raw)

Hi all,

I noticed that in src/backend/utils/adt/rowtypes.c, function hash_record_extended(), there is a copy-paste error:

```c
diff --git a/src/backend/utils/adt/rowtypes.c b/src/backend/utils/adt/rowtypes.c
index e4eb7111ee7..d6126d431d9 100644
--- a/src/backend/utils/adt/rowtypes.c
+++ b/src/backend/utils/adt/rowtypes.c
@@ -2030,7 +2030,7 @@ hash_record_extended(PG_FUNCTION_ARGS)
                        locfcinfo->args[0].value = values[i];
                        locfcinfo->args[0].isnull = false;
                        locfcinfo->args[1].value = Int64GetDatum(seed);
-                       locfcinfo->args[0].isnull = false;
+                       locfcinfo->args[1].isnull = false;
                        element_hash = DatumGetUInt64(FunctionCallInvoke(locfcinfo));
 
                        /* We don't expect hash support functions to return null */
```
I think it's worth fixing.

Regards,
Man Zeng

Message-ID: <tencent_7818173C01E01836109848C3@qq.com>
Permalink:  ../tencent_7818173C01E01836109848C3@qq.com/
Also on:    postgresql.org/message-id/tencent_7818173C01E01836109848C3@qq.com

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: zengman@halodbtech.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: =?gb18030?B?Q29weS1wYXN0ZSBlcnJvciBpbiBoYXNoX3JlY29y?= =?gb18030?B?ZF9leHRlbmRlZCgpIKGqIGFyZ3NbMV0uaXNudWxs?= =?gb18030?B?IG5vdCBzZXQ=?=
  In-Reply-To: <tencent_7818173C01E01836109848C3@qq.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox