pg.ddx.io  aws/aws-advanced-jdbc-wrapper GitHub issues and pull requests  
help / color / mirror / Atom feed
[aws/aws-advanced-jdbc-wrapper] PR #2257: feat: evict expired and aborted connections from internal pools
11+ messages / 2 participants
[nested] [flat]

* [aws/aws-advanced-jdbc-wrapper] PR #2257: feat: evict expired and aborted connections from internal pools
@ 2026-11-18 18:19  "sergiyvamz (@sergiyvamz)" <noreply+sergiyvamz@github.com>
  0 siblings, 0 replies; 11+ messages in thread

From: sergiyvamz (@sergiyvamz) @ 2026-11-18 18:19 UTC (permalink / raw)
  To: aws/aws-advanced-jdbc-wrapper <noreply+aws-aws-advanced-jdbc-wrapper@github.com>

### Summary

Evict expired and aborted connections from the internal connection pool.

### Description

With `HikariPooledConnectionProvider`, closing a connection only returns the physical connection to the pool. When the connectionLifetime plugin closes an expired connection, the same physical connection is handed out again with a fresh timer. EFM-aborted connections can also be handed out again until Hikari notices they are dead.

- New `ConnectionProvider#evictConnection(Connection)` (default no-op) and `PluginService#evictConnection(Connection)`.
- `HikariPooledConnectionProvider` remembers which pool issued each connection and calls `HikariDataSource#evictConnection` on it.
- The connectionLifetime plugin evicts the expired connection once it is closed. Connections another plugin preserved are left alone.
- EFM v1, v2 and v3 evict a connection after aborting it.
- `C3P0PooledConnectionProvider` keeps the no-op: c3p0 has no public API to evict a single connection.

### Additional Reviewers

### By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.


^ permalink  raw  [nested|flat] 11+ messages in thread

* Re: [aws/aws-advanced-jdbc-wrapper] PR #2257: feat: evict expired and aborted connections from internal pools
@ 2026-11-18 18:21  "sergiyvamz (@sergiyvamz)" <noreply+sergiyvamz@github.com>
  9 siblings, 0 replies; 11+ messages in thread

From: sergiyvamz (@sergiyvamz) @ 2026-11-18 18:21 UTC (permalink / raw)
  To: aws/aws-advanced-jdbc-wrapper <noreply+aws-aws-advanced-jdbc-wrapper@github.com>

@sergiyvamz applied label "wip".

^ permalink  raw  [nested|flat] 11+ messages in thread

* Re: [aws/aws-advanced-jdbc-wrapper] PR #2257: feat: evict expired and aborted connections from internal pools
@ 2026-11-18 18:21  "sergiyvamz (@sergiyvamz)" <noreply+sergiyvamz@github.com>
  9 siblings, 0 replies; 11+ messages in thread

From: sergiyvamz (@sergiyvamz) @ 2026-11-18 18:21 UTC (permalink / raw)
  To: aws/aws-advanced-jdbc-wrapper <noreply+aws-aws-advanced-jdbc-wrapper@github.com>

@sergiyvamz renamed this.

^ permalink  raw  [nested|flat] 11+ messages in thread

* Re: [aws/aws-advanced-jdbc-wrapper] PR #2257: feat: evict expired and aborted connections from internal pools
@ 2026-11-18 18:41  "sergiyvamz (@sergiyvamz)" <noreply+sergiyvamz@github.com>
  9 siblings, 0 replies; 11+ messages in thread

From: sergiyvamz (@sergiyvamz) @ 2026-11-18 18:41 UTC (permalink / raw)
  To: aws/aws-advanced-jdbc-wrapper <noreply+aws-aws-advanced-jdbc-wrapper@github.com>

@sergiyvamz renamed this.

^ permalink  raw  [nested|flat] 11+ messages in thread

* Re: [aws/aws-advanced-jdbc-wrapper] PR #2257: feat: evict expired and aborted connections from internal pools
@ 2026-11-18 18:41  "sergiyvamz (@sergiyvamz)" <noreply+sergiyvamz@github.com>
  9 siblings, 0 replies; 11+ messages in thread

From: sergiyvamz (@sergiyvamz) @ 2026-11-18 18:41 UTC (permalink / raw)
  To: aws/aws-advanced-jdbc-wrapper <noreply+aws-aws-advanced-jdbc-wrapper@github.com>

@sergiyvamz removed label "wip".

^ permalink  raw  [nested|flat] 11+ messages in thread

* Re: [aws/aws-advanced-jdbc-wrapper] PR #2257: feat: evict expired and aborted connections from internal pools
@ 2026-11-18 21:45  "sophia-bq (@sophia-bq)" <noreply+sophia-bq@github.com>
  9 siblings, 0 replies; 11+ messages in thread

From: sophia-bq (@sophia-bq) @ 2026-11-18 21:45 UTC (permalink / raw)
  To: aws/aws-advanced-jdbc-wrapper <noreply+aws-aws-advanced-jdbc-wrapper@github.com>

(on docs/using-the-jdbc-driver/using-plugins/UsingTheConnectionLifetimePlugin.md:80)

Do we need a version note in the docs that mention this added eviction? 

^ permalink  raw  [nested|flat] 11+ messages in thread

* Re: [aws/aws-advanced-jdbc-wrapper] PR #2257 (approved): feat: evict expired and aborted connections from internal pools
@ 2026-11-18 21:45  "sophia-bq (@sophia-bq)" <noreply+sophia-bq@github.com>
  9 siblings, 0 replies; 11+ messages in thread

From: sophia-bq (@sophia-bq) @ 2026-11-18 21:45 UTC (permalink / raw)
  To: aws/aws-advanced-jdbc-wrapper <noreply+aws-aws-advanced-jdbc-wrapper@github.com>



^ permalink  raw  [nested|flat] 11+ messages in thread

* Re: [aws/aws-advanced-jdbc-wrapper] PR #2257: feat: evict expired and aborted connections from internal pools
@ 2026-11-18 21:46  "sophia-bq (@sophia-bq)" <noreply+sophia-bq@github.com>
  9 siblings, 0 replies; 11+ messages in thread

From: sophia-bq (@sophia-bq) @ 2026-11-18 21:46 UTC (permalink / raw)
  To: aws/aws-advanced-jdbc-wrapper <noreply+aws-aws-advanced-jdbc-wrapper@github.com>

(on docs/using-the-jdbc-driver/using-plugins/UsingTheConnectionLifetimePlugin.md:80)

Also just a question: is there a followup of this work planned for efm3? 

^ permalink  raw  [nested|flat] 11+ messages in thread

* Re: [aws/aws-advanced-jdbc-wrapper] PR #2257: feat: evict expired and aborted connections from internal pools
@ 2026-11-18 22:13  "sergiyvamz (@sergiyvamz)" <noreply+sergiyvamz@github.com>
  9 siblings, 0 replies; 11+ messages in thread

From: sergiyvamz (@sergiyvamz) @ 2026-11-18 22:13 UTC (permalink / raw)
  To: aws/aws-advanced-jdbc-wrapper <noreply+aws-aws-advanced-jdbc-wrapper@github.com>

(on docs/using-the-jdbc-driver/using-plugins/UsingTheConnectionLifetimePlugin.md:80)

connectionLifetime plugin is not yet released. They both, the plugin and this extra fix/improvement, will be released together so I don't think we need explicitly specify a version. connectLifetime plugin has its version availability.

efm3 should be adopted as well.

^ permalink  raw  [nested|flat] 11+ messages in thread

* Re: [aws/aws-advanced-jdbc-wrapper] PR #2257: feat: evict expired and aborted connections from internal pools
@ 2026-11-19 00:51  "sergiyvamz (@sergiyvamz)" <noreply+sergiyvamz@github.com>
  9 siblings, 0 replies; 11+ messages in thread

From: sergiyvamz (@sergiyvamz) @ 2026-11-19 00:51 UTC (permalink / raw)
  To: aws/aws-advanced-jdbc-wrapper <noreply+aws-aws-advanced-jdbc-wrapper@github.com>

@sergiyvamz merged this (commit 9ca9a4832175).

^ permalink  raw  [nested|flat] 11+ messages in thread

* Re: [aws/aws-advanced-jdbc-wrapper] PR #2257: feat: evict expired and aborted connections from internal pools
@ 2026-11-19 00:51  "sergiyvamz (@sergiyvamz)" <noreply+sergiyvamz@github.com>
  9 siblings, 0 replies; 11+ messages in thread

From: sergiyvamz (@sergiyvamz) @ 2026-11-19 00:51 UTC (permalink / raw)
  To: aws/aws-advanced-jdbc-wrapper <noreply+aws-aws-advanced-jdbc-wrapper@github.com>

@sergiyvamz closed this.

^ permalink  raw  [nested|flat] 11+ messages in thread


end of thread, other threads:[~2026-11-19 00:51 UTC | newest]

Thread overview: 11+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-11-18 18:19 [aws/aws-advanced-jdbc-wrapper] PR #2257: feat: evict expired and aborted connections from internal pools "sergiyvamz (@sergiyvamz)" <noreply+sergiyvamz@github.com>
2026-11-18 18:21 ` "sergiyvamz (@sergiyvamz)" <noreply+sergiyvamz@github.com>
2026-11-18 18:21 ` "sergiyvamz (@sergiyvamz)" <noreply+sergiyvamz@github.com>
2026-11-18 18:41 ` "sergiyvamz (@sergiyvamz)" <noreply+sergiyvamz@github.com>
2026-11-18 18:41 ` "sergiyvamz (@sergiyvamz)" <noreply+sergiyvamz@github.com>
2026-11-18 21:45 ` "sophia-bq (@sophia-bq)" <noreply+sophia-bq@github.com>
2026-11-18 21:45 ` Re: [aws/aws-advanced-jdbc-wrapper] PR #2257 (approved): feat: evict expired and aborted connections from internal pools "sophia-bq (@sophia-bq)" <noreply+sophia-bq@github.com>
2026-11-18 21:46 ` "sophia-bq (@sophia-bq)" <noreply+sophia-bq@github.com>
2026-11-18 22:13 ` "sergiyvamz (@sergiyvamz)" <noreply+sergiyvamz@github.com>
2026-11-19 00:51 ` "sergiyvamz (@sergiyvamz)" <noreply+sergiyvamz@github.com>
2026-11-19 00:51 ` "sergiyvamz (@sergiyvamz)" <noreply+sergiyvamz@github.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox