From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
cc: buildfarm-members@postgresql.org
Subject: Re: Release 13 of the PostgreSQL BuildFarm client
In-reply-to: <0234f0ff-221a-e6a4-39c7-137ed4edb74e@dunslane.net>
References: <18c03f7e-3ab9-f7b4-9248-feb85b0f03ed@dunslane.net>
 <1660080.1627945870@sss.pgh.pa.us>
 <5462d8bd-b8aa-3c38-b078-4bf5e94f8eba@dunslane.net>
 <0234f0ff-221a-e6a4-39c7-137ed4edb74e@dunslane.net>
Comments: In-reply-to Andrew Dunstan <andrew@dunslane.net>
	message dated "Tue, 03 Aug 2021 15:14:41 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1774331.1628020800.1@sss.pgh.pa.us>
Date: Tue, 03 Aug 2021 16:00:00 -0400
Message-ID: <1774332.1628020800@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1774332.1628020800%40sss.pgh.pa.us>
Precedence: bulk

Andrew Dunstan <andrew@dunslane.net> writes:
> I'm planning on issuing a 12.1 release fairly soon with this patch, but
> as I developed it fairly quickly and through the fog of some painkillers
> I'd appreciate more eyes on it first :-)

I tested this on gaur, and it seems to work --- at least, it gets
through the git checkout step now.  (It'll be a few hours before
the run finishes.)

One nit is that personally I could do without this:

+			my $gversion = `git --version`;
+			chomp $gversion;
+			print "$gversion too old to for automatic default branch update\n";

Aside from the message typo, that'll produce useless every-run chatter in
affected owners' cron logs.  I'd probably soon set skip_git_default_check
to silence it, at which point it might as well not be there.

Thanks for fixing it, though.  I wasted a couple of hours last night
trying to build current git on prairiedog and gaur, with no luck so far.
I think just blowing away their git repos when the master-branch rename
happens will be a much more appropriate amount of effort.

			regards, tom lane