Date: Sat, 2 Oct 2021 09:19:26 -0700
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: buildfarm-members@lists.postgresql.org
Subject: Re: Animals with old SSL may find no build required
Message-ID: <20211002161926.GB232426@rfd.leadboat.com>
References: <20211002070010.GB205991@rfd.leadboat.com>
 <3689082.1633185948@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3689082.1633185948@sss.pgh.pa.us>
User-Agent: Mutt/1.5.24 (2015-08-30)
Archived-At: 
 <https://www.postgresql.org/message-id/20211002161926.GB232426%40rfd.leadboat.com>
Precedence: bulk

On Sat, Oct 02, 2021 at 10:45:48AM -0400, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> > build-farm.conf.sample defaults to git_ignore_mirror_failure=>1.  With that
> > setting, if a buildfarm member SSL setup breaks, the member will appear to be
> > functioning, but it will find no changes to test:
> 
> > Sat Oct  2 04:35:22 2021: buildfarm run for frogfish:REL9_6_STABLE starting
> > git version 1.7.10.4 too old for automatic default branch update
> > frogfish:REL9_6_STABLE [04:35:23] checking out source ...
> > frogfish:REL9_6_STABLE [04:35:58] checking if build run needed ...
> > frogfish:REL9_6_STABLE [04:35:58] No build required: last status = Fri Sep 24 23:15:14 2021 GMT, current snapshot = Sat Sep 25 14:53:55 2021 GMT, changed files = 0
> 
> FWIW, if you are using run_branches.pl, the failure will happen earlier.
> What I am getting on prairiedog is
> 
> error getting branches of interest: 500 Can't connect to buildfarm.postgresql.org:443 (certificate verify failed) at ./run_branches.pl line 201.

That will indeed happen first if your config reaches pgstatus.pl via an
https:// URL (the default) and meanwhile Perl and git use the same SSL library
and certificate store.  frogfish does use run_branches.pl, but it doesn't meet
those other conditions.