From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: Noah Misch <noah@leadboat.com>, buildfarm-members@lists.postgresql.org
Subject: Re: Possible infinite loop on buildfarm animals
In-reply-to: <202403171938.34kpjnr7lwb7@alvherre.pgsql>
References: <202403171938.34kpjnr7lwb7@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
	message dated "Sun, 17 Mar 2024 20:38:46 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3400215.1710704639.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sun, 17 Mar 2024 15:43:59 -0400
Message-ID: <3400216.1710704639@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3400216.1710704639%40sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2024-Mar-17, Noah Misch wrote:
>> Other than CLOBBER_CACHE animals, the server rejects results older than=
 24h:
>> https://github.com/PGBuildFarm/server-code/blob/8572ac7/cgi-bin/pgstatu=
s.pl#L273

>> The same 24h should probably be the default wait_timeout.  One might us=
e a
>> longer timeout if wanting to attach a debugger to a process of a stuck =
run.
>> If one just wants an intervention-free buildfarm animal, 24h is good.

> Maybe that should be the default value embedded in the buildfarm client
> script, which can be overridden for specific purposes such as
> CLOBBER_CACHE animals?

We don't normally hard-wire such choices in the script, but it could
be plausible to change build-farm.conf.sample, perhaps like:

	# max time in seconds allowed for a single branch run
	# undef/0 means unlimited
-	wait_timeout =3D> undef,
+	wait_timeout =3D> 24 * 60 * 60,

			regards, tom lane