From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Subject: Re: many animals are running old clients
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: =?UTF-8?Q?Mikael_Kjellstr=c3=b6m?= <mikael.kjellstrom@mksoft.nu>,
 buildfarm-members@postgresql.org
References: <144264ec-fd45-80eb-7642-109f920286b9@2ndQuadrant.com>
 <aafee74e-b69a-fb09-d9f3-261e2eb58f92@mksoft.nu>
 <fcde264c-7d8e-af68-a3c7-a1297216b31b@2ndQuadrant.com>
 <17634.1534605123@sss.pgh.pa.us>
Message-ID: <3edc3430-4539-9888-6979-ed377908ec24@2ndQuadrant.com>
Date: Sat, 18 Aug 2018 12:03:49 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <17634.1534605123@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-MW
Precedence: bulk


On 08/18/2018 11:12 AM, Tom Lane wrote:
> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>> On 08/18/2018 06:48 AM, Mikael Kjellström wrote:
>>> Every time I upgrade I need to go through all the .pl-files and change
>>> the path to where perl is located as different os/distros has perl at
>>> different paths and also it's not even consistent within the shipped
>>> files.
>> Would it help if I added a script to set the perl locations?
> Is it really necessary to touch the shebang lines at all?
> I thought if you invoked the top script with
> 	perl-of-choice /path/to/run_build.pl ... args ...
> then you'd be good.  If that's not so, maybe we could make it work?


Sadly it's not quite that simple. run_branches has this code:

    sub run_branch
    {
         my $branch = shift;
         my @args = ($run_build,
    PGBuild::Options::standard_option_list(), $branch);

         # Explicitly use perl from the path (and not this perl, so
    don't use $^X)
         # This script needs to run on Cygwin with non-cygwin perl if
    it's running
         # in tandem with AS/MinGW perl, since Cygwin perl doesn't honor
    locks
         # the samne way, and the global lock fails. But the build
    script needs
         # to run with the native perl, even on Cygwin, which it picks
    up from
         # the path. (Head exploding yet?).
         system("perl", @args);
         return;
    }

I could probably reasonably limit that so that everywhere but Cygwin we 
use the called perl. Windows is really the only place where we have to 
wrestle with multiple perls.


>
>>> I also go through the config-file line by line to see if anything is
>>> changed or added.
> Yeah, this bit is the most time-consuming for me.  Not sure what's to
> be done about it.
>
> 			


It's in my list of things to consider. One of the things on the roadmap 
in my head is a possible switch to a YAML config file.

Perhaps I should publish in the release notes a diff of the sample 
config file against the previous release.

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services