Subject: Re: Release 13 of the PostgreSQL BuildFarm client
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: buildfarm-members@postgresql.org
References: <18c03f7e-3ab9-f7b4-9248-feb85b0f03ed@dunslane.net>
 <1660080.1627945870@sss.pgh.pa.us>
 <5462d8bd-b8aa-3c38-b078-4bf5e94f8eba@dunslane.net>
 <0234f0ff-221a-e6a4-39c7-137ed4edb74e@dunslane.net>
 <1774332.1628020800@sss.pgh.pa.us>
From: Andrew Dunstan <andrew@dunslane.net>
Message-ID: <7ad25a4e-9465-64c7-2429-4db87bde9b75@dunslane.net>
Date: Tue, 3 Aug 2021 19:18:31 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <1774332.1628020800@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Archived-At: 
 <https://www.postgresql.org/message-id/7ad25a4e-9465-64c7-2429-4db87bde9b75%40dunslane.net>
Precedence: bulk


On 8/3/21 4:00 PM, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> I'm planning on issuing a 12.1 release fairly soon with this patch, but
>> as I developed it fairly quickly and through the fog of some painkillers
>> I'd appreciate more eyes on it first :-)
> I tested this on gaur, and it seems to work --- at least, it gets
> through the git checkout step now.  (It'll be a few hours before
> the run finishes.)
>
> One nit is that personally I could do without this:
>
> +			my $gversion = `git --version`;
> +			chomp $gversion;
> +			print "$gversion too old to for automatic default branch update\n";
>
> Aside from the message typo, that'll produce useless every-run chatter in
> affected owners' cron logs.  I'd probably soon set skip_git_default_check
> to silence it, at which point it might as well not be there.


I'll fix the typo and make it only print the warning in verbose mode, I
hope that will suit. On those machines where you can't update git you
should just set skip_git_default_check.


>
> Thanks for fixing it, though.  I wasted a couple of hours last night
> trying to build current git on prairiedog and gaur, with no luck so far.
> I think just blowing away their git repos when the master-branch rename
> happens will be a much more appropriate amount of effort.
>
> 			


Indeed. I've been down that path before, with similar success.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com