MIME-Version: 1.0
In-Reply-To: <21879.1520375102@sss.pgh.pa.us>
References: <21879.1520375102@sss.pgh.pa.us>
From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Date: Wed, 7 Mar 2018 11:10:32 +1030
Message-ID: 
 <CAA8=A78xhP4yo-Tcg0MUTpwVsQcm1Yqayfc-cSL+9Ng+WdT13w@mail.gmail.com>
Subject: Re: We have no Windows critters contributing typedef lists
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: buildfarm-members@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Mar 7, 2018 at 8:55 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> A pgindent run I just did showed me that we no longer have entries in
> the buildfarm's typedefs list for any typedefs that are used only in
> EXEC_BACKEND builds --- and, I suppose, none for Windows-only code
> either.  I suppose that one of the recently deceased Windows animals
> was the only one contributing those.  We need to improve this situation
> before it's time to run pgindent again.
>
> I'm not sure what the infrastructure requirements are for extracting
> typedefs from Windows builds.
>


Nothing special I think. I have just enabled it for jacana and also
for bowerbird which I am reviving. Basically it's just a matter of
adding
    find_typedefs => {},
to the optional_steps part of the config file. That will make it get
the typedefs for every build of every branch.

You should see some results in a few hours.

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services