Subject: Re: [buildfarm-members] BuildFarm client release 4.19
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>,
 buildfarm-members@postgresql.org
References: <3eef634f-4d0a-8f27-e4e9-67080b44f637@2ndQuadrant.com>
 <edb45e2b-b7b7-d817-fde8-e816f602025e@mksoft.nu>
 <f8c68fc8-7c95-c6d2-d759-9389982eda2f@2ndQuadrant.com>
 <1b1da59b-3280-7934-6a59-c57d8c86c84c@mksoft.nu>
 <ef6f298f-98de-aa0c-c898-8dbb985fb0af@mksoft.nu>
 <2cdca268-76ef-994f-5b87-ca37164fadf4@2ndQuadrant.com>
 <dcabab00-8ecd-f0c5-d055-0f1f7598729a@mksoft.nu>
 <8763b0f6-12ac-9a87-df2b-6dd4e5d27c98@2ndQuadrant.com>
From: =?UTF-8?Q?Mikael_Kjellstr=c3=b6m?= <mikael.kjellstrom@mksoft.nu>
Message-ID: <d47618ea-6058-fa7f-d846-7dd505623f84@mksoft.nu>
Date: Mon, 1 May 2017 21:19:44 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <8763b0f6-12ac-9a87-df2b-6dd4e5d27c98@2ndQuadrant.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


On 2017-05-01 21:10, Andrew Dunstan wrote:
> Not sure I understand what "rerun a branch" from scratch means. If you
> zap the branch directory you lose all its state. That's generally a bad
> thing.

I mean like the first time when you set up the buildfarm client / 
branch.  And it's not something I recomend doing all the time but some 
times when the buildfarm client doesn't clean up after it self and there 
are a lot of crap left it's "easier" to just zap everything and start 
over to get it running again.


> Anyway, this patch should fix it for all uses. It creates the directory
> if it doesn't exist.
>
>     diff --git a/PGBuild/Utils.pm b/PGBuild/Utils.pm
>     index 91c1362..175eaa7 100644
>     --- a/PGBuild/Utils.pm
>     +++ b/PGBuild/Utils.pm
>     @@ -14,6 +14,8 @@ See accompanying License file for license details
>      use strict;
>      use warnings;
>
>     +use File::Path;
>     +
>      use Exporter   ();
>      our (@ISA, @EXPORT, @EXPORT_OK, %EXPORT_TAGS);
>
>     @@ -30,8 +32,9 @@ use vars qw($VERSION); $VERSION = 'REL_4.19';
>      sub run_log
>      {
>          my $command = shift;
>     -    my $file=
>     -
>     "$main::branch_root/$main::st_prefix$main::logdirname/lastcomand.log";
>     +   my $filedir =
>     "$main::branch_root/$main::st_prefix$main::logdirname";
>     +   mkpath($filedir);
>     +   my $file= "$filedir/lastcomand.log";
>          unlink $file;
>          system("$command > $file 2>&1");
>          my @loglines;

Ok.

Thanks.  Will try it out.

/Mikael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers