From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Subject: Re: many animals are running old clients
To: Noah Misch <noah@leadboat.com>
Cc: buildfarm-members@postgresql.org
References: <144264ec-fd45-80eb-7642-109f920286b9@2ndQuadrant.com>
 <20180818070030.GA3795674@rfd.leadboat.com>
 <d6a8bb37-eb72-b663-7fa7-6fb8aaa5cb25@2ndQuadrant.com>
 <20180818162211.GC3795674@rfd.leadboat.com>
 <966eeb24-3f37-29da-dee2-91522bbe1850@2ndQuadrant.com>
 <20180821032440.GA217087@rfd.leadboat.com>
Message-ID: <db4e577f-8538-30b8-3734-fa5538be41e8@2ndQuadrant.com>
Date: Tue, 21 Aug 2018 06:58:01 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20180821032440.GA217087@rfd.leadboat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-MW
Precedence: bulk


On 08/20/2018 11:24 PM, Noah Misch wrote:
> On Sun, Aug 19, 2018 at 03:04:58PM -0400, Andrew Dunstan wrote:
>> On 08/18/2018 12:22 PM, Noah Misch wrote (offlist):
>>> On Sat, Aug 18, 2018 at 08:17:17AM -0400, Andrew Dunstan wrote:
>>>> Is there anything I can do to make upgrade easier?
>>> The show_log.pl web page could highlight a particular run's config change,
>>> including version number changes, when there is such a change compared to the
>>> previous run.  If it's clear enough that folks are unlikely to confuse an
>>> upgrade-induced failure with a PG-commit-induced failure, I could stop checking
>>> for post-upgrade buildfarm failures.
>> What I've done is add this to the database in a way that makes it easily
>> accessible to the web app, and added that info to the history page.
> I think that wastes prime screen real estate.  If show_history.pl is going to
> spend that space on something, I would choose commit hash.  But I liked it
> better with nothing there.
>
> The concept I had in mind was a "Config changed since last success" block
> adjacent to the "Files changed since last success" block in show_log.pl.  It
> might look like this:
>
> - 'config_env' => { 'CC' => 'gcc' },
> + 'config_env' => { 'CC' => 'gcc -mips32r2' },
> - 'script_version' => 'REL_7',
> + 'script_version' => 'REL_8',
>
> Script version is a minor aspect, worth little by itself.  If you diff the
> entire config block, though, that amounts to a meaningful feature.


It's easy to revert the display change, and there is utility in having 
the script version easily available in the database without having to 
extract it in each query.

Getting the config summary from the previous build is possibly a bit 
less simple.

I'll take a look when I get a bit more time.

cheers

andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services