pg.ddx.io  reorg/pg_repack GitHub issues and pull requests  
help / color / mirror / Atom feed
[reorg/pg_repack] PR #490: Ignore pg_attver in repack-check attoptions output
4+ messages / 2 participants
[nested] [flat]

* [reorg/pg_repack] PR #490: Ignore pg_attver in repack-check attoptions output
@ 2026-11-11 12:59  "dutow (@dutow)" <noreply+dutow@github.com>
  0 siblings, 0 replies; 4+ messages in thread

From: dutow (@dutow) @ 2026-11-11 12:59 UTC (permalink / raw)
  To: reorg/pg_repack <noreply+reorg-pg_repack@github.com>

The November 2026 minor releases (14 to 19) store a per-column version in pg_attribute.attoptions as pg_attver=<LSN>, as part of the fix for unsafe deforming of composite datums. The value is server-internal and differs on every run, so filter it out of the column options check.

inline patch 1: regress/expected/repack-check.out, regress/expected/repack-check_1.out, regress/expected/repack-check_2.out and 2 more (+20/-5 lines) download inline-1.patchdiff --git a/regress/expected/repack-check.out b/regress/expected/repack-check.out index 3925b09..16a8e8d 100644 --- a/regress/expected/repack-check.out +++ b/regress/expected/repack-check.out @@ -127,7 +127,10 @@ SELECT oid, relname (0 rows) -- check columns options -SELECT attname, nullif(attstattarget, -1) as attstattarget, attoptions +-- skip pg_attver, server-internal column version stored in attoptions +SELECT attname, nullif(attstattarget, -1) as attstattarget, + nullif(array(SELECT o FROM unnest(attoptions) o + WHERE o NOT LIKE 'pg\_attver=%'), '{}') as attoptions FROM pg_attribute WHERE attrelid = 'tbl_idxopts'::regclass AND attnum > 0 diff --git a/regress/expected/repack-check_1.out b/regress/expected/repack-check_1.out index ff7b527..2059df2 100644 --- a/regress/expected/repack-check_1.out +++ b/regress/expected/repack-check_1.out @@ -127,7 +127,10 @@ SELECT oid, relname (0 rows) -- check columns options -SELECT attname, nullif(attstattarget, -1) as attstattarget, attoptions +-- skip pg_attver, server-internal column version stored in attoptions +SELECT attname, nullif(attstattarget, -1) as attstattarget, + nullif(array(SELECT o FROM unnest(attoptions) o + WHERE o NOT LIKE 'pg\_attver=%'), '{}') as attoptions FROM pg_attribute WHERE attrelid = 'tbl_idxopts'::regclass AND attnum > 0 diff --git a/regress/expected/repack-check_2.out b/regress/expected/repack-check_2.out index 059c93c..6dd6b21 100644 --- a/regress/expected/repack-check_2.out +++ b/regress/expected/repack-check_2.out @@ -127,7 +127,10 @@ SELECT oid, relname (0 rows) -- check columns options -SELECT attname, nullif(attstattarget, -1) as attstattarget, attoptions +-- skip pg_attver, server-internal column version stored in attoptions +SELECT attname, nullif(attstattarget, -1) as attstattarget, + nullif(array(SELECT o FROM unnest(attoptions) o + WHERE o NOT LIKE 'pg\_attver=%'), '{}') as attoptions FROM pg_attribute WHERE attrelid = 'tbl_idxopts'::regclass AND attnum > 0 diff --git a/regress/expected/repack-check_3.out b/regress/expected/repack-check_3.out index 079a756..95d42a6 100644 --- a/regress/expected/repack-check_3.out +++ b/regress/expected/repack-check_3.out @@ -127,7 +127,10 @@ SELECT oid, relname (0 rows) -- check columns options -SELECT attname, nullif(attstattarget, -1) as attstattarget, attoptions +-- skip pg_attver, server-internal column version stored in attoptions +SELECT attname, nullif(attstattarget, -1) as attstattarget, + nullif(array(SELECT o FROM unnest(attoptions) o + WHERE o NOT LIKE 'pg\_attver=%'), '{}') as attoptions FROM pg_attribute WHERE attrelid = 'tbl_idxopts'::regclass AND attnum > 0 diff --git a/regress/sql/repack-check.sql b/regress/sql/repack-check.sql index 1c3ef13..519e1f2 100644 --- a/regress/sql/repack-check.sql +++ b/regress/sql/repack-check.sql @@ -44,7 +44,10 @@ SELECT oid, relname AND reltoastrelid NOT IN (SELECT oid FROM pg_class WHERE relkind = 't'); -- check columns options -SELECT attname, nullif(attstattarget, -1) as attstattarget, attoptions +-- skip pg_attver, server-internal column version stored in attoptions +SELECT attname, nullif(attstattarget, -1) as attstattarget, + nullif(array(SELECT o FROM unnest(attoptions) o + WHERE o NOT LIKE 'pg\_attver=%'), '{}') as attoptions FROM pg_attribute WHERE attrelid = 'tbl_idxopts'::regclass AND attnum > 0
^ permalink raw [nested|flat] 4+ messages in thread

* Re: [reorg/pg_repack] PR #490: Ignore pg_attver in repack-check attoptions output
@ 2026-11-12 15:34  "za-arthur (@za-arthur)" <noreply+za-arthur@github.com>
  2 siblings, 0 replies; 4+ messages in thread

From: za-arthur (@za-arthur) @ 2026-11-12 15:34 UTC (permalink / raw)
  To: reorg/pg_repack <noreply+reorg-pg_repack@github.com>

Thanks for the fix! I'm merging the PR.

^ permalink  raw  [nested|flat] 4+ messages in thread

* Re: [reorg/pg_repack] PR #490: Ignore pg_attver in repack-check attoptions output
@ 2026-11-12 15:34  "za-arthur (@za-arthur)" <noreply+za-arthur@github.com>
  2 siblings, 0 replies; 4+ messages in thread

From: za-arthur (@za-arthur) @ 2026-11-12 15:34 UTC (permalink / raw)
  To: reorg/pg_repack <noreply+reorg-pg_repack@github.com>

@za-arthur merged this (commit e38370467617).

^ permalink  raw  [nested|flat] 4+ messages in thread

* Re: [reorg/pg_repack] PR #490: Ignore pg_attver in repack-check attoptions output
@ 2026-11-12 15:34  "za-arthur (@za-arthur)" <noreply+za-arthur@github.com>
  2 siblings, 0 replies; 4+ messages in thread

From: za-arthur (@za-arthur) @ 2026-11-12 15:34 UTC (permalink / raw)
  To: reorg/pg_repack <noreply+reorg-pg_repack@github.com>

@za-arthur closed this.

^ permalink  raw  [nested|flat] 4+ messages in thread


end of thread, other threads:[~2026-11-12 15:34 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-11-11 12:59 [reorg/pg_repack] PR #490: Ignore pg_attver in repack-check attoptions output "dutow (@dutow)" <noreply+dutow@github.com>
2026-11-12 15:34 ` "za-arthur (@za-arthur)" <noreply+za-arthur@github.com>
2026-11-12 15:34 ` "za-arthur (@za-arthur)" <noreply+za-arthur@github.com>
2026-11-12 15:34 ` "za-arthur (@za-arthur)" <noreply+za-arthur@github.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox