public inbox for [email protected]
help / color / mirror / Atom feedFrom: Huang, Jun <[email protected]>
To: [email protected] <[email protected]>
Subject: The target connection was wrong in function check_version_compatibility()
Date: Tue, 12 Jan 2021 05:32:49 +0000
Message-ID: <14c57b0c3cac446d8d6dab6aed35a8df@G08CNEXMBPEKD06.g08.fujitsu.local> (raw)
Hi,
The target connection was made by source connection manager(it should be made by target connection manager)
in function check_version_compatibility(web\pgadmin\tools\schema_diff\__init__.py).
Attached patch adds the changes.
Regrads,
Huang
Attachments:
[application/octet-stream] 0001-Target-connection-was-wrong-in-function.patch (1002B, 2-0001-Target-connection-was-wrong-in-function.patch)
download | inline diff:
From ae6dbbd16cb39189f4e2597d1d9e4e6dbd6dbd14 Mon Sep 17 00:00:00 2001
From: "huangj.fnst" <[email protected]>
Date: Tue, 12 Jan 2021 13:13:27 +0800
Subject: [PATCH] Target connection was wrong in function
check_version_compatibility(),fix it.
---
web/pgadmin/tools/schema_diff/__init__.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/web/pgadmin/tools/schema_diff/__init__.py b/web/pgadmin/tools/schema_diff/__init__.py
index ecf55967e..7ca19d2d2 100644
--- a/web/pgadmin/tools/schema_diff/__init__.py
+++ b/web/pgadmin/tools/schema_diff/__init__.py
@@ -709,7 +709,7 @@ def check_version_compatibility(sid, tid):
tar_server = Server.query.filter_by(id=tid).first()
tar_manager = driver.connection_manager(tar_server.id)
- target_conn = src_manager.connection()
+ target_conn = tar_manager.connection()
if not (src_conn.connected() and target_conn.connected()):
return False, gettext('Server(s) disconnected.')
--
2.23.0.windows.1
view thread (2+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: The target connection was wrong in function check_version_compatibility()
In-Reply-To: <14c57b0c3cac446d8d6dab6aed35a8df@G08CNEXMBPEKD06.g08.fujitsu.local>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox