Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNEBn-0002JZ-Mn for pgadmin-hackers@arkaria.postgresql.org; Wed, 13 Jul 2016 07:02:35 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bNEBm-0001rc-Nr for pgadmin-hackers@arkaria.postgresql.org; Wed, 13 Jul 2016 07:02:34 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bNEBl-0001rT-8e for pgadmin-hackers@postgresql.org; Wed, 13 Jul 2016 07:02:33 +0000 Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bNEBh-0008Jx-9R for pgadmin-hackers@postgresql.org; Wed, 13 Jul 2016 07:02:32 +0000 Received: by mail-wm0-x22a.google.com with SMTP id f126so15881399wma.1 for ; Wed, 13 Jul 2016 00:02:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=2anjDTGLVhi4RtUUaElAhvrkgPbNekHuC1kBC7DlTus=; b=Azl0ZDR6yLYd/l7d3yArnbkxpF6bALF0MDz+FuBPJSWCErhIIBPTmVSufgnEwpHfgp DdWGNFh9M4CtAiDlEfXmsDA018tjEgwDLUvmMucr2BIDcSK61B/iNDFgyu5WS6Y66NLV ZJu+/HXpFe5ZJveUtWgBhJEQJrNsQuClGdeJtScTFMJ8TYHKW69mpmg7RJ1yd1fHxmXJ 3MexnkmUMy1UWOen0iqiQKfFczKMzg3SzrqK3/X+Q1d1YSRtQUg/FjPKGJ35nFoSJJNh K5STTxUN2U7ap3zf4KyjHno/T+IvXHLz3ln/AD6dtfHzFihP111kzrMSGsBtNTxizpuf nkRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=2anjDTGLVhi4RtUUaElAhvrkgPbNekHuC1kBC7DlTus=; b=FlTnz4ssfDWZ82wmBEpgVXNbsNyzftPpyEA3P5pObrt+uktV85EOrMMQBqddIr3zjp LW3dKsmB84vWfqDIxJnTDj+szA81aqMIpyrRWg73Y/wgYSfbdYH9h26ekig5kx3nWSjD 5QfpOK18nNUNKz34q0jxlf1/kZ2kh9vSqeEbelFzi1lX6OUHs+F9RKS7AMbcQTiUOReY ZJNTY65eYYxl37AltKwU5PmzzasovC8gJrjfcfRjn8Doqnk73QrWYBbiqbblumpvwvkL PboOVwOvUZdy1ynNEa0twp3FHLg9gYb6UYatWouL4rVJQah41chCFWQ4VDscM1D5BeGt Z+tA== X-Gm-Message-State: ALyK8tKcQotoB2vD2V84+kG+qtKKIYO4tIif2QM0R0nGFmo2svr1+lmvo3+Wp917ReHmSg== X-Received: by 10.28.39.132 with SMTP id n126mr27431203wmn.27.1468393346599; Wed, 13 Jul 2016 00:02:26 -0700 (PDT) Received: from ?IPv6:2a02:c7f:6c05:9c00:2de7:27d5:7a6e:654c? ([2a02:c7f:6c05:9c00:2de7:27d5:7a6e:654c]) by smtp.gmail.com with ESMTPSA id u145sm9312725wmu.4.2016.07.13.00.02.24 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 13 Jul 2016 00:02:24 -0700 (PDT) Content-Type: multipart/alternative; boundary=Apple-Mail-6E557235-3062-458F-96E9-15AC9C0C1F46 Mime-Version: 1.0 (1.0) Subject: Re: [pgAdmin4][Patch]: Render data grid only if Dashboard Panel is active From: Dave Page X-Mailer: iPhone Mail (13F69) In-Reply-To: Date: Wed, 13 Jul 2016 08:02:23 +0100 Cc: pgadmin-hackers Content-Transfer-Encoding: 7bit Message-Id: <15FAEF8A-E482-40A9-8C83-57D3F8458143@pgadmin.org> References: To: Surinder Kumar X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --Apple-Mail-6E557235-3062-458F-96E9-15AC9C0C1F46 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Won't this result in incorrect graphs? I.e. chunks of data being missing (bu= t not obviously so)? --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 13 Jul 2016, at 07:47, Surinder Kumar = wrote: >=20 > Hi >=20 > In Dashboard, the ajax calls to render data grid should only made, if dash= board panel is active. > Currently it make ajax calls even if other panels like properties, sql are= active. >=20 > Please find attached patch and review. >=20 > Thanks, > Surinder Kumar > >=20 > --=20 > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers --Apple-Mail-6E557235-3062-458F-96E9-15AC9C0C1F46 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Won't this result in incorrect graphs?= I.e. chunks of data being missing (but not obviously so)?

-- 
Dave Page
Blo= g: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB U= K:htt= p://www.enterprisedb.com
The Enterprise PostgreSQL Company

On 13 Jul 2016, at 07:47, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote= :

Hi

In Dashboard, the ajax calls to render data grid should only= made, if dashboard panel is active.
Currently it make ajax calls e= ven if other panels like properties, sql are active.

Please find attached patch and review.

Thanks,
Surinder Kumar
<dashboard_render_if_pa= nel_is_opened.patch>

--
Sent via pgadmin-hackers mailing lis= t (pgadmin-hackers@postgre= sql.org)
To make changes to your subscription:http:/= /www.postgresql.org/mailpref/pgadmin-hackers
= --Apple-Mail-6E557235-3062-458F-96E9-15AC9C0C1F46--