Date: Wed, 2 Sep 2020 04:20:46 +0000 (UTC)
From: Warren Chan <wchan_syd@yahoo.com.au>
To: 
	"pgadmin-hackers@lists.postgresql.org" <pgadmin-hackers@lists.postgresql.org>
Message-ID: <1872014587.1397537.1599020446172@mail.yahoo.com>
Subject: pgAdmin4 - help adding new node to Browser Tree
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_1397536_434113518.1599020446171"
References: <1872014587.1397537.1599020446172.ref@mail.yahoo.com>
Content-Length: 6067
Precedence: bulk

------=_Part_1397536_434113518.1599020446171
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi, 

I'm trying to learn about the pgAdmin4 project and am hoping to make some contributions sometime in the future.
I'm new to Flask and python but am keen to learn.
While trying to familiarize myself with the application and the way it works, I've tried to create a 'test' node under the schema node, I want to list test items under this node - not listing anything particular at the moment but wanted to get an understanding of how the application ties together). In order to just get a new node added under schema, I've copied the sequence folder under \web\pgadmin\browser\server_groups\servers\databases\schemas and renamed the applicable folders to tests (I want a test node to appear under schema).
I've updated the \tests\_init_.py file so that the SequenceModule has been changed to TestModule (updated the NODE_TYPE etc). I've also updated the SequenceView to become TestView and other parts of the view like the template path etc. 

In addition to this I've changed the name in the \tests\static\js\sequence.js file to \tests\static\js\test.js and have also updated the test.js file so that any references to sequence has been changed to test and have added 'pgadmin.node.tests' to the webpack.config.js and 'pgadmin.node.test': path.join(__dirname, './pgadmin/browser/server_groups/servers/databases/schemas/tests/static/js/test') to the webpack.shim.js file
Doing this I was hoping that a new 'Test' node would appear under the schema directory and opening this node, would render all the sequences (as I haven't changed any of the sql). However I only get the new 'Test' node being rendered, and when I open this, I get a Server Node with the server I'm connected to being added, not the list of sequences I was hoping for. 

Is there an additional setting / steps I need to add somewhere in order to get the TestView to render under the TestModule node?

I'd appreciate any pointers to get this working as the next thing I'd like, would be to start modifying the sql and getting different database objects being listed.
Best regards,Warren Chan


------=_Part_1397536_434113518.1599020446171
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<html><head></head><body><div class=3D"ydp9731bec7yahoo-style-wrap" style=
=3D"font-family: Helvetica Neue, Helvetica, Arial, sans-serif; font-size: 1=
3px;"><div id=3D"ydp9731bec7yiv2984217286"><div><div class=3D"ydp9731bec7yi=
v2984217286yahoo-style-wrap" style=3D"font-family:Helvetica Neue, Helvetica=
, Arial, sans-serif;font-size:13px;"><div dir=3D"ltr">Hi, <br></div><div di=
r=3D"ltr"><br></div><div dir=3D"ltr">I'm trying to learn about the pgAdmin4=
 project and am hoping to make some contributions sometime in the future.</=
div><div dir=3D"ltr"><br></div><div dir=3D"ltr">I'm new to Flask and python=
 but am keen to learn.</div><div dir=3D"ltr"><br></div><div dir=3D"ltr">Whi=
le trying to familiarize myself with the application and the way it works, =
I've tried to create a 'test' node under the schema node, I want to list te=
st items under this node - not listing anything particular at the moment bu=
t wanted to get an understanding of how the application ties together). In =
order to just get a new node added under schema, <span>I've copied the sequ=
ence folder under=20
\web\pgadmin\browser\server_groups\servers\databases\schemas and=20
renamed the applicable folders to tests (I want a test node to appear under=
 schema).</span></div><div dir=3D"ltr"><span><br></span></div><div dir=3D"l=
tr"><span>I've updated the \tests\_init_.py file so that the SequenceModule=
 has been changed to TestModule (updated the NODE_TYPE etc). I've also upda=
ted the SequenceView to become TestView and other parts of the view like th=
e template path etc. <br></span></div><div dir=3D"ltr"><span><br></span></d=
iv><div dir=3D"ltr"><span>In addition to this I've changed the name in the =
\tests\static\js\sequence.js file to <span><span>\tests\static\js\test.js a=
nd have also updated the test.js file so that any references to sequence ha=
s been changed to test and have added 'pgadmin.node.tests' to the webpack.c=
onfig.js and <span>'pgadmin.node.test': path.join(__dirname, './pgadmin/bro=
wser/server_groups/servers/databases/schemas/tests/static/js/test') to the =
webpack.shim.js file</span></span></span></span></div><div dir=3D"ltr"><spa=
n><span><span><span><br></span></span></span></span></div><div dir=3D"ltr">=
<span><span><span><span>Doing this I was hoping that a new 'Test' node woul=
d appear under the schema directory and opening this node, would render all=
 the sequences (as I haven't changed any of the sql). However I only get th=
e new 'Test' node being rendered, and when I open this, I get a Server Node=
 with the server I'm connected to being added, not the list of sequences I =
was hoping for. <br></span></span></span></span></div><div dir=3D"ltr"><spa=
n><span><span><span><br></span></span></span></span></div><div dir=3D"ltr" =
data-setdir=3D"false"><span><span><span><span>Is there an additional settin=
g / steps I need to add somewhere in order to get the TestView to render un=
der the TestModule node?<br></span></span></span></span></div><div dir=3D"l=
tr"><span><span><span><span><br></span></span></span></span></div><div dir=
=3D"ltr"><span><span><span><span>I'd appreciate any pointers to get this wo=
rking as the next thing I'd like, would be to start modifying the sql and g=
etting different database objects being listed.</span></span></span></span>=
</div><div dir=3D"ltr"><span><span><span><span><br></span></span></span></s=
pan></div><div dir=3D"ltr" data-setdir=3D"false"><span><span><span><span>Be=
st regards,</span></span></span></span></div><div dir=3D"ltr"><span><span><=
span><span>Warren Chan</span></span></span></span><br></div><div dir=3D"ltr=
"><br></div><div dir=3D"ltr"><br></div></div></div></div></div></body></htm=
l>
------=_Part_1397536_434113518.1599020446171--