Date: Thu, 28 Jun 2018 13:47:06 +0200
From: Christoph Berg <myon@debian.org>
To: Dave Page <dpage@pgadmin.org>
Cc: Syed Fahar Abbas <fahar.abbas@enterprisedb.com>,
	Devrim =?iso-8859-1?B?R9xORNxa?= <devrim@gunduz.org>,
	pgadmin-hackers <pgadmin-hackers@postgresql.org>
Subject: Re: pgAdmin v3.1 candidate builds and source...
Message-ID: <20180628114706.GB32048@msg.df7cb.de>
References: 
 <CA+OCxow1BDDXK9K1d-pnSAoBE5O=+RD6QNxA5ynH-X+-rPN7jA@mail.gmail.com>
 <20180626192819.GA32582@msg.df7cb.de>
 <CA+OCxozp8Zsj+NTF8hBt46oDJku6oFA6ayTex4jkjyXNsR84Xw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CA+OCxozp8Zsj+NTF8hBt46oDJku6oFA6ayTex4jkjyXNsR84Xw@mail.gmail.com>
User-Agent: Mutt/1.10.0 (2018-05-17)
Precedence: bulk

Re: Dave Page 2018-06-27 <CA+OCxozp8Zsj+NTF8hBt46oDJku6oFA6ayTex4jkjyXNsR84Xw@mail.gmail.com>
> On Tue, Jun 26, 2018 at 8:28 PM, Christoph Berg <myon@debian.org> wrote:
> 
> > Re: Dave Page 2018-06-26 <CA+OCxow1BDDXK9K1d-pnSAoBE5O=+
> > RD6QNxA5ynH-X+-rPN7jA@mail.gmail.com>
> > > ... can be found at https://developer.pgadmin.org/builds/2018-06-26-3.1/
> > > and dpage/pgadmin4:2018-06-26-3.1 on Docker Hub.
> > >
> > > Fahar; please verify for release on Thursday.
> > >
> > > Note that these are the first builds from the new fully automated build
> > > system, and both the Windows and Mac versions now use Python 3, so please
> > > be sure to test with extra care!
> >
> > Hmm, ModuleNotFoundError: No module named 'sshtunnel'
> >
> > Could you perhaps announce new versions that need new python modules a
> > bit earlier, so we have time to package them?
> >
> 
> Good point. Not entirely sure how the mechanics of that would work, given
> that we're trying to shorten release cycles down to a couple of weeks
> (ideally).

Just drop a note "hey we've added $module" once a non-standard
dependency is added.

> That said, for all other builds we're giving up trying to maintain Python
> packages. Instead, we're going to be shipping a pre-built Python venv as
> part of the package, built using Python 3.6. Whilst it's not perfect from a
> "following the packaging rules" perspective, in other cases we're having to
> install modules privately for pgAdmin anyway to avoid conflicts with older,
> vendor supplied versions, so it's really just a different evil rather than
> a new one.

I'm not going to "pip install" or whatever from the build system.

That said, the web/pgadmin/static/*/generated/ directories have
disappeared from the tarball, so pgadmin doesn't load anymore. Could
you please put them back, as I don't think rebuilding them via yarn is
feasible? Because that's not packaged either...

Christoph