From: Shaheed Haque <shaheedhaque@gmail.com>
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>,
 Dave Page <dpage@pgadmin.org>
Subject: Re: Making Kerberos optional in the Python wheel
Date: Thu, 04 Mar 2021 10:06:57 +0000
Message-ID: <2770352.mvXUDI8C0e@baba>
In-Reply-To: 
 <CA+OCxowzCN8wznYjG_631tB2XYgqv5LCXkD49jkXAUtD7d9t3g@mail.gmail.com>
References: 
 <CA+OCxowzCN8wznYjG_631tB2XYgqv5LCXkD49jkXAUtD7d9t3g@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Archived-At: <https://www.postgresql.org/message-id/2770352.mvXUDI8C0e%40baba>
Precedence: bulk

A big thumbs up from me at least :-).

On Thursday, 4 March 2021 10:02:00 GMT Dave Page wrote:
> There have been a couple of complaints that the latest Python wheel
> distribution doesn't install cleanly. This happens when there is no
> pre-built gssapi wheel on PyPi that matches the users combination of Python
> version and platform, *and* the MIT Kerberos development headers etc. are
> not present on the system, so the source wheel cannot be compiled.
> 
> This seems like it's a bit onerous on users, especially if they're on
> Windows where they'll also need a suitable compiler to be installed. The
> attached patch aims to address that by making the Kerberos support optional
> (thankfully, Khushboo made the code handle lack of gssapi libraries).
> 
> To install without gssapi, users would simply do:
> 
> pip install pgadmin4
> 
> or
> 
> pip install pip install /path/to/pgadmin4-5.0-py3-none-any.whl
> 
> To install with gssapi:
> 
> pip install pgadmin4['kerberos']
> 
> or
> 
> pip install pip install /path/to/pgadmin4-5.0-py3-none-any.whl['kerberos']
> 
> The patch also cleans up some old cruft that was required for now
> unsupported Python versions.
> 
> Thoughts?