Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aEEZS-0004jC-90 for pgadmin-hackers@arkaria.postgresql.org; Wed, 30 Dec 2015 11:05:34 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aEEZR-0007vM-J0 for pgadmin-hackers@arkaria.postgresql.org; Wed, 30 Dec 2015 11:05:33 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aEEZQ-0007vG-T6 for pgadmin-hackers@postgresql.org; Wed, 30 Dec 2015 11:05:33 +0000 Received: from mail-wm0-x22b.google.com ([2a00:1450:400c:c09::22b]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1aEEZN-0006ru-Jk for pgadmin-hackers@postgresql.org; Wed, 30 Dec 2015 11:05:31 +0000 Received: by mail-wm0-x22b.google.com with SMTP id f206so34156120wmf.0 for ; Wed, 30 Dec 2015 03:05:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=pJpligdMIRFpfa3nJrpV7baHoQzWI60wLdEzSL5uico=; b=uJbPQyT8hjtP8YJwc1qGBWhvAam4/czMQjdBlp6wk70lGMqqt8mdiXFAE5TmMJWFrT eilppdBMyI13qWJsbHa7D70Shw+FrhAOxbN4aygjGCyhF7DNjv8GiUtP91AJEmY2aSf+ QredujOPfiS+Txq/QwPXoedNs/P2UwlODUOk1zFA98e7BTNWSk2O2YnSdzJDoA75gnr9 2pgvt7lQTd9t60IEwVLW2mv4tt17D+rYl01P8GTxF7aamNiOhygm2R3Ki3WfbTr36vko XeLbSU0JdtwfoBigfY1BzlougMtG+yR7b7ii5KO8+Q061CEa88PcR6rapwdMEkob5j4s D6ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to; bh=pJpligdMIRFpfa3nJrpV7baHoQzWI60wLdEzSL5uico=; b=HZVokytmMdgZjkdI2LvQMYmAVAIqj/c4vTzb0kcJnjoLPsFH12po0u9612RniImGBz R1N3S7Q+vwhXVSZ3zCmQIcIfgP2g7z+XdRvjC/gcWMhkam4p2F1DJC61UnIiTdhgm5Mb jfRwKBliqA+nmJC6yedsL0DJM50I075fLD3MW1uCJmZmmVecJ7byyu9GTFR0BUhnLXAB TniVayiN5XpNtihZs3puX0T7ENWZtcXqmntaOLYopkuqhD37lec9x3oFD1ggDvlfucmd gjb1/BiuIbxgLaYU9kHA09fxtkJiEj/VhPVEoNkI/VBbuWcwC4YJKObMKWr0lavhSsCO Jp5Q== X-Gm-Message-State: ALoCoQl1S0PVDQHQ1DGv9deX2YSb+M1qmYH4Uz0GUTPCEiU4ruvMPVeHk4RYpQiI+Iv74cLPaJiXsZHDEJv+V+hGht3AI0X5Pw== X-Received: by 10.28.232.208 with SMTP id f77mr62748609wmi.34.1451473528120; Wed, 30 Dec 2015 03:05:28 -0800 (PST) Received: from [31.122.123.64] ([31.122.123.64]) by smtp.gmail.com with ESMTPSA id z137sm30597639wmc.8.2015.12.30.03.05.27 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 30 Dec 2015 03:05:27 -0800 (PST) Content-Type: multipart/alternative; boundary=Apple-Mail-D991E154-7B3C-415E-AE26-641256597426 Mime-Version: 1.0 (1.0) Subject: Re: pgAdmin3: check_option translated in View editing dialog From: Dave Page X-Mailer: iPhone Mail (13C75) In-Reply-To: Date: Wed, 30 Dec 2015 11:05:26 +0000 Cc: Sebastian Albert , pgadmin-hackers Content-Transfer-Encoding: 7bit Message-Id: <28D414BF-856A-4D21-97BE-33EC3AAF6DF7@pgadmin.org> References: <567AA0E4.2030101@math.uni-goettingen.de> <567BDDEC.2070102@math.uni-goettingen.de> To: Neel Patel , Ashesh Vashi X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --Apple-Mail-D991E154-7B3C-415E-AE26-641256597426 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Ashesh, can you review/commit please? Thanks. --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 28 Dec 2015, at 10:43, Neel Patel wrote: >=20 > Hi Dave, >=20 > I have fixed the issue. Can you please review the attached patch file ? Le= t me know for any comments. >=20 > @Sebastian - Can you please apply and test the attached patch file ? Let u= s know for any issue. >=20 > Thanks, > Neel Patel >=20 >> On Thu, Dec 24, 2015 at 5:44 PM, Neel Patel = wrote: >> Hi Sebastian, >>=20 >> Thank you for the information. Issue is reproduced with the given steps. >> I will submit the patch after the fix. >>=20 >> Thanks, >> Neel Patel >>=20 >>> On Thu, Dec 24, 2015 at 5:28 PM, Sebastian Albert wrote: >>> -----BEGIN PGP SIGNED MESSAGE----- >>> Hash: SHA256 >>>=20 >>> Hi Neel >>>=20 >>> Thanks for looking into it. Dave is right, it's about the SQL >>> statement not working (because of translation appearing for a sort of >>> keyword) *unless* edited manually. You should not *have to* edit the >>> SQL manually, but due to the issue, you do, no matter what property of >>> the view you are trying to change. >>>=20 >>> So, to reproduce: >>> 1. Create a view >>> 2. Set language of pgAdmin to German >>> 3. Try to change anything on the view, e.g., try to rename it, using >>> the properties dialog. >>>=20 >>> Unless I edit the SQL statement, I am presented an SQL error, which >>> comes from the check_option setting being translated. >>>=20 >>> Happy holidays >>> Sebastian >>>=20 >>> On 24.12.2015 12:20, Dave Page wrote: >>> > On Thu, Dec 24, 2015 at 11:18 AM, Neel Patel >>> > wrote: >>> >> Hi Sebastian, >>> >> >>> >> We have just tried to reproduce the issue but not able to >>> >> understand the issue from the description. >>> >> >>> >> We followed below steps. >>> >> >>> >> 1. Change the language to German. 2. Open the existing View's >>> >> properties and try to change "With check option". 3. Open SQL >>> >> tab - According to change in option, we are able to see and edit >>> >> the query. >>> >> >>> >> Let me know if anything missing in above steps or Can you please >>> >> give steps to understand the issue ? >>> > >>> > Hi Neel, >>> > >>> > I believe the issue is that "no" is being translated to "nein" in >>> > the SQL: >>> > >>> > ALTER VIEW myview SET (check_option=3Dnein); >>> > >>> -----BEGIN PGP SIGNATURE----- >>> Version: GnuPG v2 >>>=20 >>> iQIcBAEBCAAGBQJWe93qAAoJEKZN7hpT3kUKTrgP/1wmrrScAtfvNc269K9+t1sa >>> UKyBfyMFvSgcMgydLC6bjsV5ECN2EVeV/qtNy6tGIlpWppzTtXccQxbKvQiwkyT1 >>> F3MHM6tp869kegB0N2ZU5mzE+8ko/PaFRAISQomSlpxpDsATZ+5nR3VnFnh5DMde >>> 4XYbPvdZWH4Kos9yrWDKTxi5FVHbCvj4m86Qxg8hMlOGUixRDlVx77t1dccchEjq >>> OJRenlQWO9x65iRQbobXJtJddyQLplulc7enBgSJapQahQ4QTqe4RTx7f4Qya2B8 >>> 9bIndvgIvbI08cnss7BQ8iJvK737gMoHc9CscwEAwadaI69/2QAlB4wtwS5bwIZp >>> DIeW+ulNJC40ZX6Ol/QMNZEvm1pBdwncLAUJBaiHht6M9rJcXld99uEPJDfP5wji >>> 2M9WAa3fjyLJFV3d1lA2GYujPgUBAr7KCRcAxgQSXopCj8KICYJzCOkP5skHIPlL >>> zYEMDML3uATmMPbabhy65/mf44WgzjebnQwM86iwnPRbWzfzSrWyK26fm+9CZ6aF >>> kgZvS9bWtQDViS/+6vTMuR3YQK4H+iU88RCIDbrHa8Kn53S8ryglg1f2CKtqrV9z >>> 2bNlK+iCNFxHoz1ApDw0CE8cJTKU31fL/B17+gB/bL6cCtnpzyCjNosRtO7vr89b >>> 7N9Y5AOnyVwbQD42/3EN >>> =3DKwP3 >>> -----END PGP SIGNATURE----- >=20 > --Apple-Mail-D991E154-7B3C-415E-AE26-641256597426 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Ashesh, can you review/commit please? T= hanks.

--&n= bsp;
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsna= ke

EnterpriseDB UK:http://www.enterprisedb.com
The Enterprise Postg= reSQL Company

On 28 Dec 2015, at 10:43, Neel Patel <= neel.patel@enterprisedb.com> wrote:



On Thu,= Dec 24, 2015 at 5:44 PM, Neel Patel <neel.patel@enterprisedb.com<= /a>> wrote:
Hi S= ebastian,

Thank you for the information. Issue is reprodu= ced with the given steps.
I will submit the patch after the fix.

Thanks,
Neel Patel

On Thu, Dec 24, 2015 at 5:28 PM, Sebastian Albert <albe= rt@math.uni-goettingen.de> wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi Neel

Thanks for looking into it. Dave is right, it's about the SQL
statement not working (because of translation appearing for a sort of
keyword) *unless* edited manually. You should not *have to* edit the
SQL manually, but due to the issue, you do, no matter what property of
the view you are trying to change.

So, to reproduce:
1. Create a view
2. Set language of pgAdmin to German
3. Try to change anything on the view, e.g., try to rename it, using
the properties dialog.

Unless I edit the SQL statement, I am presented an SQL error, which
comes from the check_option setting being translated.

Happy holidays
Sebastian

On 24.12.2015 12:20, Dave Page wrote:
> On Thu, Dec 24, 2015 at 11:18 AM, Neel Patel
> <ne= el.patel@enterprisedb.com> wrote:
>> Hi Sebastian,
>>
>> We have just tried to reproduce the issue but not able to
>> understand the issue from the description.
>>
>> We followed below steps.
>>
>> 1. Change the language to German. 2. Open the existing View's
>> properties and try to change "With check option". 3. Open SQL
>> tab - According to change in option, we are able to see and edit >> the query.
>>
>> Let me know if anything missing in above steps or Can you please >> give steps to understand the issue ?
>
> Hi Neel,
>
> I believe the issue is that "no" is being translated to "nein" in
> the SQL:
>
> ALTER VIEW myview SET (check_option=3Dnein);
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWe93qAAoJEKZN7hpT3kUKTrgP/1wmrrScAtfvNc269K9+t1sa
UKyBfyMFvSgcMgydLC6bjsV5ECN2EVeV/qtNy6tGIlpWppzTtXccQxbKvQiwkyT1
F3MHM6tp869kegB0N2ZU5mzE+8ko/PaFRAISQomSlpxpDsATZ+5nR3VnFnh5DMde
4XYbPvdZWH4Kos9yrWDKTxi5FVHbCvj4m86Qxg8hMlOGUixRDlVx77t1dccchEjq
OJRenlQWO9x65iRQbobXJtJddyQLplulc7enBgSJapQahQ4QTqe4RTx7f4Qya2B8
9bIndvgIvbI08cnss7BQ8iJvK737gMoHc9CscwEAwadaI69/2QAlB4wtwS5bwIZp
DIeW+ulNJC40ZX6Ol/QMNZEvm1pBdwncLAUJBaiHht6M9rJcXld99uEPJDfP5wji
2M9WAa3fjyLJFV3d1lA2GYujPgUBAr7KCRcAxgQSXopCj8KICYJzCOkP5skHIPlL
zYEMDML3uATmMPbabhy65/mf44WgzjebnQwM86iwnPRbWzfzSrWyK26fm+9CZ6aF
kgZvS9bWtQDViS/+6vTMuR3YQK4H+iU88RCIDbrHa8Kn53S8ryglg1f2CKtqrV9z
2bNlK+iCNFxHoz1ApDw0CE8cJTKU31fL/B17+gB/bL6cCtnpzyCjNosRtO7vr89b
7N9Y5AOnyVwbQD42/3EN
=3DKwP3
-----END PGP SIGNATURE-----


<View_Fix.patch>
= --Apple-Mail-D991E154-7B3C-415E-AE26-641256597426--