Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8M2A-0002jr-4i for pgadmin-hackers@arkaria.postgresql.org; Wed, 10 May 2017 07:27:42 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d8M29-0000vo-JC for pgadmin-hackers@arkaria.postgresql.org; Wed, 10 May 2017 07:27:41 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d8M1t-0000UX-Ts for pgadmin-hackers@postgresql.org; Wed, 10 May 2017 07:27:26 +0000 Received: from mail-wr0-x229.google.com ([2a00:1450:400c:c0c::229]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d8M1q-0008N7-2m for pgadmin-hackers@postgresql.org; Wed, 10 May 2017 07:27:24 +0000 Received: by mail-wr0-x229.google.com with SMTP id z52so30739789wrc.2 for ; Wed, 10 May 2017 00:27:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=4iXYDhGjD3CpXDdyktQZNm2bn/T+REobwbmDrMn9Tts=; b=K8zvzO1jk3sDYiukfHbbJnFuDsBaktgvXtkAbPhRKZRZ/KThIyT9VNg5TV+c3h96iU 4ZO4ImLVm62xlDkOIspYem61lmHKcxsQvlrovCa1UZidmBLrBAtBGaRbrLCEo0erQTx0 9hZHNSK0ut6zflwGycaEe+9zT24TwdMVM+DsWjgo5EsKsnV4ncf0pOO0+P57f24QYZ7m nWC23uYRhriZ+ShC2Lo0F9//wYogHNmNDe1V91Q0I60NOXqedrmCETuvv6swPl/twGFU otFlZ+/9p3xJ1BMH9mWx3cuhTVwLtYoWv7enCTwjAEcA0Eg1Tjb7c4trDUP7st+PI7Tr bmjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=4iXYDhGjD3CpXDdyktQZNm2bn/T+REobwbmDrMn9Tts=; b=L8re9xhnUfyTA8rRgzU2HxdHXtNk3SZJkZqI2BYpIMfPZ6rIMHbWPB1INFm+e36OOy Q6xR5kPntIbFZZbTqJj4CQI2G3fqThEqeQP9VmA1juUR0auEA5tKyCuk5mimwouH1MwP vr5bEMeJxtLHPIyAwztYQi7TN+/+d3NVdxFV1GZD4p8icXwMc0WHTBGleBYel6e6YKK1 0teFzWFivi45IKZkRcd0wxgYfwM8wVSgI1ZjgfSRd8Hou9HFvq3vYvFuzMN78oBmiqmj agUA6u9xgS2G8YMMZl8su0vvI/SRwa6T00JFS1FhC16GQcz4lr6kv3UmrnbrNLgtMcY7 LouQ== X-Gm-Message-State: AODbwcAvYM9H9+VwP4aEVNaqAOwtcDr1B2YhVfmh9WOZY4k+PoDdgQom 80EjxJX0N3tKEw== X-Received: by 10.28.157.74 with SMTP id g71mr29983wme.74.1494401240291; Wed, 10 May 2017 00:27:20 -0700 (PDT) Received: from [100.85.79.160] ([213.205.198.232]) by smtp.gmail.com with ESMTPSA id c17sm2079597wre.35.2017.05.10.00.27.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 May 2017 00:27:19 -0700 (PDT) Content-Type: multipart/alternative; boundary=Apple-Mail-2011FA31-6C91-413D-BDDF-8370ECC56ADD Mime-Version: 1.0 (1.0) Subject: Re: [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab From: Dave Page X-Mailer: iPhone Mail (14E304) In-Reply-To: Date: Wed, 10 May 2017 08:27:18 +0100 Cc: Akshay Joshi , pgadmin-hackers Content-Transfer-Encoding: 7bit Message-Id: <3117F2B1-07BC-454B-A735-D420508DA303@pgadmin.org> References: <8A654A56-BC41-46FC-AE7A-5C1F48D07208@pgadmin.org> <1F9A3F3B-A4C7-4DA2-BE6C-254781F564E1@pgadmin.org> To: Neel Patel X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --Apple-Mail-2011FA31-6C91-413D-BDDF-8370ECC56ADD Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Yes please. --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 10 May 2017, at 08:24, Neel Patel wrote: >=20 > Should I ask Akshay to review and commit ? >=20 >> On Wed, May 10, 2017 at 12:34 PM, Dave Page wrote: >> Cool :-) >>=20 >> --=20 >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >>=20 >> EnterpriseDB UK:http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >>=20 >>> On 10 May 2017, at 08:01, Neel Patel wrote= : >>>=20 >>> It does not give any error with standard QtWebkit. >>>=20 >>>> On Wed, May 10, 2017 at 12:25 PM, Dave Page wrote: >>>> Hi >>>>=20 >>>> What happens on a standard QtWebKit if we try to trigger QWebPage::Togg= leVideoFullscreen + 1? Does it error, or get silently ignored? >>>>=20 >>>> --=20 >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>>=20 >>>> EnterpriseDB UK:http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>>=20 >>>>> On 10 May 2017, at 07:30, Neel Patel wro= te: >>>>>=20 >>>>> Hi, >>>>>=20 >>>>> Please find attached patch file with the fix of compilation issues wit= h Qt4. Tested with both the version of Qt4 and Qt5 webkit and it is working= now. >>>>>=20 >>>>> As triggerAction code will not be applicable for Qt4 so we made condit= ional macro for Qt5 version check and for backward compatibility webkit vers= ion with Qt5, as in new webkit new enum is added so we have incremented with= one to previous enum value which will solve the problem with both old and n= ew webkit. >>>>>=20 >>>>> Do review it and let me know for any issue. >>>>>=20 >>>>> Thanks, >>>>> Neel Patel >>>>>=20 >>>>>> On Tue, May 9, 2017 at 3:18 PM, Neel Patel wrote: >>>>>> Hi Dave, >>>>>>=20 >>>>>>> On Tue, May 9, 2017 at 3:08 PM, Dave Page wrote: >>>>>>> Hi >>>>>>>=20 >>>>>>>> On Tue, May 9, 2017 at 10:28 AM, Neel Patel wrote: >>>>>>>> Hi Dave, >>>>>>>>=20 >>>>>>>> Here there are 2 compilation issue. We have fixed 'QNetworkCookieJa= r' related compilation error in Qt4. BUT >>>>>>>>=20 >>>>>>>> Below compilation error is coming because we have not applied the l= atest patch of webkit which was fixed in annulen/webkit repo which was raise= d at below path. >>>>>>>>=20 >>>>>>>> https://github.com/annulen/webkit/issues/519 >>>>>>>>=20 >>>>>>>> BrowserWindow.cpp:842:59: error: =E2=80=98RequestClose=E2=80=99 is n= ot a member of =E2=80=98QWebPage=E2=80=99 >>>>>>>> webviewPtr->page()->triggerAction(QWebPage= ::RequestClose); >>>>>>>>=20 >>>>>>>> To fix the above compilation error currently we have two solution. >>>>>>>> Apply the given patch in webkit ( qwebpage.cpp & qwebpage.h file ) .= >>>>>>>> Comment the below line temporary for compilation until we get the r= eleases from annulen/webkit. >>>>>>>> webviewPtr->page()->triggerAction(QWebPage::RequestC= lose); >>>>>>>>=20 >>>>>>>> Other compilation issues, (Me and Akshay) will fix and commit it bu= t need your input on above issue. >>>>>>>=20 >>>>>>> For various reasons we need to retain compatibility with the previou= s versions of qtwebkit. Can we detect at build time what version we have, an= d enable/disable that code as appropriate? >>>>>> =20 >>>>>> Make sense. We will check if we are getting any webkit version in ap= plication or not and update you. >>>>>>=20 >>>>>>> =20 >>>>>>>>=20 >>>>>>>> Thanks, >>>>>>>> Neel Patel >>>>>>>>=20 >>>>>>>>> On Tue, May 9, 2017 at 2:02 PM, Dave Page wrote: >>>>>>>>> It's running CentOS 7.3, with packages from EPEL: >>>>>>>>>=20 >>>>>>>>> [dpage@jenkins ~]$ rpm -qa |grep qt >>>>>>>>> qt5-qtbase-common-5.6.1-10.el7.noarch >>>>>>>>> qt5-qtbase-devel-5.6.1-10.el7.x86_64 >>>>>>>>> qt-4.8.5-13.el7.x86_64 >>>>>>>>> qt5-qtbase-5.6.1-10.el7.x86_64 >>>>>>>>> qt5-qtxmlpatterns-5.6.1-10.el7.x86_64 >>>>>>>>> qt5-qtwebchannel-5.6.1-10.el7.x86_64 >>>>>>>>> qt5-qtwebkit-5.6.1-3.b889f46git.el7.x86_64 >>>>>>>>> qt5-qtdeclarative-devel-5.6.1-10.el7.x86_64 >>>>>>>>> qt-devel-4.8.5-13.el7.x86_64 >>>>>>>>> qt-settings-19-23.5.el7.centos.noarch >>>>>>>>> qt5-qtbase-gui-5.6.1-10.el7.x86_64 >>>>>>>>> qt5-qtlocation-5.6.1-10.el7.x86_64 >>>>>>>>> qt5-qtwebsockets-5.6.1-10.el7.x86_64 >>>>>>>>> qt5-qtwebkit-devel-5.6.1-3.b889f46git.el7.x86_64 >>>>>>>>> qtwebkit-2.3.4-6.el7.x86_64 >>>>>>>>> qt3-3.3.8b-51.el7.x86_64 >>>>>>>>> qt5-qtdeclarative-5.6.1-10.el7.x86_64 >>>>>>>>> qt5-rpm-macros-5.6.1-10.el7.noarch >>>>>>>>> qtwebkit-devel-2.3.4-6.el7.x86_64 >>>>>>>>> qt-x11-4.8.5-13.el7.x86_64 >>>>>>>>> qt5-qtsensors-5.6.1-10.el7.x86_64 >>>>>>>>>=20 >>>>>>>>>> On Tue, May 9, 2017 at 9:28 AM, Neel Patel wrote: >>>>>>>>>> Hi Dave, >>>>>>>>>>=20 >>>>>>>>>> Yes, It looks like compilation fails on Qt4. We will fix this iss= ue but which version of Qt4 we are using in Jenkins ? >>>>>>>>>>=20 >>>>>>>>>> Thanks, >>>>>>>>>> Neel Patel >>>>>>>>>>=20 >>>>>>>>>>> On Tue, May 9, 2017 at 1:56 PM, Dave Page wrote: >>>>>>>>>>>=20 >>>>>>>>>>>=20 >>>>>>>>>>>> On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi wrote: >>>>>>>>>>>> Hi >>>>>>>>>>>>=20 >>>>>>>>>>>>> On Tue, May 9, 2017 at 1:42 PM, Dave Page wrote: >>>>>>>>>>>>> This appears to have made Jenkins get all angry and red :-( >>>>>>>>>>>>>=20 >>>>>>>>>>>>> https://jenkins.pgadmin.org/ >>>>>>>>>>>>=20 >>>>>>>>>>>> We(Neel and I) have tested it and working fine. =20 >>>>>>>>>>>=20 >>>>>>>>>>> It clearly doesn't compile on QT4. Please review the Jenkins log= s. >>>>>>>>>>> =20 >>>>>>>>>>>>>=20 >>>>>>>>>>>>>=20 >>>>>>>>>>>>>> On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi wrote: >>>>>>>>>>>>>> Thanks patch applied. >>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>> On Mon, May 8, 2017 at 3:21 PM, Dave Page wrote: >>>>>>>>>>>>>>> Akshay, could you review this please? >>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>> Thanks. >>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>> On Fri, May 5, 2017 at 11:53 AM, Neel Patel wrote: >>>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>> Please find attached patch file with the fix of RM #2328 - [= Runtime]: Unable to launch query tool and debugger in new browser tab. >>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>> I have used Qt 5.8 with webkit mentioned in below URL. >>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>> https://github.com/annulen/webkit/releases >>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>> As there was a bug in QWebKit regarding "unload" event. We h= ave raised and also they have provided patch file to fix this issue. I have a= pplied the patch in linux and compile the webkit and tested the attached pat= ch with compiled webkit which is now working fine. >>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>> Below is the link for reference regarding unload issue. The= y have provided test webkit release for Mac in below URL but for other platf= orm we need to apply the patch and compile the webkit until they provide web= kit-releases for all platforms. >>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>> https://github.com/annulen/webkit/issues/519 >>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>> Do review it and let me know in case of any issue. >>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>> Neel Patel >>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@post= gresql.org) >>>>>>>>>>>>>>>> To make changes to your subscription: >>>>>>>>>>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>> --=20 >>>>>>>>>>>>>>> Dave Page >>>>>>>>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>>>>>>>> Twitter: @pgsnake >>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>=20 >>>>>>>>>>>>>> --=20 >>>>>>>>>>>>>> Akshay Joshi >>>>>>>>>>>>>> Principal Software Engineer=20 >>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>=20 >>>>>>>>>>>>>> Phone: +91 20-3058-9517 >>>>>>>>>>>>>> Mobile: +91 976-788-8246 >>>>>>>>>>>>>=20 >>>>>>>>>>>>>=20 >>>>>>>>>>>>>=20 >>>>>>>>>>>>> --=20 >>>>>>>>>>>>> Dave Page >>>>>>>>>>>>> VP, Chief Architect, Tools & Installers >>>>>>>>>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>>>>>=20 >>>>>>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>>>>>> Twitter: @pgsnake >>>>>>>>>>>>=20 >>>>>>>>>>>>=20 >>>>>>>>>>>>=20 >>>>>>>>>>>>=20 >>>>>>>>>>>> --=20 >>>>>>>>>>>> Akshay Joshi >>>>>>>>>>>> Principal Software Engineer=20 >>>>>>>>>>>>=20 >>>>>>>>>>>>=20 >>>>>>>>>>>>=20 >>>>>>>>>>>> Phone: +91 20-3058-9517 >>>>>>>>>>>> Mobile: +91 976-788-8246 >>>>>>>>>>>=20 >>>>>>>>>>>=20 >>>>>>>>>>>=20 >>>>>>>>>>>=20 >>>>>>>>>>> --=20 >>>>>>>>>>> Dave Page >>>>>>>>>>> VP, Chief Architect, Tools & Installers >>>>>>>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>>>=20 >>>>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>>>> Twitter: @pgsnake >>>>>>>>>>=20 >>>>>>>>>=20 >>>>>>>>>=20 >>>>>>>>>=20 >>>>>>>>> --=20 >>>>>>>>> Dave Page >>>>>>>>> VP, Chief Architect, Tools & Installers >>>>>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>=20 >>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>> Twitter: @pgsnake >>>>>>>>=20 >>>>>>>=20 >>>>>>>=20 >>>>>>>=20 >>>>>>>=20 >>>>>>> --=20 >>>>>>> Dave Page >>>>>>> VP, Chief Architect, Tools & Installers >>>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>>=20 >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>=20 >>>>>=20 >>>>> >>>=20 >=20 --Apple-Mail-2011FA31-6C91-413D-BDDF-8370ECC56ADD Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Yes please.

-- 
Dave Page
Blog: <= a href=3D"http://pgsnake.blogspot.com/" x-apple-data-detectors=3D"true" x-ap= ple-data-detectors-type=3D"link" x-apple-data-detectors-result=3D"9">http://= pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK:http://www.e= nterprisedb.com
The Enterprise PostgreSQL Company
On 10 May 2017, at 08:24, Neel Patel <neel.patel@enterprisedb.com> wrote:

Should I ask Akshay to review and c= ommit ?

On We= d, May 10, 2017 at 12:34 PM, Dave Page <dpage@pgadmin.org> wro= te:
Cool :-)

--&nbs= p;
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK:http://www.enterprisedb.com
The Enterprise PostgreSQL Company=

On 10 May 2017, at 08:01, Neel P= atel <ne= el.patel@enterprisedb.com> wrote:

It does not give any error with standard QtWebkit.=

On Wed, May 1= 0, 2017 at 12:25 PM, Dave Page <dpage@pgadmin.org> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #= ccc solid;padding-left:1ex">
Hi

What happens o= n a standard QtWebKit if we try to trigger QWebPage::ToggleVideoFullscreen + 1? Does it e= rror, or get silently ignored?

-- 
Dave Page
Blog: http://pgsnake.blogspot.= com
Twitter: @pgsnake

EnterpriseDB UK:http://www.enterprisedb.com
The En= terprise PostgreSQL Company

On 10 May 2017, at 07:30, Neel Patel <neel.patel@enterprised= b.com> wrote:

Hi,

Please find attached patch file with the fix of= compilation issues with Qt4.  Tested with both the version of Qt4 and Q= t5 webkit and it is working now.

As triggerAction c= ode will not be applicable for Qt4 so we made conditional macro for Qt5 vers= ion check and for backward compatibility webkit version with Qt5, as in new w= ebkit new enum is added so we have incremented with one to previous enum val= ue which will solve the problem with both old and new webkit.

=
Do review it and let me know for any issue.

<= div>Thanks,
Neel Patel

<= div class=3D"gmail_quote">On Tue, May 9, 2017 at 3:18 PM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Dave,

On Tue, May 9, 2017 at 3:08 PM, Dave Page <da= ve.page@enterprisedb.com> wrote:
Hi

On Tue, May 9, 2017 at 10:28 AM, Neel Patel <neel.p= atel@enterprisedb.com> wrote:
Hi Dave,

Here there are 2 c= ompilation issue. We have fixed 'QNetworkCookieJar' related compilation erro= r in Qt4. BUT

Below compilation error is coming bec= ause we have not applied the latest patch of webkit which was fixed in annul= en/webkit repo which was raised at below path.


BrowserWindow.cpp:842:59: error: =E2=80=98RequestClose=E2=80=99 is not a m= ember of =E2=80=98QWebPage=E2=80=99
        &n= bsp;                webviewPtr->p= age()->triggerAction(QWebPage::RequestClose);

To fix the above compilation error currently we have two solution.<= /div>
  • Apply the given patch in webkit ( qwebpage.cpp & qwebp= age.h file ) .
  • Comment the below line temporary for compilation unti= l we get the releases from annulen/webkit.
     = ;          webviewPtr->page()->triggerAc= tion(QWebPage::RequestClose);

Other compi= lation issues, (Me and Akshay) will fix and commit it but need your input on= above issue.

For various= reasons we need to retain compatibility with the previous versions of qtweb= kit. Can we detect at build time what version we have, and enable/disable th= at code as appropriate?
 
Make sense.  We will check if we are getting any webkit ve= rsion in application or not and update you.

 
=

Thanks,
Neel Patel

On Tue, May 9, 2017 at 2:02 PM, Dave Page <da= ve.page@enterprisedb.com> wrote:
It's running CentOS 7.3, with packages from EPEL:
<= br>
[dpage@jenkins ~]$ rpm -qa |grep qt
qt5-qtbase-= common-5.6.1-10.el7.noarch
qt5-qtbase-devel-5.6.1-10.el7.x86_64
qt-4.8.5-13.el7.x86_64
qt5-qtbase-5.6.1-10.el7.x= 86_64
qt5-qtxmlpatterns-5.6.1-10.el7.x86_64
qt5-qtw= ebchannel-5.6.1-10.el7.x86_64
qt5-qtwebkit-5.6.1-3.b889f46gi<= wbr>t.el7.x86_64
qt5-qtdeclarative-devel-5.6.1-10.el7.x86_64<= /div>
qt-devel-4.8.5-13.el7.x86_64
qt-settings-19-23.5.el7.cen= tos.noarch
qt5-qtbase-gui-5.6.1-10.el7.x86_64
= qt5-qtlocation-5.6.1-10.el7.x86_64
qt5-qtwebsockets-5.6.1-10.= el7.x86_64
qt5-qtwebkit-devel-5.6.1-3.b889f46git.el7.x86= _64
qtwebkit-2.3.4-6.el7.x86_64
qt3-3.3.8b-51.el7.x86_64=
qt5-qtdeclarative-5.6.1-10.el7.x86_64
qtwebkit-devel-2.3.4-6.el7.x86_64
qt-x11-4.8.5-13.el7.x86_64
qt5-qtsensors-5.6.1-10.el7.x86_64
=
<= br>
On Tue, May 9, 2017 at 9:28 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Dave,

Yes, It looks li= ke compilation fails on Qt4. We will fix this issue but which version of Qt4= we are using in Jenkins ?

Thanks,
Neel P= atel

On Tue, Ma= y 9, 2017 at 1:56 PM, Dave Page <dave.page@enterprisedb.com>= wrote:


On Tue, May 9, 2017= at 9:18 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi
On Tue, May 9, 2= 017 at 1:42 PM, Dave Page <dave.page@enterprisedb.com> wrote:
This appears to have made Jenkin= s get all angry and red :-(


   We(Neel and I) have teste= d it and working fine.  
=
It clearly doesn't compile on QT4. Please review the J= enkins logs.
 


On= Tue, May 9, 2017 at 8:39 AM, Akshay Joshi <akshay.joshi@enterpr= isedb.com> wrote:
Than= ks patch applied.

On Mon, May 8, 2017 at 3:21 PM, Dave Page <dpage@pgadmin= .org> wrote:
Akshay, could y= ou review this please?

Thanks.

On Fri, May 5, 2017 at 11:53 AM, Neel Patel <neel.patel@enterpr= isedb.com> wrote:
Hi,

Please find at= tached patch file with the fix of RM #2328 - [Runtime]: Unable to launch que= ry tool and debugger in new browser tab.

I have used Qt 5.8 with webkit mentioned in below URL.=



As there was a bug in QWebKit regarding "unload" event= . We have raised and also they have provided patch file to fix this issue. I= have applied the patch in linux and compile the webkit and tested the attac= hed patch with compiled webkit which is now working fine.

Below is the li= nk for reference regarding unload issue. They have provided test webkit rele= ase for Mac in below URL but for other platform we need to apply the patch a= nd compile the webkit until they provide webkit-releases for all platforms.<= /div>


Do r= eview it and let me know in case of any issue.

Thanks,
Neel Patel


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hack= ers




--
Dave Page
Blog: http://pgsnake.blogspot= .com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The E= nterprise PostgreSQL Company



--
Akshay Joshi
Principal Software Engineer 





--
Dave P= age
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com<= /a>
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twit= ter: @pgsnake


--
Akshay Joshi
= Principal Software Engi= neer 

=

<= /font>



--
Dave Page
VP, Chief Architect, Tools & In= stallers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company=

Blog: http= ://pgsnake.blogspot.com
Twitter: @pgsnake




--
<= div class=3D"m_1757313796581100076m_7279646494025740165m_3646915978052875876= m_-4780963339364194306m_2216630011400908436m_-2016239111006808430gmail_signa= ture" data-smartmail=3D"gmail_signature">Dave Page
VP, Chief Architect, T= ools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postg= reSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake



<= div>
--
Dave Page
VP, Chief Architect, Tools & InstallersEnterpriseDB: ht= tp://www.enterprisedb.com
The Enterprise PostgreSQL Company

Bl= og: http://pgsnake= .blogspot.com
Twitter: @pgsnake


<webkit_com= pile_issue.patch>


= --Apple-Mail-2011FA31-6C91-413D-BDDF-8370ECC56ADD--