Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH] Beautify line-ends handling yet more.
From: Dave Page <dpage@pgadmin.org>
In-Reply-To: <561905AB.8020801@yandex.ru>
Date: Sat, 10 Oct 2015 14:51:03 +0100
Cc: pgadmin-hackers@postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <4A470437-1E4F-47E1-ACC8-D42491F5BB31@pgadmin.org>
References: <561568BC.5070200@yandex.ru>
 <CA+OCxoy4Oo2WEXqU5_3nnka759FM1BtqZCKZovE1xKfJavr41w@mail.gmail.com>
 <561905AB.8020801@yandex.ru>
To: Nikolai Zhubr <n-a-zhubr@yandex.ru>
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org


> On 10 Oct 2015, at 13:33, Nikolai Zhubr <n-a-zhubr@yandex.ru> wrote:
>=20
> Hello Dave,
> 09.10.2015 16:31, Dave Page wrote:
> [...]
>> I committed a modified version of this - Mac OS X uses \n as a
>> line-end, so that makes a better default than the old-style \r used on
>> Mac classic.
>=20
> Ah, I didn't know that, thanks for explanation.
>=20
> I suppose it is unlikely someone will use current (and future) releases o=
f pgamin3 on Mac classic, therefore I'd propose to also update the correspo=
nding preferences menu. Right now it shows 3 possibilities:
>=20
> * Unix (LF)
> * DOS (CRLF)
> * Mac (CR)
>=20
> Maybe it would make sense to only provide 2 with the following naming:
>=20
> * Unix/Mac (LF)
> * DOS/Windows (CRLF)
>=20
> If it is OK then I'll craft a git diff for that (eventually).

I'm not sure we should - it may be useful for someone working with legacy s=
ystems, and it's not like it's a massive amount of code bloating the app or=
 overly complicating the UI.

--=20
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers