Received: from maia.hub.org (maia-2.hub.org [200.46.204.251]) by mail.postgresql.org (Postfix) with ESMTP id D5FA81337BCE for ; Fri, 21 Jan 2011 20:34:31 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.251]) (amavisd-maia, port 10024) with ESMTP id 87076-02 for ; Sat, 22 Jan 2011 00:34:24 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sd-17937.dedibox.fr (sd-17937.dedibox.fr [88.191.100.74]) by mail.postgresql.org (Postfix) with ESMTP id DDA791337BA5 for ; Fri, 21 Jan 2011 20:34:22 -0400 (AST) Received: from [192.168.10.2] (ASte-Genev-Bois-153-1-58-74.w81-249.abo.wanadoo.fr [81.249.208.74]) by sd-17937.dedibox.fr (Postfix) with ESMTPA id 1B1033B8F5; Sat, 22 Jan 2011 01:34:23 +0100 (CET) Message-ID: <4D3A2609.2040406@lelarge.info> Date: Sat, 22 Jan 2011 01:34:17 +0100 From: Guillaume Lelarge User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); fr; rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7 MIME-Version: 1.0 To: Magnus Hagander CC: pgadmin-hackers@postgresql.org Subject: Re: Patch to support SSL certificate connections References: <4D3623DB.20105@lelarge.info> <4D38B269.6000509@lelarge.info> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.9 tagged_above=-10 required=5 tests=BAYES_00=-1.9 X-Spam-Level: X-Archive-Number: 201101/210 X-Sequence-Number: 17788 Le 21/01/2011 10:17, Magnus Hagander a écrit : > On Thu, Jan 20, 2011 at 23:08, Guillaume Lelarge wrote: >> Le 19/01/2011 00:35, Guillaume Lelarge a écrit : >>> Hi, >>> >>> This patch adds support to specify SSL certificate files and to connect >>> according to those. >>> >>> It's pretty straightforward: four file pickers to handle on dlgServer, >>> and changes in the connection code to add those parameters in the >>> connection string. >>> >> >> A screenshot attached so that you can see the UI without building pgAdmin :) >> >> Comments? > > I would move root cert up before the others. Also CRL. > > Root cert and CRL are about validating the *server* certificate. Key > and cert file are about SSL authentication of the *client* (thus > *client* certificates). They should definitely be in that order - > perhaps even grouped with a headline? > Done for moving widgets. Not sure grouped widgets could make sense here. -- Guillaume http://www.postgresql.fr http://dalibo.com