Received: from maia.hub.org (maia-2.hub.org [200.46.204.251]) by mail.postgresql.org (Postfix) with ESMTP id 56CB21337B77 for ; Fri, 28 Jan 2011 04:37:56 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.251]) (amavisd-maia, port 10024) with ESMTP id 98121-05 for ; Fri, 28 Jan 2011 08:37:49 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sd-17937.dedibox.fr (sd-17937.dedibox.fr [88.191.100.74]) by mail.postgresql.org (Postfix) with ESMTP id 0BF271337B4F for ; Fri, 28 Jan 2011 04:37:49 -0400 (AST) Received: from [192.168.10.2] (ASte-Genev-Bois-153-1-4-228.w83-112.abo.wanadoo.fr [83.112.66.228]) by sd-17937.dedibox.fr (Postfix) with ESMTPA id A1BBA3B8F5; Fri, 28 Jan 2011 09:37:48 +0100 (CET) Message-ID: <4D42805B.2060002@lelarge.info> Date: Fri, 28 Jan 2011 09:37:47 +0100 From: Guillaume Lelarge User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); fr; rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7 MIME-Version: 1.0 To: Dave Page CC: Magnus Hagander , pgadmin-hackers@postgresql.org Subject: Re: Patch to support SSL certificate connections References: <4D3623DB.20105@lelarge.info> <4D38B269.6000509@lelarge.info> <4D3A2609.2040406@lelarge.info> <4D41E9F5.6000808@lelarge.info> <4D426F77.9050102@lelarge.info> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.9 tagged_above=-10 required=5 tests=BAYES_00=-1.9 X-Spam-Level: X-Archive-Number: 201101/251 X-Sequence-Number: 17829 Le 28/01/2011 09:21, Dave Page a écrit : > On Fri, Jan 28, 2011 at 7:25 AM, Guillaume Lelarge > wrote: >> Le 28/01/2011 02:11, Dave Page a écrit : >>> On Thu, Jan 27, 2011 at 9:56 PM, Guillaume Lelarge >>> wrote: >>>> Le 22/01/2011 01:34, Guillaume Lelarge a écrit : >>>>> Le 21/01/2011 10:17, Magnus Hagander a écrit : >>>>>> On Thu, Jan 20, 2011 at 23:08, Guillaume Lelarge wrote: >>>>>>> Le 19/01/2011 00:35, Guillaume Lelarge a écrit : >>>>>>>> Hi, >>>>>>>> >>>>>>>> This patch adds support to specify SSL certificate files and to connect >>>>>>>> according to those. >>>>>>>> >>>>>>>> It's pretty straightforward: four file pickers to handle on dlgServer, >>>>>>>> and changes in the connection code to add those parameters in the >>>>>>>> connection string. >>>>>>>> >>>>>>> >>>>>>> A screenshot attached so that you can see the UI without building pgAdmin :) >>>>>>> >>>>>>> Comments? >>>>>> >>>>>> I would move root cert up before the others. Also CRL. >>>>>> >>>>>> Root cert and CRL are about validating the *server* certificate. Key >>>>>> and cert file are about SSL authentication of the *client* (thus >>>>>> *client* certificates). They should definitely be in that order - >>>>>> perhaps even grouped with a headline? >>>>>> >>>>> >>>>> Done for moving widgets. Not sure grouped widgets could make sense here. >>>>> >>>> >>>> Here is what I finally managed to do. Comments? >>> >>> Why the change from the standard layout used everywhere else? >>> >> >> Because Magnus asked for that kind of design? (grouped with a headline) > > He suggested it, but that doesn't mean it has to be done. If we're > going to break the property dialog design guidelines and start laying > things out in new formats we need to be *really* careful to avoid > getting in an inconsistent mess. > Yeah, I know. And "grouped with a headline" doesn't mean we have to use a wxStaticBoxSizer. Anyway, reading your comments and Ashesh's comments, I will drop the wxStaticBoxSizer and everyone will be happy: * no strange issue on MacOSX for Ashesh * no weird design for you * but still first server certificate and then client certificate for Magnus. Will try to work on this today. -- Guillaume http://www.postgresql.fr http://dalibo.com