Message-ID: <56112A4B.6080202@yandex.ru>
Date: Sun, 04 Oct 2015 16:31:55 +0300
From: Nikolai Zhubr <n-a-zhubr@yandex.ru>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; ru;
 rv:1.9.1.5) Gecko/20091204 Thunderbird/3.0
MIME-Version: 1.0
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Subject: Re: [Patch] Windows installer: allow manually setting
 WIXDIR as appropriate.
References: <560EDBFF.9020305@yandex.ru> <560EF2C6.9040402@yandex.ru>
 <747437891.20151004075533@mail.ru>
In-Reply-To: <747437891.20151004075533@mail.ru>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Hi all,
04.10.2015 7:55, J.F. Oster wrote:
> Hello,
>
> +1
> I proposed the same once but had no feedback.

I'm actually surprised by the very low feedback on the list altogether.

> Nikolai, why doesn't the first version work for you? I have it done similar:

Because if the variable itself contains quotes (and typically it does, 
to deal with spaces in paths) then AFAICS command interpreter gets 
confused when it sees yet more surrounding quotes in a comparison 
operator in a line like you listed below. I'm no expert in cmd.exe 
behaviour, but at least on windows xp it caused interpreter errors, so I 
just used a simple workaround and it then ran fine.

> if NOT "%WIXDIR%"=="" GOTO WIXDIR_SET
> SET WIXDIR="C:\Program Files (x86)\Windows Installer XML v3\bin"
> :WIXDIR_SET
>
>


Thank you,
Nikolai


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers