Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1Zkt5Y-0004sU-SH for pgadmin-hackers@arkaria.postgresql.org; Sat, 10 Oct 2015 12:17:25 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1Zkt5X-000702-UB for pgadmin-hackers@arkaria.postgresql.org; Sat, 10 Oct 2015 12:17:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1Zkt5W-0006zn-B6 for pgadmin-hackers@postgresql.org; Sat, 10 Oct 2015 12:17:22 +0000 Received: from forward13p.cmail.yandex.net ([2a02:6b8:0:1465::bc]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1Zkt5T-0001Xb-JS for pgadmin-hackers@postgresql.org; Sat, 10 Oct 2015 12:17:21 +0000 Received: from smtp19.mail.yandex.net (smtp19.mail.yandex.net [IPv6:2a02:6b8:0:1402::11a]) by forward13p.cmail.yandex.net (Yandex) with ESMTP id 51BE9219D4 for ; Sat, 10 Oct 2015 15:17:17 +0300 (MSK) Received: from smtp19.mail.yandex.net (localhost [127.0.0.1]) by smtp19.mail.yandex.net (Yandex) with ESMTP id 23E93BE00D5 for ; Sat, 10 Oct 2015 15:17:17 +0300 (MSK) Received: by smtp19.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id OeBxO7ok7X-HGjORaDO; Sat, 10 Oct 2015 15:17:16 +0300 (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1444479436; bh=kcs7FKed1v1VeeIjOkmqrjcjKpMwcXhDzqIqztZDZSE=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=DzXDWcRpde/voMRjA+lCGLWjIYEW2Q9+LoGuUNku4yTpG+eNWX6XC6cT83xqQ+vhO 34YnqsPh9FxvG+h/LuxKleFFJRxgDpBoKtTFGSPRwKP/Ly5ZBPYSqCCNdW1GBAFsY0 al261KVkKEk+sGhMMfguIgH1QFaERORYc+U7//BM= Authentication-Results: smtp19.mail.yandex.net; dkim=pass header.i=@yandex.ru X-Yandex-ForeignMX: US Message-ID: <561905AB.8020801@yandex.ru> Date: Sat, 10 Oct 2015 15:33:47 +0300 From: Nikolai Zhubr User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; ru; rv:1.9.1.5) Gecko/20091204 Thunderbird/3.0 MIME-Version: 1.0 To: pgadmin-hackers@postgresql.org Subject: Re: [PATCH] Beautify line-ends handling yet more. References: <561568BC.5070200@yandex.ru> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -2.0 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org Hello Dave, 09.10.2015 16:31, Dave Page wrote: [...] > I committed a modified version of this - Mac OS X uses \n as a > line-end, so that makes a better default than the old-style \r used on > Mac classic. Ah, I didn't know that, thanks for explanation. I suppose it is unlikely someone will use current (and future) releases of pgamin3 on Mac classic, therefore I'd propose to also update the corresponding preferences menu. Right now it shows 3 possibilities: * Unix (LF) * DOS (CRLF) * Mac (CR) Maybe it would make sense to only provide 2 with the following naming: * Unix/Mac (LF) * DOS/Windows (CRLF) If it is OK then I'll craft a git diff for that (eventually). Thank you, Nikolai -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers