public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dmitriy Olshevskiy <[email protected]>
To: pgadmin-hackers <[email protected]>
Cc: Andrej Antonov <[email protected]>
Subject: Re: patch: fix to use ``pg_get_functiondef()``
Date: Wed, 30 Dec 2015 22:46:00 +0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Hello, dear colleagues)
Could you please review this patch (see the
previous letter)?
As I remember, there are several similar, but
unclosed issues
in pgadmin mailing list yet. Really, there is a
problem with
function's definition and this patch probably
could solve it
(at least for postgresql 8.4 and higher). What do
you think?
Thank you.
On 18.12.2015 13:22, Andrej Antonov wrote:
> small fix ( diff see here:
> https://github.com/postgres-impulsm/pgadmin3/commit/72f381aa1964d5630f3ada44768bc562911102e9
> )
>
>
> if we using ``pg_get_functiondef(func_oid)`` --
> in this case -- no need to write additional
> ``ALTER FUNCTION ... = ... ;``.
>
>
> Andrej Antonov писал 2015-12-14 10:51:
>> thank you, Dmitriy. I agree -- this-fix should
>> works better.
>>
>> I applyed this-fix to my local-git-branches
>> ("REL-1_20_0-impulsm" and
>> "fix-to-use-pg_get_functiondef"). works good.
>>
>> Dmitriy Olshevskiy писал 2015-12-13 18:04:
>>> Hi, Andrej!
>>> Here is small fix of your patch - can you
>>> check it please?
>>> I think there must be wxwidgets function
>>> IsEmpty() instead of double
>>> negation,
>>> because type of the variable is wxstring.
>>> Also I added the Trim()
>>> function before
>>> check if function definition is empty or not.
>>>
>>> On 08.12.2015 11:50, Andrej Antonov wrote:
>>>
>>>> patch: fix to use ``pg_get_functiondef()``
>>>> [see attachment file]
>>>>
>>>> it is copy of pull-request
>>>> https://github.com/postgres/pgadmin3/pull/12 [1]
>>>>
>>>> thank you!
>>>
>>> --
>>> Dmitriy Olshevskiy
>>>
>>>
>>> Links:
>>> ------
>>> [1] https://github.com/postgres/pgadmin3/pull/12
>
--
Dmitriy Olshevskiy
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
view thread (6+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: patch: fix to use ``pg_get_functiondef()``
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox