Subject: Re: CleanHelpPath & index.html
To: pgadmin-hackers@postgresql.org
References: <568D8B8A.10804@wars-nicht.de>
From: Andreas 'ads' Scherbaum <adsmail@wars-nicht.de>
Message-ID: <568DF1CB.3040704@wars-nicht.de>
Date: Thu, 7 Jan 2016 06:04:11 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <568D8B8A.10804@wars-nicht.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

On 06.01.2016 22:47, Andreas 'ads' Scherbaum wrote:
>
> looking into misc.cpp, around line 661, there is CleanHelpPath. When I
> try to add a documentation link ending with "index.html", this function
> incorrectly assumes that it must be a directory and adds a "/" (or
> whatever the current separator is).
>
> This even happens when the correct link is in ~/.pgadmin3. The link is
> then read from the config file, cleaned up incorrectly and when I try to
> open the help link, it points to the wrong URL (index.html/).
>
> Attached is a small patch which checks a string in CleanHelpPath if it
> ends in one of the most common file types (.htm, .html, .php and .asp)
> and if this is the case, the string is returned as is.

Actually, screw this patch. pgAdmin3::InitHelp() does some very obscure 
magic if a path ends on "index.html", but only for ".html", not for 
other endings.

I don't know why the old Greenplum documentation link worked before - it 
ends in "index.html". It definitely does not work anymore, but that is 
another patch.

-- 
				Andreas 'ads' Scherbaum
German PostgreSQL User Group
European PostgreSQL User Group - Board of Directors
Volunteer Regional Contact, Germany - PostgreSQL Project


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers