Subject: Re: PATCH: Login/Group Role Node
To: Ashesh Vashi <ashesh.vashi@enterprisedb.com>,
 pgadmin-hackers <pgadmin-hackers@postgresql.org>,
 Akshay Joshi <akshay.joshi@enterprisedb.com>
References: 
 <CAG7mmoy=Wd5xHV=e734d4=8pqS7BOKyL8mUdh-5AMfs84Tm6VQ@mail.gmail.com>
From: Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>
Message-ID: <569759C0.90009@enterprisedb.com>
Date: Thu, 14 Jan 2016 13:48:08 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.0
MIME-Version: 1.0
In-Reply-To: 
 <CAG7mmoy=Wd5xHV=e734d4=8pqS7BOKyL8mUdh-5AMfs84Tm6VQ@mail.gmail.com>
Content-Type: multipart/alternative;
 boundary="------------060004090201080309060309"
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

This is a multi-part message in MIME format.
--------------060004090201080309060309
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit

Hi Ashesh,

Observed so far,

In pgAdmin4,
1) We are not displaying below items in properties when compare to pgAdmin3
- Account expires
- Member of

2) Seems life one of menu item missing when right click on role
- Reassign/ Drop owned

3) Security label is disabled by default, Even though security label is 
disabled, we get precondition error from server saying.

/|"errormsg": "Security Label must be passed as an array of JSON object 
in the following.."|/


Causing:
- When we add variables in Security tab on existing role, Sql does not 
gets generated in sql tab.
- When we add roles role membership on existing role,  Sql does not gets 
generated in sql tab and it also allow us to enter invalid role which 
does not exists.


Regards,
Murtuza

On Tuesday 12 January 2016 10:47 PM, Ashesh Vashi wrote:
> Hi Team,
>
> Please find the patch for Login/Group Role(s).
>
> Akshay/Murtuza,
>
> Can you please review it?
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company 
> <http://www.enterprisedb.com>
>
>
> /http://www.linkedin.com/in/asheshvashi/
>


--------------060004090201080309060309
Content-Type: text/html; charset=windows-1252
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta content="text/html; charset=windows-1252"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    Hi Ashesh,<br>
    <br>
    Observed so far,<br>
    <br>
    In pgAdmin4, <br>
    1) We are not displaying below items in properties when compare to
    pgAdmin3<br>
    - Account expires<br>
    - Member of<br>
    <br>
    2) Seems life one of menu item missing when right click on role<br>
    - Reassign/ Drop owned<br>
    <br>
    3) Security label is disabled by default, Even though security label
    is disabled, we get precondition error from server saying.<br>
    <pre role="list"><i><code class="wrappedText focusRow" role="listitem">"errormsg": "Security Label must be passed as an array of JSON object in the following.."</code></i></pre>
    <br>
    Causing:<br>
    - When we add variables in Security tab on existing role, Sql does
    not gets generated in sql tab.<br>
    - When we add roles role membership on existing role,  Sql does not
    gets generated in sql tab and it also allow us to enter invalid role
    which does not exists.<br>
    <br>
    <br>
    Regards,<br>
    Murtuza<br>
    <br>
    <div class="moz-cite-prefix">On Tuesday 12 January 2016 10:47 PM,
      Ashesh Vashi wrote:<br>
    </div>
    <blockquote
cite="mid:CAG7mmoy=Wd5xHV=e734d4=8pqS7BOKyL8mUdh-5AMfs84Tm6VQ@mail.gmail.com"
      type="cite">
      <div dir="ltr">
        <div>
          <div>
            <div>Hi Team,<br>
              <br>
            </div>
            Please find the patch for Login/Group Role(s).<br>
          </div>
          <br>
        </div>
        <div>Akshay/Murtuza,<br>
          <br>
        </div>
        <div>Can you please review it?<br>
        </div>
        <div>
          <div>
            <div>
              <div>
                <div><br clear="all">
                  <div>
                    <div class="gmail_signature">
                      <div dir="ltr">
                        <div style="margin:0pt 0pt 8px">
                          <p style="margin:0pt"><span
                              style="font-family:courier new,monospace"><span
                                style="font-style:italic"><span>--</span></span></span></p>
                          <p style="margin:0pt"><span
                              style="font-family:courier new,monospace"><span
                                style="font-style:italic"><span>Thanks
                                  &amp; Regards,</span></span><br
                                style="font-style:italic">
                              <br style="font-style:italic">
                              <span style="font-style:italic">Ashesh
                                Vashi</span><br
                                style="font-style:italic">
                              <span style="font-style:italic">EnterpriseDB
                                INDIA: </span><a moz-do-not-send="true"
                                href="http://www.enterprisedb.com"
                                target="_blank">Enterprise PostgreSQL
                                Company</a></span></p>
                          <p style="margin:0pt"><span
                              style="font-family:courier new,monospace"><br>
                            </span></p>
                          <p style="margin:0pt"><span
                              style="font-family:courier new,monospace"><a
                                moz-do-not-send="true"
                                href="http://www.linkedin.com/in/asheshvashi"
                                target="_blank"><i><a class="moz-txt-link-freetext" href="http://www.linkedin.com/in/asheshvashi">http://www.linkedin.com/in/asheshvashi</a></i></a><img
                                moz-do-not-send="true"
src="imap://murtuza%2Ezabuawala%40enterprisedb%2Ecom@imap.gmail.com:993/fetch%3EUID%3E/%5BGmail%5D/Drafts%3E964?p=mozilla&amp;v=2.0.3&amp;t=1285751372076&amp;u=4060523&amp;e=777"
                                height="1" width="1"></span></p>
                        </div>
                      </div>
                    </div>
                  </div>
                </div>
              </div>
            </div>
          </div>
        </div>
      </div>
    </blockquote>
    <br>
  </body>
</html>

--------------060004090201080309060309--