public inbox for [email protected]
help / color / mirror / Atom feedRe: PATCH: to fix jsonb type rendering in runtime (pgAdmin4)
2+ messages / 2 participants
[nested] [flat]
* Re: PATCH: to fix jsonb type rendering in runtime (pgAdmin4)
@ 2016-07-04 03:56 Murtuza Zabuawala <[email protected]>
2016-07-04 09:07 ` Re: PATCH: to fix jsonb type rendering in runtime (pgAdmin4) Dave Page <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Murtuza Zabuawala @ 2016-07-04 03:56 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
Hi Dave,
I'm unable to reproduce the issue mentioned by you on my side, would you please provide console log/error ?
Regards,
Murtuza On 30-Jun-2016 6:26 PM, Dave Page <[email protected]> wrote:
>
> Hi
>
> On Thu, Jun 30, 2016 at 11:37 AM, Murtuza Zabuawala
> <[email protected]> wrote:
> > Hi Dave,
> >
> > PFA updated patch.
> > Tested with json/json[]/jsonb/jsonb[] (on browsers & runtime).
>
> I can't add rows to a table with this patch applied:
>
> 1) Create a table
>
> create table test(id serial primary key, j json, jb jsonb, ja json[],
> jba jsonb[])
>
> 2) Right-click the table in the treeview, and view the data
>
> 3) Click the + button to add a new row
>
> 4) The warning about moving to the last page of results is shown, but
> clicking OK doesn't dismiss the dialogue.
>
> If I remove the patch, everything works again.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: PATCH: to fix jsonb type rendering in runtime (pgAdmin4)
2016-07-04 03:56 Re: PATCH: to fix jsonb type rendering in runtime (pgAdmin4) Murtuza Zabuawala <[email protected]>
@ 2016-07-04 09:07 ` Dave Page <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Dave Page @ 2016-07-04 09:07 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers
Hi
On Mon, Jul 4, 2016 at 4:56 AM, Murtuza Zabuawala
<[email protected]> wrote:
> Hi Dave,
>
> I'm unable to reproduce the issue mentioned by you on my side, would you please provide console log/error ?
Neither can I now - it seems to be working fine so I've committed the patch.
Sorry for the noise!
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2016-07-04 09:07 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-07-04 03:56 Re: PATCH: to fix jsonb type rendering in runtime (pgAdmin4) Murtuza Zabuawala <[email protected]>
2016-07-04 09:07 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox