Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jOPiZ-0001VJ-0v for pgadmin-hackers@arkaria.postgresql.org; Tue, 14 Apr 2020 17:51:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jOPiX-0007Ay-TR for pgadmin-hackers@arkaria.postgresql.org; Tue, 14 Apr 2020 17:51:25 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jOPiX-0007Ar-Nr for pgadmin-hackers@lists.postgresql.org; Tue, 14 Apr 2020 17:51:25 +0000 Received: from twelve.baremetal.com ([67.223.102.253]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jOPiT-0001g5-Pp for pgadmin-hackers@lists.postgresql.org; Tue, 14 Apr 2020 17:51:24 +0000 Received: from Darrens-iMac.local (S01061056117e3190.gv.shawcable.net [24.108.169.135]) by twelve.baremetal.com (8.14.9/8.14.9) with ESMTP id 03EHpGl9018901; Tue, 14 Apr 2020 10:51:17 -0700 Subject: Re: Proposal: Drop support for Internet Explorer To: Dave Page , Neel Patel Cc: Khushboo Vashi , pgAdmin Support , pgadmin-hackers , Akshay Joshi References: <1e6b5a0b-2fc9-1cac-f13a-bcc84f02e00e@darrenduncan.net> <6148f1ed-8eee-931e-06a1-23c64d790cf5@darrenduncan.net> From: Darren Duncan Message-ID: <586bcde8-6d29-a7fc-e25f-6afde302d504@darrenduncan.net> Date: Tue, 14 Apr 2020 10:51:17 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk You have a typo `elif browser != 'chrom'` but otherwise I see no problems with the patch, thank you. -- Darren Duncan On 2020-04-14 7:46 a.m., Dave Page wrote: > Ooops. Thanks for catching that. Here it is. > > On Tue, Apr 14, 2020 at 3:45 PM Neel Patel > wrote: > > Hi Dave, > > Looks like patch is missing in attachment. > > Thanks, > Neel Patel > > > On Tue 14 Apr, 2020, 6:53 PM Dave Page, > wrote: > > Here's an updated patch that gives a slightly different message if the > browser is unknown vs. unsupported/deprecated. As with the previous > patch, the check can be disabled in the config. > > On Fri, Apr 10, 2020 at 5:07 AM Khushboo Vashi > > wrote: > > > > On Thu, Apr 9, 2020 at 11:57 PM Darren Duncan > > wrote: > > The patch looks good as much as I understand it, but this raises > an important > question: > > How should one best handle minority browsers that may be > completely modern but > you may not specifically know about them?  Such as the newer > crop of browsers > that emphasize stronger privacy or may have fewer identifiers? > > While going on a whitelist as the patch essentially does for > known good browsers > is conservative, I feel that an alteration would be good. > > I propose dividing the browsers/environments into 3 categories, > which are > recognized-supported, recognized-unsupported, and unrecognized. > > > So the unsupported older versions of supported browsers get a > stronger message > encouraging a browser switch as they are recognized as > unsupported, while > unrecognized browsers get a different weaker message saying they > weren't > recognized so we can't determine if they'd work; both can point > to the list of > known supported browsers. > > I do agree with this suggestion. > > Related to this, there could be an application toggle that > affects the > unrecognized category where users can basically say, yes I > understand you don't > recognize this browser, please hide the warning, or something > like that. > > Also, it probably goes without saying, but the code/templates > will need to be > structured in such a way that the warning message uses about > plain as possible > HTML so that if the browser doesn't support displaying the UI in > general it can > at least display the message. > > -- Darren Duncan > > On 2020-04-09 4:36 a.m., Dave Page wrote: > > Hi > > > > On Thu, Apr 9, 2020 at 12:26 AM Darren Duncan wrote: > > > >     If its hard to know how many people are actually using > Internet Explorer: > > > >     You could make the next release of pgAdmin display a > message occasionally to > >     users of Internet Explorer saying that Internet Explorer > will no longer be > >     officially supported in a future version, and when that > version comes the > >     message says now no longer supported. > > > >     You can then see how many people contact you about this > to express concern. > > > > > > Good idea. I've hacked up a patch to warn users if they're > using a deprecated or > > unsupported browser. > > > > CCing Akshay for a review :-) > > > > -- > > Dave Page > > Blog: http://pgsnake.blogspot.com > > Twitter: @pgsnake > > > > EnterpriseDB UK: http://www.enterprisedb.com > > The Enterprise PostgreSQL Company > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company