Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ejh3j-0002Bg-Sq for pgadmin-hackers@arkaria.postgresql.org; Thu, 08 Feb 2018 07:55:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ejh3h-0004uQ-FG for pgadmin-hackers@arkaria.postgresql.org; Thu, 08 Feb 2018 07:55:53 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ejh3h-0004uG-72 for pgadmin-hackers@lists.postgresql.org; Thu, 08 Feb 2018 07:55:53 +0000 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ejh3d-000459-7J for pgadmin-hackers@postgresql.org; Thu, 08 Feb 2018 07:55:52 +0000 Received: by mail-wm0-x243.google.com with SMTP id v71so8022103wmv.2 for ; Wed, 07 Feb 2018 23:55:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=mryjcOqxAywre0SmfOwRYOqgEMzDngK9V8fhzIRM1y8=; b=0zjzQeLQ9qB0z32pYXFTAJySLqKrKrPr5RpnEAsjgiB5AgM5NbLZwToFJvZhsOkMGX l5JQVKpHUgHCQW57S79sLnRpThaWTmSY9WVkofHiGKOWuaD2RkFIM21u0hAgQnH0/GVD 5iGSOaEwNa+BuLJfdYazMsY5tFvJcRK2CaquwBiv+5/IQp3ix/kBPX1RVeIYHvPNNnLj 8VrZWcjUh+eFh7QpfeWcjT9SCWLSmGNMZEc9sUKvb6siYzV+iTQM6BIMKoIzdpTeNqgn jeQp6eBY4xre12POVwtt574idgMtzHlqfcgSjJzO96Foa0J5ouktoxeXu0aQbFGzDGNt Y7Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=mryjcOqxAywre0SmfOwRYOqgEMzDngK9V8fhzIRM1y8=; b=A0UhaKpPvj9w7OjJYUMbDoVD5qAIesSbGx5E5Cxc/KTt5qgouLbURiTomvUtkl7ti9 auG3B4BN8Tdf2OznCaxXg3k/2EK+9hxDzslntiewztFCyL+ChEAvsHC/0Z2M4kpapLNL WGrUaQ+9VoQQCYs7DqPCOpSlCOafVmsXJM/1Q32r9zA0uteUTRSnHN+le10XskoqXjhF yb+BY6gKaLo6om9/01C1yGocv/i+7DJ1ajpyVfyJYBzRb1Bfqk5iLONggAbfBKK+k6jJ 3mAXPA9sX6iya92L2WqegFHQxMx3pZ+hVMVt8Lr8eVizbHQ9uhM8Imys+jS+boK7xPV9 k88Q== X-Gm-Message-State: APf1xPDC4WIORQP479j3EERfjIM3ISI07mKt66sh3h9oOPLhHwe8tURn R1g5y1SXAaaUhSOdEOSDyR7v6A== X-Google-Smtp-Source: AH8x227DiHhcvT9Nc+retGHx9m+f+RX/OcMM8t47qIl+J3B+WVlRsZape1uptZI0+rZN6POyqBU/iQ== X-Received: by 10.80.169.116 with SMTP id m49mr324266edc.212.1518076548091; Wed, 07 Feb 2018 23:55:48 -0800 (PST) Received: from [100.83.116.79] ([213.205.198.111]) by smtp.gmail.com with ESMTPSA id x37sm2431664edx.3.2018.02.07.23.55.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Feb 2018 23:55:47 -0800 (PST) Content-Type: multipart/alternative; boundary=Apple-Mail-9DDCBA3B-C563-42DA-8ACA-4D131D00C49D Mime-Version: 1.0 (1.0) Subject: Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed From: Dave Page X-Mailer: iPhone Mail (15C202) In-Reply-To: Date: Thu, 8 Feb 2018 07:55:46 +0000 Cc: pgadmin-hackers Content-Transfer-Encoding: 7bit Message-Id: <7F945741-7C0C-4184-93CA-EAD4598234A3@pgadmin.org> References: To: Joao De Almeida Pereira List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --Apple-Mail-9DDCBA3B-C563-42DA-8ACA-4D131D00C49D Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable It=E2=80=99s in my queue, but I=E2=80=99ve been traveling. I hope to get to i= t later today or tomorrow. --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 7 Feb 2018, at 22:32, Joao De Almeida Pereira wrote: >=20 > Hello, > Any Feedback on this Patch? > We have other changes that we already developed that depend on this change= . >=20 > Thanks >=20 >> On Tue, Feb 6, 2018 at 9:33 AM Joao De Almeida Pereira wrote: >> Hello, >> Any feedback on this Patch? >>=20 >> Thanks >> Joao >>=20 >>> On Fri, Feb 2, 2018 at 5:50 PM Joao De Almeida Pereira wrote: >>> Hi Hackers, >>> This is quite a big patch in order to solve the problem with the Explain= Plan. >>>=20 >>> We sent 2 patches that have the following: >>> - update-javascript-packages.diff=20 >>> Add package: >>> is-docker to select a specific setting when running the Chrome test= s in >>> Docker >>>=20 >>> Upgrade the version of: >>> - babel-loader >>> - extract-text-webpack-plugin >>> - jasmine-core >>> - jasmine-enzyme >>> - moment >>> - explain-plan-greenplum.diff >>> Extract SQLEditor.execute and SQLEditor._poll into their own files and= add test around them >>> Extract SQLEditor backend functions that start executing query to thei= r own files and add tests around it >>> Move the Explain SQL from the front-end and now pass the Explain plan p= arameters as a JSON object in the start query call. >>> Extract the compile_template_name into a function that can be used by t= he different places that try to select the version of the template and the s= erver type >>>=20 >>>=20 >>> Thanks >>> Joao --Apple-Mail-9DDCBA3B-C563-42DA-8ACA-4D131D00C49D Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable It=E2=80=99s in my queue, but I=E2=80=99ve b= een traveling. I hope to get to it later today or tomorrow.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter:= @pgsnake

EnterpriseDB UK:http://www.enterprisedb.com
The Enterpris= e PostgreSQL Company

On 7 Feb 2018, at 22:32, Joao De A= lmeida Pereira <jdealmeid= apereira@pivotal.io> wrote:

Hello,
Any Feedback on this Patch?
We have= other changes that we already developed that depend on this change.

Thanks

On Tue, Feb 6, 2018 at 9:33 AM Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wr= ote:
Hello,
Any f= eedback on this Patch?

Thanks
Joao

O= n Fri, Feb 2, 2018 at 5:50 PM Joao De Almeida Pereira <jdealmeidapereira@pivotal.io= > wrote:
Hi H= ackers,
This is quite a big patch in order to solve the problem with the= Explain Plan.

We sent 2 patches that have the foll= owing:
- update-javascript-packages.diff 
    Add package:
     is-dock= er to select a specific setting when running the Chrome tests in
&= nbsp;    Docker

    Upgrade the= version of:
    - babel-loader
    -= extract-text-webpack-plugin
    - jasmine-core
    - jasmine-enzyme
    - moment
- explain-plan-greenplum.diff
  Extract SQL= Editor.execute and SQLEditor._poll into their own files and add test around t= hem
  Extract SQLEditor backend functions that start executin= g query to their own files and add tests around it
  Move the= Explain SQL from the front-end and now pass the Explain plan parameters as a= JSON object in the start query call.
  Extract the compile_t= emplate_name into a function that can be used by the different places that t= ry to select the version of the template and the server type

<= /div>

Thanks
Joao
<= /div>
= --Apple-Mail-9DDCBA3B-C563-42DA-8ACA-4D131D00C49D--