Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8LXL-0001BY-LT for pgadmin-hackers@arkaria.postgresql.org; Wed, 10 May 2017 06:55:51 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d8LXL-0004jp-6r for pgadmin-hackers@arkaria.postgresql.org; Wed, 10 May 2017 06:55:51 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d8LXK-0004jZ-4T for pgadmin-hackers@postgresql.org; Wed, 10 May 2017 06:55:50 +0000 Received: from mail-wr0-x236.google.com ([2a00:1450:400c:c0c::236]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d8LX8-0007nT-Uc for pgadmin-hackers@postgresql.org; Wed, 10 May 2017 06:55:48 +0000 Received: by mail-wr0-x236.google.com with SMTP id w50so29662093wrc.0 for ; Tue, 09 May 2017 23:55:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=vaGP/LXllCau9FwFNNUkqxX4kF+WrBQ5Z4eORuSt6q8=; b=nsg4ZmEDeZFjobw4WwQf5NrA7aIwt3gAshZ59H+fn7gqd1dTkZx/LzjmaQRSaUCDlC XBiM1MNigJadO5vbUa38HqdHKMvC23NDXhi7Amu9HRxl+EtdJ6Hgu+1QO3ycB1EkV1aB ezWv+E35I61ue6utsQA4QE0pkDvsPpxkC3DJzjVBjERcX1t78HM/6/ATEfLoU1TfBWym u8fQZe+o2MvmRZl1efrmJFqmtMgdJ4NZ9bprpLWI9awJ8g0BkPI983m2WbK9Xkfo0M9y MlWBTDdjmyqe38OdmncpPmgb+EpX3GfPoff5o2Yo2bgBYGyd29Lw2KCDB8BUihhxliGq Zllw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=vaGP/LXllCau9FwFNNUkqxX4kF+WrBQ5Z4eORuSt6q8=; b=eFJ+PRK5Ob05m4QjEkamrw6QQbzFPdQ+M2GdcO7hbdhSUusk5FyNB3j/yjYgohvbJI aIVrWQNRfWI0Jgnk/imVZbhOh4sfP0f3g8F7nKdrxs//8PLqW6qtCD8D21N8WhRg/oXP 1xadChfLAQZhh2A9HMpLjyClNJqZwzjcwCHkdh7eUT+mzefbFJJL9djqQQRtYoFEIwDS LsRwvszhOFGPCIc7q0+7xp83P6ywndsWjLDPDbLH6obU3DTwLKstIm+uE1MtLD360LTg 2udzIXCSoFh3lXLBzm5DuD8UxVtkTobYHbu3eyvECVAPAdRSbiSexqUJX9BlBzQE+HEi nd+g== X-Gm-Message-State: AODbwcB0Srzt5S/4JwoVvuPT+uXjrymZ9j4tsmeTpOpK72qS6xaGZU2D RJZR/mY2IaBWGA== X-Received: by 10.223.161.141 with SMTP id u13mr2378967wru.203.1494399337105; Tue, 09 May 2017 23:55:37 -0700 (PDT) Received: from [100.85.79.160] ([213.205.198.232]) by smtp.gmail.com with ESMTPSA id m12sm2111248wma.20.2017.05.09.23.55.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 May 2017 23:55:36 -0700 (PDT) Content-Type: multipart/alternative; boundary=Apple-Mail-3FBD288B-9C0C-47E5-BA54-737D149A6B77 Mime-Version: 1.0 (1.0) Subject: Re: [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab From: Dave Page X-Mailer: iPhone Mail (14E304) In-Reply-To: Date: Wed, 10 May 2017 07:55:35 +0100 Cc: Akshay Joshi , pgadmin-hackers Content-Transfer-Encoding: 7bit Message-Id: <8A654A56-BC41-46FC-AE7A-5C1F48D07208@pgadmin.org> References: To: Neel Patel X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --Apple-Mail-3FBD288B-9C0C-47E5-BA54-737D149A6B77 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi What happens on a standard QtWebKit if we try to trigger QWebPage::ToggleVid= eoFullscreen + 1? Does it error, or get silently ignored? --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 10 May 2017, at 07:30, Neel Patel wrote: >=20 > Hi, >=20 > Please find attached patch file with the fix of compilation issues with Qt= 4. Tested with both the version of Qt4 and Qt5 webkit and it is working now= . >=20 > As triggerAction code will not be applicable for Qt4 so we made conditiona= l macro for Qt5 version check and for backward compatibility webkit version w= ith Qt5, as in new webkit new enum is added so we have incremented with one t= o previous enum value which will solve the problem with both old and new web= kit. >=20 > Do review it and let me know for any issue. >=20 > Thanks, > Neel Patel >=20 >> On Tue, May 9, 2017 at 3:18 PM, Neel Patel w= rote: >> Hi Dave, >>=20 >>> On Tue, May 9, 2017 at 3:08 PM, Dave Page w= rote: >>> Hi >>>=20 >>>> On Tue, May 9, 2017 at 10:28 AM, Neel Patel wrote: >>>> Hi Dave, >>>>=20 >>>> Here there are 2 compilation issue. We have fixed 'QNetworkCookieJar' r= elated compilation error in Qt4. BUT >>>>=20 >>>> Below compilation error is coming because we have not applied the lates= t patch of webkit which was fixed in annulen/webkit repo which was raised at= below path. >>>>=20 >>>> https://github.com/annulen/webkit/issues/519 >>>>=20 >>>> BrowserWindow.cpp:842:59: error: =E2=80=98RequestClose=E2=80=99 is not a= member of =E2=80=98QWebPage=E2=80=99 >>>> webviewPtr->page()->triggerAction(QWebPage::Re= questClose); >>>>=20 >>>> To fix the above compilation error currently we have two solution. >>>> Apply the given patch in webkit ( qwebpage.cpp & qwebpage.h file ) . >>>> Comment the below line temporary for compilation until we get the relea= ses from annulen/webkit. >>>> webviewPtr->page()->triggerAction(QWebPage::RequestClose= ); >>>>=20 >>>> Other compilation issues, (Me and Akshay) will fix and commit it but ne= ed your input on above issue. >>>=20 >>> For various reasons we need to retain compatibility with the previous ve= rsions of qtwebkit. Can we detect at build time what version we have, and en= able/disable that code as appropriate? >> =20 >> Make sense. We will check if we are getting any webkit version in applic= ation or not and update you. >>=20 >>> =20 >>>>=20 >>>> Thanks, >>>> Neel Patel >>>>=20 >>>>> On Tue, May 9, 2017 at 2:02 PM, Dave Page = wrote: >>>>> It's running CentOS 7.3, with packages from EPEL: >>>>>=20 >>>>> [dpage@jenkins ~]$ rpm -qa |grep qt >>>>> qt5-qtbase-common-5.6.1-10.el7.noarch >>>>> qt5-qtbase-devel-5.6.1-10.el7.x86_64 >>>>> qt-4.8.5-13.el7.x86_64 >>>>> qt5-qtbase-5.6.1-10.el7.x86_64 >>>>> qt5-qtxmlpatterns-5.6.1-10.el7.x86_64 >>>>> qt5-qtwebchannel-5.6.1-10.el7.x86_64 >>>>> qt5-qtwebkit-5.6.1-3.b889f46git.el7.x86_64 >>>>> qt5-qtdeclarative-devel-5.6.1-10.el7.x86_64 >>>>> qt-devel-4.8.5-13.el7.x86_64 >>>>> qt-settings-19-23.5.el7.centos.noarch >>>>> qt5-qtbase-gui-5.6.1-10.el7.x86_64 >>>>> qt5-qtlocation-5.6.1-10.el7.x86_64 >>>>> qt5-qtwebsockets-5.6.1-10.el7.x86_64 >>>>> qt5-qtwebkit-devel-5.6.1-3.b889f46git.el7.x86_64 >>>>> qtwebkit-2.3.4-6.el7.x86_64 >>>>> qt3-3.3.8b-51.el7.x86_64 >>>>> qt5-qtdeclarative-5.6.1-10.el7.x86_64 >>>>> qt5-rpm-macros-5.6.1-10.el7.noarch >>>>> qtwebkit-devel-2.3.4-6.el7.x86_64 >>>>> qt-x11-4.8.5-13.el7.x86_64 >>>>> qt5-qtsensors-5.6.1-10.el7.x86_64 >>>>>=20 >>>>>> On Tue, May 9, 2017 at 9:28 AM, Neel Patel wrote: >>>>>> Hi Dave, >>>>>>=20 >>>>>> Yes, It looks like compilation fails on Qt4. We will fix this issue b= ut which version of Qt4 we are using in Jenkins ? >>>>>>=20 >>>>>> Thanks, >>>>>> Neel Patel >>>>>>=20 >>>>>>> On Tue, May 9, 2017 at 1:56 PM, Dave Page wrote: >>>>>>>=20 >>>>>>>=20 >>>>>>>> On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi wrote: >>>>>>>> Hi >>>>>>>>=20 >>>>>>>>> On Tue, May 9, 2017 at 1:42 PM, Dave Page wrote: >>>>>>>>> This appears to have made Jenkins get all angry and red :-( >>>>>>>>>=20 >>>>>>>>> https://jenkins.pgadmin.org/ >>>>>>>>=20 >>>>>>>> We(Neel and I) have tested it and working fine. =20 >>>>>>>=20 >>>>>>> It clearly doesn't compile on QT4. Please review the Jenkins logs. >>>>>>> =20 >>>>>>>>>=20 >>>>>>>>>=20 >>>>>>>>>> On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi wrote: >>>>>>>>>> Thanks patch applied. >>>>>>>>>>=20 >>>>>>>>>>> On Mon, May 8, 2017 at 3:21 PM, Dave Page wr= ote: >>>>>>>>>>> Akshay, could you review this please? >>>>>>>>>>>=20 >>>>>>>>>>> Thanks. >>>>>>>>>>>=20 >>>>>>>>>>>> On Fri, May 5, 2017 at 11:53 AM, Neel Patel wrote: >>>>>>>>>>>> Hi, >>>>>>>>>>>>=20 >>>>>>>>>>>> Please find attached patch file with the fix of RM #2328 - [Run= time]: Unable to launch query tool and debugger in new browser tab. >>>>>>>>>>>>=20 >>>>>>>>>>>> I have used Qt 5.8 with webkit mentioned in below URL. >>>>>>>>>>>>=20 >>>>>>>>>>>> https://github.com/annulen/webkit/releases >>>>>>>>>>>>=20 >>>>>>>>>>>>=20 >>>>>>>>>>>> As there was a bug in QWebKit regarding "unload" event. We have= raised and also they have provided patch file to fix this issue. I have app= lied the patch in linux and compile the webkit and tested the attached patch= with compiled webkit which is now working fine. >>>>>>>>>>>>=20 >>>>>>>>>>>> Below is the link for reference regarding unload issue. They ha= ve provided test webkit release for Mac in below URL but for other platform w= e need to apply the patch and compile the webkit until they provide webkit-r= eleases for all platforms. >>>>>>>>>>>>=20 >>>>>>>>>>>> https://github.com/annulen/webkit/issues/519 >>>>>>>>>>>>=20 >>>>>>>>>>>> Do review it and let me know in case of any issue. >>>>>>>>>>>>=20 >>>>>>>>>>>> Thanks, >>>>>>>>>>>> Neel Patel >>>>>>>>>>>>=20 >>>>>>>>>>>>=20 >>>>>>>>>>>> -- >>>>>>>>>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgres= ql.org) >>>>>>>>>>>> To make changes to your subscription: >>>>>>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>>>>>>>>=20 >>>>>>>>>>>=20 >>>>>>>>>>>=20 >>>>>>>>>>>=20 >>>>>>>>>>> --=20 >>>>>>>>>>> Dave Page >>>>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>>>> Twitter: @pgsnake >>>>>>>>>>>=20 >>>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>>=20 >>>>>>>>>>=20 >>>>>>>>>>=20 >>>>>>>>>> --=20 >>>>>>>>>> Akshay Joshi >>>>>>>>>> Principal Software Engineer=20 >>>>>>>>>>=20 >>>>>>>>>>=20 >>>>>>>>>>=20 >>>>>>>>>> Phone: +91 20-3058-9517 >>>>>>>>>> Mobile: +91 976-788-8246 >>>>>>>>>=20 >>>>>>>>>=20 >>>>>>>>>=20 >>>>>>>>> --=20 >>>>>>>>> Dave Page >>>>>>>>> VP, Chief Architect, Tools & Installers >>>>>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>=20 >>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>> Twitter: @pgsnake >>>>>>>>=20 >>>>>>>>=20 >>>>>>>>=20 >>>>>>>>=20 >>>>>>>> --=20 >>>>>>>> Akshay Joshi >>>>>>>> Principal Software Engineer=20 >>>>>>>>=20 >>>>>>>>=20 >>>>>>>>=20 >>>>>>>> Phone: +91 20-3058-9517 >>>>>>>> Mobile: +91 976-788-8246 >>>>>>>=20 >>>>>>>=20 >>>>>>>=20 >>>>>>>=20 >>>>>>> --=20 >>>>>>> Dave Page >>>>>>> VP, Chief Architect, Tools & Installers >>>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>>=20 >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>=20 >>>>>=20 >>>>>=20 >>>>>=20 >>>>> --=20 >>>>> Dave Page >>>>> VP, Chief Architect, Tools & Installers >>>>> EnterpriseDB: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>>=20 >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>=20 >>>=20 >>>=20 >>>=20 >>>=20 >>> --=20 >>> Dave Page >>> VP, Chief Architect, Tools & Installers >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>>=20 >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>=20 >=20 > --Apple-Mail-3FBD288B-9C0C-47E5-BA54-737D149A6B77 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Hi

What happens on a standard QtWebKi= t if we try to trigger QWebPage::ToggleVideoFullscreen + 1? Does it error, or get silently= ignored?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitte= r: @pgsnake

EnterpriseDB UK:http://www.enterprisedb.com
The Enterpri= se PostgreSQL Company

On 10 May 2017, at 07:30, Neel Pa= tel <neel.patel@enterprise= db.com> wrote:

Hi,

Please find attached patch file with the fix of= compilation issues with Qt4.  Tested with both the version of Qt4 and Q= t5 webkit and it is working now.

As triggerAction c= ode will not be applicable for Qt4 so we made conditional macro for Qt5 vers= ion check and for backward compatibility webkit version with Qt5, as in new w= ebkit new enum is added so we have incremented with one to previous enum val= ue which will solve the problem with both old and new webkit.

=
Do review it and let me know for any issue.

<= div>Thanks,
Neel Patel

<= div class=3D"gmail_quote">On Tue, May 9, 2017 at 3:18 PM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Dave,

On Tue, May 9, 2017 at 3:08 PM, Dave Page <= span dir=3D"ltr"><dave.page@enterprisedb.com> wrote:
Hi

On Tue, May 9, 2017 at 10:28 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Dave,

Here the= re are 2 compilation issue. We have fixed 'QNetworkCookieJar' related compil= ation error in Qt4. BUT

Below compilation error is c= oming because we have not applied the latest patch of webkit which was fixed= in annulen/webkit repo which was raised at below path.

=

BrowserWindow.cpp:842:59: error: =E2=80=98RequestClose=E2=80=99 i= s not a member of =E2=80=98QWebPage=E2=80=99
      &= nbsp;                  webviewP= tr->page()->triggerAction(QWebPage::RequestClose);

To fix the above compilation error currently we have two so= lution.
  • Apply the given patch in webkit ( qwebpage.cpp &am= p; qwebpage.h file ) .
  • Comment the below line temporary for compilat= ion until we get the releases from annulen/webkit.
  &nbs= p;            webviewPtr->page()->trigge= rAction(QWebPage::RequestClose);

Oth= er compilation issues, (Me and Akshay) will fix and commit it but need your i= nput on above issue.

For v= arious reasons we need to retain compatibility with the previous versions of= qtwebkit. Can we detect at build time what version we have, and enable/disa= ble that code as appropriate?
 = ;
Make sense.  We will check if we are getting any web= kit version in application or not and update you.

 

Thanks,
Neel Patel

On Tue, May 9, 2017 at 2:02 PM, Dave Page <= ;dave.page@e= nterprisedb.com> wrote:
It's running CentOS 7.3, with packages from EPEL:

<= div>
[dpage@jenkins ~]$ rpm -qa |grep qt
qt5-qtbase-common-5.6= .1-10.el7.noarch
qt5-qtbase-devel-5.6.1-10.el7.x86_64
qt-4.8.5-13.el7.x86_64
qt5-qtbase-5.6.1-10.el7.x86_64
qt5-qtxmlpatterns-5.6.1-10.el7.x86_64
qt5-qtwebchannel-= 5.6.1-10.el7.x86_64
qt5-qtwebkit-5.6.1-3.b889f46git.el7.= x86_64
qt5-qtdeclarative-devel-5.6.1-10.el7.x86_64
= qt-devel-4.8.5-13.el7.x86_64
qt-settings-19-23.5.el7.centos.n= oarch
qt5-qtbase-gui-5.6.1-10.el7.x86_64
qt5-qtloca= tion-5.6.1-10.el7.x86_64
qt5-qtwebsockets-5.6.1-10.el7.x= 86_64
qt5-qtwebkit-devel-5.6.1-3.b889f46git.el7.x86_64
<= div>qtwebkit-2.3.4-6.el7.x86_64
qt3-3.3.8b-51.el7.x86_64
qt5-qtdeclarative-5.6.1-10.el7.x86_64
qtwebkit-devel-2.3.4-6.el7.x86_64
qt-= x11-4.8.5-13.el7.x86_64
qt5-qtsensors-5.6.1-10.el7.x86_64

On Tue, May 9, 2017 at 9:28 AM, Neel Patel <= ;neel.patel= @enterprisedb.com> wrote:
Hi Dave,

Yes, It looks like compilation fai= ls on Qt4. We will fix this issue but which version of Qt4 we are using in J= enkins ?

Thanks,
Neel Patel

On Tue, May 9, 2017 at 1:56 PM, Dave= Page <dave.page@enterprisedb.com> wrote:


On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi <= span dir=3D"ltr"><akshay.joshi@enterprisedb.com> wrote:
Hi

=
On Tue, May 9, 2017 at 1:42 PM, Dave Page <= span dir=3D"ltr"><dave.page@enterprisedb.com> wrote:
=
This appears to have made Jenkins get all angry and red :-(=


<= /span>
   We(Neel and I) have tested it and working fine. = ; 

It cl= early doesn't compile on QT4. Please review the Jenkins logs.
 


On T= ue, May 9, 2017 at 8:39 AM, Akshay Joshi <akshay.joshi@enterpris= edb.com> wrote:
Thanks= patch applied.
--
Aks= hay Joshi
Principal Software Engineer 

=

Phone: +91 20-3058-9517
Mobile: <= a href=3D"tel:+91%2097678%2088246" value=3D"+919767888246" target=3D"_blank"= >+91 976-788-8246



--
Dave Page
VP, Chief Architect, Tools & Installers<= br>EnterpriseDB: h= ttp://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake



--
<= div class=3D"m_3646915978052875876m_-4780963339364194306m_221663001140090843= 6m_-2016239111006808430m_-674534015089129385m_-2183617756405375713m_43739387= 61770165468gmail_signature">
Akshay Joshi
Principal Software Engineer&nbs= p;

<= font color=3D"#3333FF">
=



--
Dave Page
VP, Chief Architect, Tools & InstallersEnterpriseDB: ht= tp://www.enterprisedb.com
The Enterprise PostgreSQL Company

Bl= og: http://pgsnake= .blogspot.com
Twitter: @pgsnake




--
<= div class=3D"m_3646915978052875876m_-4780963339364194306m_221663001140090843= 6m_-2016239111006808430gmail_signature" data-smartmail=3D"gmail_signature">D= ave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprised= b.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.comTwitter: @pgsnake



--
Dave Page
VP, Chief Architect, Tools & Installers
Ente= rpriseDB: http://w= ww.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogs= pot.com
Twitter: @pgsnake


<webkit_compile_issue.p= atch>
= --Apple-Mail-3FBD288B-9C0C-47E5-BA54-737D149A6B77--