Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1apZ7l-0001a4-Fr for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 Apr 2016 10:31:17 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1apZ7l-0005x1-32 for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 Apr 2016 10:31:17 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1apZ7k-0005wp-8q for pgadmin-hackers@postgresql.org; Mon, 11 Apr 2016 10:31:16 +0000 Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1apZ7g-0007Wh-UW for pgadmin-hackers@postgresql.org; Mon, 11 Apr 2016 10:31:15 +0000 Received: by mail-wm0-x22e.google.com with SMTP id v188so80289816wme.1 for ; Mon, 11 Apr 2016 03:31:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc:message-id:references :to; bh=500y22PlDaSkm7CO51Vm4GK2/WO8vuhNlFL41Ie35wo=; b=NrN94Vq6ISYu+wrwCa/KjnnECPGodmV3zB5yLNio+ixwky8avTAlEexthVo74b9XMa L6K+wHEn0wRdvi1+y0huJVcqv//JHAnalRFSnV29S/jlHNhgJ6onkVwE6Qy2oxEbq2Sv Zxrh3O+1uRtGEiSIqhwDM1BBmRU4OlUNtAOLR+dUFz6CzIdgQmfNmnFJMpb1FM17+7Fq x6/WYQpZSqQO0kbKzFrwQ9RggM2rH48k7cUVXi0HUg08+hxMByn5uYbwNS3nZTa56KDz HFx44HTqtACNeGC5tVcPL+HtzYENYnMUrLjdHFIImrp4afJp64+ePnx5N5uO6mER85HE smeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=500y22PlDaSkm7CO51Vm4GK2/WO8vuhNlFL41Ie35wo=; b=aDbLFQ62hQflIrRtDrJmy5T4z8xbVlTq1Skjhy6KuiJet5QHL6UQXTBqfXF3h1BSzp HS5ATxjqSMPEn+Hd0iCuMjS3cFZrknDfQhwe7fZQQKP4MCAe2+htucmTxo/9Qg0cPC47 1NdvFb1ZkcsG2mKCtnHVsyvlj4Fd4WJPYEBtz+r4UE2ZchoYfH1fA/poDrwykqr4BFrj QLBsSZY/5XA0+gdDBFpgzwockwQRFqGhofhzfG7nqZdxQXWyclIqmyvV0+gdqt/U2mQO ZoD06ukx4CQE+VlTWYxZ4ZcGu0xAxfmwozHWYWVyPanEBdsf+Q56UOvoIAunmAiaXX9U FJhQ== X-Gm-Message-State: AD7BkJJUrl2McZpds54JTm0aeUwPNQDwCaAHJrO8Na0onbA1a8Ew2DqmBOk577EeAuoWJYql X-Received: by 10.28.53.134 with SMTP id c128mr17986524wma.10.1460370671230; Mon, 11 Apr 2016 03:31:11 -0700 (PDT) Received: from [172.16.1.31] ([194.73.70.210]) by smtp.gmail.com with ESMTPSA id m134sm16648754wmd.14.2016.04.11.03.31.10 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 11 Apr 2016 03:31:10 -0700 (PDT) Content-Type: multipart/alternative; boundary="Apple-Mail=_E3BCCFC2-DF56-4C94-86F5-131754AA54FA" Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: Styling SQL box layout on dialogue From: Arun Kollan In-Reply-To: <69DBED24-ECF2-48A2-94F9-EEED5BAF8C63@enterprisedb.com> Date: Mon, 11 Apr 2016 11:31:09 +0100 Cc: "pgadmin-hackers@postgresql.org" Message-Id: <8AFA3AC4-2552-4547-80D5-50981C31EE7E@enterprisedb.com> References: <69DBED24-ECF2-48A2-94F9-EEED5BAF8C63@enterprisedb.com> To: Dave Page X-Mailer: Apple Mail (2.2104) X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --Apple-Mail=_E3BCCFC2-DF56-4C94-86F5-131754AA54FA Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Hi Dave, Please find attached the zipped version of the patch. I have tested it = against the latest version from the repository. I had quick look = comparing the patches and it looks to contain the same rules.=20 Regards, Arun Kollan Website: www.enterprisedb.com EnterpriseDB Blog: http://blogs.enterprisedb.com/ = Follow us on Twitter: http://www.twitter.com/enterprisedb = This e-mail message (and any attachment) is intended for the use of the = individual or entity to whom it is addressed. This message contains = information from EnterpriseDB Corporation that may be privileged, = confidential, or exempt from disclosure under applicable law. If you are = not the intended recipient or authorized to receive this for the = intended recipient, any use, dissemination, distribution, retention, = archiving, or copying of this communication is strictly prohibited. If = you have received this e-mail in error, please notify the sender = immediately by reply e-mail and delete this message. > On 11 Apr 2016, at 10:45, Arun Kollan = wrote: >=20 > Hi Dave, > Looks the like the patch is out of sync with the repository. I will = create another patch now.=20 >=20 > Regards, > Arun Kollan > Website: www.enterprisedb.com > EnterpriseDB Blog: http://blogs.enterprisedb.com/ = > Follow us on Twitter: http://www.twitter.com/enterprisedb = >=20 > This e-mail message (and any attachment) is intended for the use of = the individual or entity to whom it is addressed. This message contains = information from EnterpriseDB Corporation that may be privileged, = confidential, or exempt from disclosure under applicable law. If you are = not the intended recipient or authorized to receive this for the = intended recipient, any use, dissemination, distribution, retention, = archiving, or copying of this communication is strictly prohibited. If = you have received this e-mail in error, please notify the sender = immediately by reply e-mail and delete this message. >=20 >=20 >=20 >=20 >> On 11 Apr 2016, at 10:09, Dave Page > wrote: >>=20 >> On Fri, Apr 8, 2016 at 2:23 PM, Arun Kollan >> > = wrote: >>> Hi Team, >>>=20 >>> please find attached the patch for styling the sql editor on a = dialogue >>> window. The separate rule has been written to include the style = specific to >>> a control window. >>=20 >> There still seem to be padding/margin issues on my machine (under >> Chrome). Am I missing something? >>=20 >> --=20 >> Dave Page >> VP, Chief Architect, Tools & Installers >> EnterpriseDB: http://www.enterprisedb.com = >> The Enterprise PostgreSQL Company >>=20 >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >=20 --Apple-Mail=_E3BCCFC2-DF56-4C94-86F5-131754AA54FA Content-Type: multipart/mixed; boundary="Apple-Mail=_68CC18C5-391F-4323-A76D-2EF55459E922" --Apple-Mail=_68CC18C5-391F-4323-A76D-2EF55459E922 Content-Transfer-Encoding: 7bit Content-Type: text/html; charset=us-ascii Hi Dave,
 Please find attached the zipped version of the patch. I have tested it against the latest version from the repository.  I had quick look comparing the patches and it looks to contain the same rules. 
--Apple-Mail=_68CC18C5-391F-4323-A76D-2EF55459E922 Content-Disposition: attachment; filename=sql-box-layout-stylingv2.patch Content-Type: application/octet-stream; name="sql-box-layout-stylingv2.patch" Content-Transfer-Encoding: 7bit diff --git a/web/pgadmin/static/css/overrides.css b/web/pgadmin/static/css/overrides.css index 16f7f0a..16ea37a 100755 --- a/web/pgadmin/static/css/overrides.css +++ b/web/pgadmin/static/css/overrides.css @@ -276,6 +276,11 @@ iframe { padding-right: 3px; padding-left: 3px; } +.pgadmin-controls.SQL { + min-width: 290px; + padding-right: 3px; + padding-left: 1px; +} .pgadmin-controls > textarea.form-control, .pgadmin-controls > textarea.form-control[disabled] { min-width: 100%; @@ -855,11 +860,20 @@ td.edit-cell.editable.sortable.renderable.editor { } .sql_field_height_300 { - height: 300px; + height: 340px; } .sql_field_height_400 { - height: 400px; + height: 440px; +} + +.tab-pane.SQL { + padding: 0px 7px 0px 0px; +} + +.pgadmin-control-group.sql { + margin: 0px; + padding: 0px; } .nav-tabs{ @@ -929,3 +943,7 @@ ul.nav.nav-tabs { .pgadmin-control-group span.wcTabIcon { padding-left: 20px; } + +.pgadmin-controls.SQL>.CodeMirror { + height: 500px!important; +} diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js index 8eaed6d..0f7edc8 100644 --- a/web/pgadmin/static/js/backform.pgadmin.js +++ b/web/pgadmin/static/js/backform.pgadmin.js @@ -519,7 +519,7 @@ ' id="<%=hId%>" aria-controls="<%=cId%>">', '<%=label%>'].join(" ")), 'panel': _.template( - '
' + '
' )}, render: function() { this.cleanup(); @@ -1307,7 +1307,7 @@ var SqlTabControl = Backform.SqlTabControl = Backform.Control.extend({ defaults: { label: "", - controlsClassName: "pgadmin-controls col-sm-12", + controlsClassName: "pgadmin-controls col-sm-12 SQL", extraClasses: [], helpMessage: null }, --Apple-Mail=_68CC18C5-391F-4323-A76D-2EF55459E922 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii

Regards,

Arun Kollan
Website: www.enterprisedb.com
EnterpriseDB Blog: http://blogs.enterprisedb.com/
Follow us on = Twitter: http://www.twitter.com/enterprisedb

This e-mail = message (and any attachment) is intended for the use of the individual = or entity to whom it is addressed. This message contains information = from EnterpriseDB Corporation that may be privileged, confidential, or = exempt from disclosure under applicable law. If you are not the intended = recipient or authorized to receive this for the intended recipient, any = use, dissemination, distribution, retention, archiving, or copying of = this communication is strictly prohibited. If you have received this = e-mail in error, please notify the sender immediately by reply e-mail = and delete this message.




On 11 Apr 2016, at 10:45, Arun Kollan <arun.kollan@enterprisedb.com> wrote:

Hi Dave,
 Looks the like the patch is out of sync with the = repository. I will create another patch now. 

Regards,
Arun Kollan
Website: www.enterprisedb.com
EnterpriseDB Blog: http://blogs.enterprisedb.com/
Follow us on = Twitter: http://www.twitter.com/enterprisedb

This e-mail = message (and any attachment) is intended for the use of the individual = or entity to whom it is addressed. This message contains information = from EnterpriseDB Corporation that may be privileged, confidential, or = exempt from disclosure under applicable law. If you are not the intended = recipient or authorized to receive this for the intended recipient, any = use, dissemination, distribution, retention, archiving, or copying of = this communication is strictly prohibited. If you have received this = e-mail in error, please notify the sender immediately by reply e-mail = and delete this message.




On 11 Apr 2016, at 10:09, Dave Page <dave.page@enterprisedb.com> wrote:

On Fri, Apr 8, 2016 = at 2:23 PM, Arun Kollan
<arun.kollan@enterprisedb.com> wrote:
Hi Team,
please find attached the patch for styling the sql editor on = a dialogue
window.  The separate rule has been = written to include the style specific to
a control = window.

There still seem to be = padding/margin issues on my machine (under
Chrome). Am I = missing something?

--
Dave = Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise = PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: = @pgsnake
<Screen Shot 2016-04-11 at = 10.07.08.png>


= --Apple-Mail=_68CC18C5-391F-4323-A76D-2EF55459E922-- --Apple-Mail=_E3BCCFC2-DF56-4C94-86F5-131754AA54FA--