Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPxvA-0005t3-50 for pgadmin-hackers@arkaria.postgresql.org; Tue, 27 Jun 2017 21:21:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPxv9-000238-JL for pgadmin-hackers@arkaria.postgresql.org; Tue, 27 Jun 2017 21:21:15 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dPxv9-00022x-FF for pgadmin-hackers@lists.postgresql.org; Tue, 27 Jun 2017 21:21:15 +0000 Received: from mail-qk0-x22b.google.com ([2607:f8b0:400d:c09::22b]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1dPxv1-00037n-Gp for pgadmin-hackers@postgresql.org; Tue, 27 Jun 2017 21:21:14 +0000 Received: by mail-qk0-x22b.google.com with SMTP id d78so36258922qkb.1 for ; Tue, 27 Jun 2017 14:21:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Fj2EUUXx1UuK7hvvQCq1XuHS1qzUE9JtCUikB+M0wwc=; b=bnfqcXoH2UWfZzv6D6o9h/FBYzXxSA+gZ0aphPwNyvyQkrasfore53cH0mrx7D8Ykb c68WrIy3FAd/+Ng5UhTVvAkoxyvvsvhgQHEliu09JBlulBAuvDQ37U4Q3ZOnW2mBsmVo 1RNcCRP7AlIW5vUGCNPM1KogIsWGlXPCzoo0LE8aim4auVljlRdKfZCgwBtX/982Iif6 vuZayDk/XjAX7YKBm55A54E7ljnS6u34RtMQWSdC3SCu6w6SnqOMWdS+zlIA45CdCsi3 YzkXKBobXaPoDNNmw/SprdI36MtNnGRayarJ/MHO0z87CuloPSbsZH65zlxdZVCiNYAs dQ4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Fj2EUUXx1UuK7hvvQCq1XuHS1qzUE9JtCUikB+M0wwc=; b=K0alcjeWC3I1UJ+xc+toUyiq1+DN2L3g9t5qyJjC37Q5KVUHaxnBCssyOnVRjbnH0v 9YsH9Vd+Jlhb7BWHebd5Cld8f9VGjn8tfYf7devt6+AjW2z5gynp7gkTWDiFFZDrl+iP k0y+n/AdBjzcQ2jKt6AyCBGTnCvqsP9Uzf4KqFBKaXv8BI1/vsPER8lZpVO/JIQkGJlP 2WuD5242ly7LlF449cApD+/NzE3FTsfjfJe6DKnHhKaaQzzZFDGpKKEEWkCUbPwfK5rs jA8/uEiD0rql8pqNh8Gg5DEkGoxzsg/O8rI/62odSVwk/AZuDGWKLpPU2OEEuOtOmPme ZMyA== X-Gm-Message-State: AKS2vOxVfrpJ/RLRRuEpfUSUQxfc/eoQe5MLigHa7K9nzkkk/qFOuik6 p8E/6lJyt60bqgZ7 X-Received: by 10.55.183.129 with SMTP id h123mr8490621qkf.75.1498598466006; Tue, 27 Jun 2017 14:21:06 -0700 (PDT) Received: from [172.19.0.10] (173-13-121-41-NewEngland.hfc.comcastbusiness.net. [173.13.121.41]) by smtp.gmail.com with ESMTPSA id 55sm311024qtz.9.2017.06.27.14.21.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Jun 2017 14:21:05 -0700 (PDT) Content-Type: multipart/alternative; boundary=Apple-Mail-38F3B2C0-2192-4F25-913E-73B2479879E8 Mime-Version: 1.0 (1.0) Subject: Re: [pgadmin-hackers] Re: Server side cursor limitations for on demand loading of data in query tool [RM2137] [pgAdmin4] From: Dave Page X-Mailer: iPhone Mail (14F89) In-Reply-To: Date: Tue, 27 Jun 2017 17:21:03 -0400 Cc: Joao Pedro De Almeida Pereira , pgadmin-hackers , Ashesh Vashi , Harshal Dhumal , Shirley Wang Content-Transfer-Encoding: 7bit Message-Id: <8DF0D741-B6C9-4D36-A963-8B9AD34E520B@pgadmin.org> References: To: Robert Eckhardt List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Unsubscribe: , List-Archive: Precedence: bulk --Apple-Mail-38F3B2C0-2192-4F25-913E-73B2479879E8 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable > On 27 Jun 2017, at 17:18, Robert Eckhardt wrote: >=20 >=20 >=20 >> On Tue, Jun 27, 2017 at 5:03 PM, Joao Pedro De Almeida Pereira wrote: >> Hello Hackers, >>=20 >> When we started the app we noticed some change in the front end. >>=20 >> The line numbers in the Editor:=20 >> - We noticed a bug with the numbers where at 10000 rows, the numbers woul= d be cut off. >> - When the row is selected the color of the text should be white=20 >> - Centering the number column would differentiate it from the rest of the= table and prevent any confusion >>=20 >=20 > Do we want line numbers? I'm of mixed opinion. On the one hand it implies a= nd ordered set of results when Postgres inherently doesn't order results. On= the other hand it nicely tells you where you are in the results set if you a= re scrolling around.=20 Yes, they are incredibly useful.= --Apple-Mail-38F3B2C0-2192-4F25-913E-73B2479879E8 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable


On 27 Jun 2017, at 17:18, Robe= rt Eckhardt <reckhardt@pivotal.io= > wrote:


=

On Tue, Jun 27, 20= 17 at 5:03 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pi= votal.io> wrote:
Hello Hackers,

When we started the app we noticed so= me change in the front end.

The line numbers in the= Editor: 
- We noticed a bug with the numbers where at 10000 r= ows, the numbers would be cut off.
- When the row is selected the c= olor of the text should be white 
- Centering the number colu= mn would differentiate it from the rest of the table and prevent any confusi= on


Do we want lin= e numbers? I'm of mixed opinion. On the one hand it implies and ordered set o= f results when Postgres inherently doesn't order results. On the other hand i= t nicely tells you where you are in the results set if you are scrolling aro= und. 

Yes, they are incredibly useful.
= --Apple-Mail-38F3B2C0-2192-4F25-913E-73B2479879E8--