To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
From: Sander Eikelenboom <linux@eikelenboom.it>
Subject: [PATCH] Fix error on displaying table properties of a table
 partitioned by list having a default partition.
Message-ID: <8ff576c5-05ce-5514-7aba-94228d2765c8@eikelenboom.it>
Date: Mon, 13 May 2019 10:58:55 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="------------77DC005F399528FE819B2F8F"
Content-Language: en-US
Precedence: bulk

This is a multi-part message in MIME format.
--------------77DC005F399528FE819B2F8F
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

L.S.,

This patch fixes an error on displaying table properties of a table partitioned by list having a default partition.
This is an additional fix for bug #3938 which was missed in commit a9d964b5ca04bbe00bf5585d5c19bdfdf603c8a9.

--
Sander Eikelenboom

--------------77DC005F399528FE819B2F8F
Content-Type: text/x-patch;
 name="fix-table-properties-display.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="fix-table-properties-display.diff"

commit 3d1a09a1b6bc0651801c91dae071bf8a19d61558
Author: Sander Eikelenboom <sander@eikelenboom.it>
Date:   Mon May 13 10:51:10 2019 +0200

    Fix error on displaying table properties of a table partitioned by list having a default partition.
    This is an additional fix for bug #3938 which was missed in commit a9d964b5ca04bbe00bf5585d5c19bdfdf603c8a9.

diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py
index 7815b325..dffec879 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py
@@ -2203,14 +2203,20 @@ class BaseTableView(PGChildNodeView, BasePartitionTable):
                         'is_default': is_default
                     })
                 elif data['partition_type'] == 'list':
-                    range_part = \
-                        row['partition_value'].split('FOR VALUES IN (')[1]
+                    if row['partition_value'] == 'DEFAULT':
+                        is_default = True
+                        range_in = None
+                    else:
+                        range_part = row['partition_value'].split(
+                            'FOR VALUES IN (')[1]
+                        range_in = range_part[:-1]
+                        is_default = False
 
-                    range_in = range_part[:-1]
                     partitions.append({
                         'oid': row['oid'],
                         'partition_name': partition_name,
-                        'values_in': range_in
+                        'values_in': range_in,
+                        'is_default': is_default
                     })
                 else:
                     range_part = row['partition_value'].split(

--------------77DC005F399528FE819B2F8F--