Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH] Tables node (pgAdmin4)
From: Dave Page <dpage@pgadmin.org>
In-Reply-To: 
 <CAA-aLv7fzZnxRhwV6umxhA-k52YekWyi7t1F34aPpUXR+41tjg@mail.gmail.com>
Date: Thu, 28 Apr 2016 09:52:59 +0100
Cc: Harshal Dhumal <harshal.dhumal@enterprisedb.com>,
 pgadmin-hackers <pgadmin-hackers@postgresql.org>,
 Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>,
 Surinder Kumar <surinder.kumar@enterprisedb.com>,
 Arun Kollan <arun.kollan@enterprisedb.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <921AFBF6-CB51-4898-B5F5-73CE38311399@pgadmin.org>
References: 
 <CAKKotZRCf07F_SGHi4KawBtLHPSeKz5Uvzwu6ddQ=bKc1FDRRw@mail.gmail.com>
 <CAFiP3vw61T0n--F4vYXALdtrkBKznBegBPq5Ds=6uZrg02vWXQ@mail.gmail.com>
 <CAA-aLv7fzZnxRhwV6umxhA-k52YekWyi7t1F34aPpUXR+41tjg@mail.gmail.com>
To: Thom Brown <thom@linux.com>
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org


> On 27 Apr 2016, at 13:43, Thom Brown <thom@linux.com> wrote:
>=20
> On 27 April 2016 at 10:22, Harshal Dhumal
> <harshal.dhumal@enterprisedb.com> wrote:
>>=20
>> Hi,
>>=20
>> PFA attached patches for table node and all table child nodes.
>>=20
>> This patch includes below nodes,
>>=20
>> 1) Table node                              -- Initial patch by Murtuza, =
constraints compatibility by Harshal.
>> 2) Column node                           -- by Murtuza.
>> 3) Index node                              -- by Murtuza.
>> 4) Trigger node                            -- by Murtuzz.
>> 6) Rules node                              -- by Surinder.
>> 7) Constraints nodes:
>>      i]  Index Constraint                 -- Initial patch by Harshal, I=
ntegration with table node by Murtuza.
>>      ii] Foreign key                        -- Initial patch and Integra=
tion with table node by Harshal.
>>      iii] Check constraint                -- Initial patch and Integrati=
on with table node by Harshal.
>>      iv] Exclusion constraint           -- Initial patch and Integration=
 with table node by Harshal.
>>=20
>> Please apply patches in following order as all of them depends on each o=
ther.
>>=20
>> Order:  Table Node ----> Index constraint ---> remaining patches in any =
order.
>=20
> Nice work.  Here's some initial feedback from a very quick play around.
>=20
> On the Create table editor, in the Advance tab (which should probably
> be labelled "Advanced"), the Like section should grey out the "With *"
> values if no relation is selected in the drop-down box.
>=20
> The way primary keys are defined are kinda awkward.  It might be
> useful to provide some kind of checkbox on the initial column list
> that tells it which columns are involved in the primary key, then the
> user could just select which ones they want.  If they want to refine
> it, they could edit it in the Constraints > Primary Key section.

If the design we did has been properly followed (I can't check right now), =
then that's exactly how it should be working. Harshal?

Arun Kollan and I spent a lot of time redesigning the table dialogue to mak=
e it as quick and efficient to use as possible. There will likely be minor =
deviations from that design to ensure consistency with the way other parts =
of the app have turned out, but the basic principles should be there.

>=20
> I'm getting weird spacing in the SQL output.  Here's an example:
>=20
> CREATE UNLOGGED TABLE public.test
> (
>    id integer COLLATE pg_catalog."de_DE.utf8" NOT NULL DEFAULT -1,
>    stuff text COLLATE pg_catalog."C.UTF-8" DEFAULT "hello",
>    CONSTRAINT pk PRIMARY KEY (id, stuff) WITH (FILLFACTOR=3D33) DEFERRABLE
> )
> WITH (
>    OIDS =3D TRUE,
>    FILLFACTOR =3D 88,
>    autovacuum_enabled =3D TRUE,
>    autovacuum_analyze_scale_factor =3D 0.33,
>    autovacuum_analyze_threshold =3D 30,
>    autovacuum_freeze_max_age =3D 3333333,
>    autovacuum_vacuum_cost_delay =3D 30,
>    autovacuum_vacuum_cost_limit =3D 3,
>    autovacuum_vacuum_scale_factor =3D 0.33,
>    autovacuum_vacuum_threshold =3D 33,
>    autovacuum_freeze_min_age =3D 3300000,
>    autovacuum_freeze_table_age =3D 333000000
> )
> TABLESPACE pg_default;
>=20
> ALTER TABLE public.test
>    OWNER to thom;
> GRANT ALL ON TABLE public.test TO thom;
>=20
>=20
> COMMENT ON TABLE public.test
>    IS 'This is just a test table';
>=20
> COMMENT ON COLUMN public.test.id
>    IS 'the main ID';
>=20
> ALTER TABLE public.test
>    ALTER COLUMN id
>    SET (n_distinct=3D'0.2');
> COMMENT ON CONSTRAINT pk ON public.test
>    IS 'primary key test'
>=20
> Note there are 2 blank lines after the GRANT ALL ON TABLE line, and
> none before the COMMENT ON CONSTRAINT line.
>=20
> This SQL fails because collations aren't allowed on integer columns,
> and the DEFAULT value for the column named stuff doesn't quote it as a
> string literal, so it's looking for a column called "hello".
>=20
> There's also no way to view the autovacuum options I defined other
> than the SQL pane.
>=20
> Thom
>=20
>=20
> --=20
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers


--=20
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers