Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bHmCa-0006tl-N2 for pgadmin-hackers@arkaria.postgresql.org; Tue, 28 Jun 2016 06:08:52 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bHmCZ-00020Q-RP for pgadmin-hackers@arkaria.postgresql.org; Tue, 28 Jun 2016 06:08:51 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bHmCY-00020H-Ud for pgadmin-hackers@postgresql.org; Tue, 28 Jun 2016 06:08:51 +0000 Received: from mail-pa0-x235.google.com ([2607:f8b0:400e:c03::235]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bHmCQ-00035j-SV for pgadmin-hackers@postgresql.org; Tue, 28 Jun 2016 06:08:49 +0000 Received: by mail-pa0-x235.google.com with SMTP id hl6so3147694pac.2 for ; Mon, 27 Jun 2016 23:08:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=L3IZap2+/NJlWyy18XyHLVOe0Z/0EUmvzY9xekvFvP4=; b=gVNRazifes3l+2BT5MyNduvuAlh9glxLWb8L43BFpFJllJvEefJlXKFAy1pjyBbr7v TBvAu8lkRu334pI+53MiKycciopDB2EYI8hjog75SZeQZU+sjwrThA0aWcRii44Mi49V 6DNaxyb3erMTuAFB8nlaiCfhKuLlXopRO2o+NP1Di3WSsQ/eNzEV0e/LlTX2lJMtcHpD CD1INLBecm3G/WPeWvRge8aILSAz+WCmd4ea+CBdsHTEzK329DHyzX2moiHDN5T3qe0O 2unuey9u7VQ9MeSlOfQ1avv66d0n4qk7ttGxu3/EyUwzgbXnfUrDt96MaF2JoXoItS1b Qxxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=L3IZap2+/NJlWyy18XyHLVOe0Z/0EUmvzY9xekvFvP4=; b=gDXLgicFP+Y6FDAn4whr1aSe/Iq0M/OHDcQVsWCLyoG1j8bO6NuQ+QPlN1gIPNWtRq 3vfrLmsQHeVdywQ75sEflHQL+4kqvSKiAkmKKqW9rbOggB0LJ6Y3dAg/+jRA4U4rpqRg Vr1ZPcpQUQN/w1rLFkHHAmquBWUzpJsdq9IGMOL4vHy9pQHYlRS3Y/H83VJDYfdoLo0i 90LXunM7dWvVMjVXlGJtooPLOdftvNByWpmrmlaRQszXx4MjpSl30eFWLizrfUfzjlAp Hk4K/rnn6/RHQnR97CReHaQNqSm2hwv3e08yMkogITo3zZZ4Ldf/HXKuP9uvIQ+lC0gr 7I/g== X-Gm-Message-State: ALyK8tKX33HIdNYFe1mbtKpyNtLfs04eC7JnKVddICZs4beQRDMN2E5cx9KKjtUGNrdvO7tL X-Received: by 10.66.80.3 with SMTP id n3mr1974154pax.92.1467094121548; Mon, 27 Jun 2016 23:08:41 -0700 (PDT) Received: from [172.24.35.232] ([59.162.78.200]) by smtp.gmail.com with ESMTPSA id i187sm3673072pfc.62.2016.06.27.23.08.40 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 27 Jun 2016 23:08:41 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: PATCH: Fix the issue for saving query output as CSV From: Murtuza Zabuawala In-Reply-To: Date: Tue, 28 Jun 2016 11:38:38 +0530 Cc: pgadmin-hackers Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Dave Page X-Mailer: Apple Mail (2.2104) X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org Hi Dave, Yes, Safari is exception case because it does not support download attribut= e of hyperlink element. Ref: http://caniuse.com/#feat=3Ddownload I was not able to find any workaround for Safari as of now that=E2=80=99s i= s why I mentioned only Firefox & IE in my last email,=20 Earlier it was only working on Chrome and with this patch it will work with= Chrome/Firefox/IE. Regards, Murtuza > On 27-Jun-2016, at 9:35 pm, Dave Page wrote: >=20 > Hi >=20 > On Mon, Jun 27, 2016 at 1:08 PM, Murtuza Zabuawala > wrote: >> Hi, >>=20 >> PFA patch to fix the issue for downloading query output as CSV not worki= ng >> in Firefox & IE. >> Also fixes the issue that HTML tags were also appended in columns title = in >> CSV header. >>=20 >> Browser side fix for -> RM#1405 >=20 > This works on Firefox and Chrome, but on Safari, clicking the button > does nothing. >=20 >=20 > --=20 > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake >=20 > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company --=20 Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers