public inbox for [email protected]  

help / color / mirror / Atom feed

From: Pravesh Sharma <[email protected]>
To: Usman Khan <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Regarding issue #6510
Date: Wed, 21 May 2025 10:04:20 +0530
Message-ID: <CA+36bxEwRMDowuJWWrx-NafLt5Zn1OELXOC__2PS2eeHkhqc5Q@mail.gmail.com> (raw)
In-Reply-To: <CANVC+REM0hR3gRjFx-SJKAoBJ5tYXsydimoAwBq+mP6rYUzNsA@mail.gmail.com>
References: <CA+36bxGb7qik5gphraXht9gVpRuWV1ttEB8F5sptW3WTq6SOrw@mail.gmail.com>
	<CANVC+REM0hR3gRjFx-SJKAoBJ5tYXsydimoAwBq+mP6rYUzNsA@mail.gmail.com>

Hi Usman,

The length is in the number of characters. So, if a user sets max length
500 then we will show data till 500 characters.

Thanks,
Pravesh

On Tue, May 20, 2025 at 9:08 PM Usman Khan <[email protected]> wrote:

> Hi Pravesh,
> Nice idea from your side but my concern is:
>
>    - If the user increases this limit to 1GB(which is a maximum size for
>    a column in pg) through the *'Max column data display length'* option,
>    will the function not break again?
>
>
> On Tue, May 20, 2025 at 10:16 AM Pravesh Sharma <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> I am working on issue #6510
>> <https://github.com/pgadmin-org/pgadmin4/issues/6510;, where the result
>> grid slows down and sometimes hangs when large JSON or text data is present
>> in a table column. Upon investigation, I found that this is due to
>> rendering the entire JSON to the DOM. This causes slowness, especially with
>> large datasets; for example, rendering a 15MB JSON object for preview
>> purposes is unnecessary. I am proposing a solution where the result grid
>> will render data up to a certain length. I have implemented these changes,
>> and everything is working fine, resulting in a significant performance
>> improvement. As you can see in the screenshot, the JSON data is 20MB, and
>> on the result grid, we are displaying only 200 characters as it is only a
>> preview. I am also considering making this maximum display length a user
>> preference, named "Max column data display length," allowing them to
>> customize how much data they want to see. Can you tell me what you think of
>> this approach or if you have any suggestions?
>>
>>
>> Thanks,
>>
>> Pravesh
>>
>> [image: image.png]
>> --
>>
>>
>> Pravesh Sharma
>>
>> Senior SDE
>>
>> +91 9406461406
>>
>>
>> enterprisedb.com
>>
>


Attachments:

  [image/png] image.png (170.3K, 3-image.png)
  download | view image

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Regarding issue #6510
  In-Reply-To: <CA+36bxEwRMDowuJWWrx-NafLt5Zn1OELXOC__2PS2eeHkhqc5Q@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox