MIME-Version: 1.0
In-Reply-To: 
 <CAM5-9D_J_3fBVDw0gsd5V6uMQ=WNOOJSokgrvMVmkUbL7gUyNg@mail.gmail.com>
References: 
 <CAM5-9D8ExeecjY6Mk7iZ_ZFs+iyLr1-6QtJR0djYvSO_65NtEw@mail.gmail.com>
 <CA+OCxoy+NzJ+LJj4hqunCXprx0XpK7xZX975QOwXj+o32XEHYA@mail.gmail.com>
 <CAM5-9D_qJN6GfLCdgpDr=fv4Ss+M17WnC2qFvnJK-4EPNAyXww@mail.gmail.com>
 <CA+OCxowu8GSWiM=T3oAGZgcp7XVQG5pzuO=djU-zCDfV-ka=YA@mail.gmail.com>
 <CAM5-9D9A_hcssJ62RUeihYfTMY4zopqRsKioih5w5xd-e9FuKw@mail.gmail.com>
 <CAM5-9D_J_3fBVDw0gsd5V6uMQ=WNOOJSokgrvMVmkUbL7gUyNg@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Mon, 8 Aug 2016 15:48:16 +0100
Message-ID: 
 <CA+OCxow-GzqDTv-+fos+_7WRf7sMsqJVN=SpKdc7N1Lc-6K4Eg@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch]: RM#1478 - Make code mirror
 text editor keyboard shortcuts consistent irrespective of platform type
To: Surinder Kumar <surinder.kumar@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Thanks, applied with minor changes per our discussion on skype.

On Mon, Aug 8, 2016 at 2:34 PM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi Dave,
>
> This patch contains following changes:
>
> Add "editor_shortcut_keys" variable to pgAdmin.Browser in browser.js object
> to make it accessible to all pgAdmin modules.
> Apply shortcuts keys to following code mirror instances:
>
>            a) Query tool, Query filter & Datagrid.
>            b) Debugger tool.
>            c) Sql Panel.
>            d) SqlTab & SqlField Controls.
>
> Please find updated patch and review.
>
> On Mon, Aug 8, 2016 at 5:53 PM, Surinder Kumar
> <surinder.kumar@enterprisedb.com> wrote:
>>
>> On Mon, Aug 8, 2016 at 5:52 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>
>>> On Mon, Aug 8, 2016 at 1:15 PM, Surinder Kumar
>>> <surinder.kumar@enterprisedb.com> wrote:
>>> > On Mon, Aug 8, 2016 at 4:43 PM, Dave Page <dpage@pgadmin.org> wrote:
>>> >>
>>> >> Hi Surinder,
>>> >>
>>> >> This looks very promising, but it only covers the query tool at
>>> >> present. We need the shortcuts to apply to all codemirror instances.
>>> >> Do the others work anyway, because we're invoking in a different way,
>>> >> or is more work needed there?
>>> >
>>> > To apply the same shortcuts to other codemirror instances(e.g:
>>> > SqlTabControl) we just need to set a parameter
>>> > extraKeys: pgAdmin.editor_shortcut_keys for every codemirror instance.
>>> > As of now, shortcuts are applicable to query tool & data filter.
>>> >
>>> > Also, we need to define pgAdmin.editor_shortcut_keys variable in
>>> > server.js
>>> > instead of sqleditor.js to work it for
>>> > other code mirror instances.
>>>
>>> OK, please update the patch to do that.
>>>
>>> Can you get that to me in the next hour or so? I'd like to include it in
>>> beta 4.
>>
>> Sure.
>>>
>>>
>>> >> On Fri, Aug 5, 2016 at 6:42 PM, Surinder Kumar
>>> >> <surinder.kumar@enterprisedb.com> wrote:
>>> >> > Hi
>>> >> >
>>> >> > I found that Code-mirror library itself provides the List of
>>> >> > keyboard
>>> >> > shortcuts for Mac OSX and other platform type.
>>> >> > We just need to pass them in extraKeys param while creating
>>> >> > code-mirror
>>> >> > instance.
>>> >> >
>>> >> > Following is the keyboard shortcuts for various operations in text
>>> >> > editor:
>>> >> >
>>> >> > Copy -                            [Ctrl-C, Cmd-C]
>>> >> > Cut -                               [Ctrl-X, Cmd-X]
>>> >> > Select All -                      [Ctrl-A, Cmd-A]
>>> >> > Undo -                            [Ctrl-Z, Cmd-Z]
>>> >> > Redo -                            [Ctrl-Y, Cmd-Y]
>>> >> > Delete Line -                  [Ctrl-D, Cmd-D]
>>> >> > Move left/right(words) -  [Alt-Left, Alt-Right]
>>> >> > Move start/end of line -  [Cmd-Left, Cmd-Right] // Ctrl-Left/Right
>>> >> > are
>>> >> > bound
>>> >> > to System   shortcuts. so these keys cannot be used.
>>> >> >
>>> >> > These keyboard shortcuts are consistent in Web/Runtime applications
>>> >> > in
>>> >> > all
>>> >> > platform types.
>>> >> >
>>> >> > Issue not fixed:
>>> >> > keyboard shortcut for Paste text doesn't work in Mac Runtime only.
>>> >> > It is
>>> >> > working on Linux runtime & Windows Runtime.
>>> >> > An issue "Key shortcuts doesn't work on Mac OS for QWebView widget"
>>> >> > is
>>> >> > also
>>> >> > reported.
>>> >> >
>>> >> > I also found that right click paste is working in Mac Runtime which
>>> >> > is
>>> >> > the
>>> >> > feature of code-mirror, So I am looking into its code to figure out
>>> >> > and
>>> >> > I
>>> >> > will send a patch with fix once it gets fixed.
>>> >> >
>>> >> > Please find attached patch and review.
>>> >> >
>>> >> >
>>> >> > Thanks,
>>> >> > Surinder Kumar
>>> >> >
>>> >> >
>>> >> >
>>> >> > --
>>> >> > Sent via pgadmin-hackers mailing list
>>> >> > (pgadmin-hackers@postgresql.org)
>>> >> > To make changes to your subscription:
>>> >> > http://www.postgresql.org/mailpref/pgadmin-hackers
>>> >> >
>>> >>
>>> >>
>>> >>
>>> >> --
>>> >> Dave Page
>>> >> Blog: http://pgsnake.blogspot.com
>>> >> Twitter: @pgsnake
>>> >>
>>> >> EnterpriseDB UK: http://www.enterprisedb.com
>>> >> The Enterprise PostgreSQL Company
>>> >
>>> >
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers