Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iSika-0002Dn-O1 for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Nov 2019 14:27:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iSikZ-0005Mw-HD for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Nov 2019 14:27:03 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iSikZ-0005IR-54 for pgadmin-hackers@lists.postgresql.org; Thu, 07 Nov 2019 14:27:03 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1iSikW-0003sp-61 for pgadmin-hackers@postgresql.org; Thu, 07 Nov 2019 14:27:02 +0000 Received: by mail-wm1-x342.google.com with SMTP id v3so5025234wmh.1 for ; Thu, 07 Nov 2019 06:27:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tru9xE3rlXgTDG3/Bgir59LiqUaQrITUI9LiKLQ0SPo=; b=LbJiJ89B9WgKDCO/ACzIGHeihYyswBxE/J1WqUV2BdJgsPGrZ1fZCNKvNnQoKCuVLz XVcQIP0QY9SAORo4B++AEDSvLMugPxRqysNakS+xf29ZBppXGgO/hkjfIx0vo5mJRgHW vORaDZLQUe2hmqHbiMADgYWkfmILCm40dL+BriKS3FjU8/3VmL0NVnZiUhT4UHybFGEi 97/MYmqa0RjHq/MXNnu5MAGg3blED1rjd9//+45BhMqKFXYm/zoYBL5kKJ5S8A2DSu8I RL7k9OVAlPdZN2N2IzCfiiJ3LVwCtBcZlKAy1cZzVGjz0BsW3qeXbld64FtJ39AuDxY/ 8phw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tru9xE3rlXgTDG3/Bgir59LiqUaQrITUI9LiKLQ0SPo=; b=Y5GNPyaXUKSDQu8+FwBiAtcdfIvM4r1AwhDIMOAZYUthxckeQbaIECDBwJY73Oef3b IMJta72GOv++sut/itfaf5e9jnhFeyzJGWFg2fkHveV+F3+ep+3UxBZJFPo64x8RP8IN zcWpkUC439DqWjeJ2n5esAxVjGKzDJaXTTf5c2PvGNL/DEwmP7TsjGgGPiZMr4Gw30Cr iV9MPGtEVreZU9h4AVpaRAsiYz4JRUWz2m1ytK61ZRIbrxcRnliY24o3LoS2vWYcQXE/ hhG02J1QYx01nwqY5btH4beu1KO7Oa4u18w+2nT3ysQmpvznmUXpxBiUJtVS1w7DkUzH t0mg== X-Gm-Message-State: APjAAAUj4slUKOYzkSBvgfYt43Z88XJzIMndmO6dOVTj4b9qj8FaoFGC gBo/C4vx7CnMt00UWoSom63IqYSGz2s2B1JZcgvdvg== X-Google-Smtp-Source: APXvYqxLOBBztD5cgxYuc9gCUElk8waL0N1i27spQedyBCp6TWlOkIHIk45C/S6aTiXJWetov9y8lgzLZbM09XlhGtI= X-Received: by 2002:a05:600c:2383:: with SMTP id m3mr276209wma.66.1573136818767; Thu, 07 Nov 2019 06:26:58 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Thu, 7 Nov 2019 14:26:46 +0000 Message-ID: Subject: Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme To: Akshay Joshi Cc: Aditya Toshniwal , pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000004422130596c27534" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000004422130596c27534 Content-Type: text/plain; charset="UTF-8" On Thu, Nov 7, 2019 at 2:18 PM Dave Page wrote: > > On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi > wrote: > >> Thanks, patch applied. >> >> On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the updated patch with few more changes and corrections. >>> Kindly review. >>> >> > I've committed a couple of minor tweaks - one to remove a space, e.g. > > gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now ?'), > > is now: > > gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now?'), > > And another change to fix the word wrapping in the README which was > totally different from the rest of the file. > > Thanks! > Oh, and do we need all the code in config.py? I really didn't even want a config option in there to turn theming on or off (what's the point?), let alone 20 new lines. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --0000000000004422130596c27534 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Nov 7, 2019 at 2:18 PM Dave P= age <dpage@pgadmin.org> wrot= e:

On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <akshay.joshi@e= nterprisedb.com> wrote:
Thanks, patch applied.

On Thu, Nov 7, 2019 = at 6:39 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote= :
Hi Hackers,

Attached is the updated patch with few more changes and c= orrections.
Kindly revie= w.

I've = committed a couple of minor tweaks - one to remove a space, e.g.
= 
gettext(&#=
39;A page refresh is required to apply the theme. Do you wish to refresh th=
e page now ?'),
is now:
gettext('A page refr=
esh is required to apply the theme. Do you wish to refresh the page now?=
9;),
And another change to fix the word wrapping in = the README which was totally different from the rest of the file.

Thanks!

O= h, and do we need all the code in config.py? I really didn't even want = a config option in there to turn theming on or off (what's the point?),= let alone 20 new lines.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pg= snake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL C= ompany
--0000000000004422130596c27534--