Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyxDB-000400-Td for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Mar 2018 10:12:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eyxDA-0004YV-GJ for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Mar 2018 10:12:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyxDA-0004YL-A7 for pgadmin-hackers@lists.postgresql.org; Thu, 22 Mar 2018 10:12:44 +0000 Received: from mail-wr0-x22f.google.com ([2a00:1450:400c:c0c::22f]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eyxD6-0002W3-39 for pgadmin-hackers@postgresql.org; Thu, 22 Mar 2018 10:12:43 +0000 Received: by mail-wr0-x22f.google.com with SMTP id h2so8069596wre.12 for ; Thu, 22 Mar 2018 03:12:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=nyIcIUfTsJH17LQBxxfECLDETJhkOEe/LIOFFuc3ZEE=; b=GMoBdn99d6jixs9g4aGbtZjlOTGqKTbAN26GA/xxv1q55P1bFKxMkq5+MaFF6aJBTd oKy02HeI1rcxtKp3whSf4m75AjjgWe0OLZ5RhK0sltoanF9TYP8YYMn3A92NVTrboGRm kaJq2pGFKlfxvwb2aFi4DdfpA1DIwZ5duvLF3lHWFKDjK5TmGEVJnAtur02MPnzcytoU bNkKU5QRQkbfvzNLrbtCyeDhHwvBLISdFnj1ZchLEoJdsbLYWK3N3buvmo5RrnMCvTvA tWIBQ65lALa2BbUWc0j/GfdqcpxfMp5kOrWZIrzVbps98AfmQ9QXh6whAtfu1n1qi+Kj jmHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=nyIcIUfTsJH17LQBxxfECLDETJhkOEe/LIOFFuc3ZEE=; b=sUNemQycShvozSobm4d9OuPWvOm2B29/ongULLLENryJOCAFbVU92iUEXhnZOIQpC6 UnGGKt1M05oL5QdFEnDHwETNwoqHLCucCQVgWMlU3hZM0aW4jjExx3FVYhS8bER1lF2u ynSRC2WtEp/H5E0nfEDbLDcpgfbHCuEaQeM2NhIWvDvE7I7fpaweSrR+AYmurPF6yCMP sirWDGqdEk1vpIwos6F+4EAHYnIqS+5ovNB1KZwq3CAQZHMuH6Jm/2eGsrsqT14qF6Tx MlNi3dg67HsgbQ2XjB8BvN9BOy5HZpVlZHBiS5JMjFi+5TnB9F49ajdE/M861Wus9x8D my3w== X-Gm-Message-State: AElRT7FzT09FVvMQYsFTqXqlmcRtfmuey2qXRflhfLOtVNOpwVho3Mut PP3oaGA59LKjQz3VNAcKCq1BjRz64HvH1foG9pCzOQ== X-Google-Smtp-Source: AG47ELtDlYLi6Rpg9Mh7ga+nvzH5fKrUkK2jrXQLXcKax5wVGNTwxuPugyauwHniqQ9F5uj1Q7wugqBn6GbAzNTGhUI= X-Received: by 10.223.176.98 with SMTP id g31mr18558208wra.256.1521713559223; Thu, 22 Mar 2018 03:12:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.69.220 with HTTP; Thu, 22 Mar 2018 03:12:38 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Thu, 22 Mar 2018 10:12:38 +0000 Message-ID: Subject: Re: v3.0 release on hold To: Khushboo Vashi Cc: pgadmin-hackers , Akshay Joshi , Murtuza Zabuawala , Syed Fahar Abbas , =?UTF-8?B?RGV2cmltIEfDnE5Ew5xa?= Content-Type: multipart/alternative; boundary="001a113c9c4025d1860567fd8c93" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a113c9c4025d1860567fd8c93 Content-Type: text/plain; charset="UTF-8" On Thu, Mar 22, 2018 at 9:58 AM, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > > > On Thu, Mar 22, 2018 at 3:20 PM, Dave Page wrote: > >> Hi >> >> On Thu, Mar 22, 2018 at 9:25 AM, Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> On Wed, Mar 21, 2018 at 9:05 PM, Dave Page wrote: >>> >>>> We've run into a number of unexpected issues with the v3.0 release that >>>> I think we need to resolve before moving forwards. For the time being, only >>>> patches critical to fix these issues should be committed. >>>> >>>> I'll try to look at 1, though I do have another deadline I need to >>>> meet. >>>> Akshay, can you look at 2 please? >>>> Fahar is already looking at 3. >>>> Khushboo, can you look at 4 please? >>>> >>>> Thanks all. >>>> >>>> 1) There is no longer a system tray in Gnome 3.26 and later, and thus >>>> the runtime won't initialise in Fedora 27 and later. We need an alternative >>>> for this, either a tray replacement that the RPM can depend on, or better >>>> yet, support whatever it is Gnome expect such apps to use these days. >>>> >>>> 2) Starting a second instance of the app bundle on Mac doesn't always >>>> open a new pgAdmin window as it should. It works fine in the debugger, or >>>> if you start the app with a command like: "/Applications/pgAdmin\ >>>> 4.app/Contents/MacOS/pgAdmin4". It doesn't work if you double-click >>>> the appbundle or use a command like "open /Applications/pgAdmin\ 4.app" >>>> >>>> 3) Fahar saw a crash on Windows 7. I couldn't reproduce this on my >>>> copy, but apparently his is a fresh installation. >>>> >>>> 4) On my Windows 7 machine, after running a backup I get no status >>>> window, and see the following in the logs: >>>> >>>> >>> We have tried to reproduce this issue on Windows 7 and Windows 8, but >>> couldn't reproduce it, It is working fine on both the environments. >>> Can you please provide the options which you have selected while taking >>> a backup? >>> >> >> They were all the default options - I just selected a database, >> right-clicked to select backup, and entered a filename. >> >> > With the default options, it is working fine. > Can you see any way in which the exception below could conceivably happen? Perhaps if run on a system that has process logs from an older version of pgAdmin? > >>> Traceback (most recent call last): >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\werkzeug\serving.py", >>>> line 209, in run_wsgi >>>> execute(self.server.app) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\werkzeug\serving.py", >>>> line 197, in execute >>>> application_iter = app(environ, start_response) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>> line 1997, in __call__ >>>> return self.wsgi_app(environ, start_response) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>> line 1985, in wsgi_app >>>> response = self.handle_exception(e) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>> line 1540, in handle_exception >>>> reraise(exc_type, exc_value, tb) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>> line 1982, in wsgi_app >>>> response = self.full_dispatch_request() >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>> line 1614, in full_dispatch_request >>>> rv = self.handle_user_exception(e) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>> line 1517, in handle_user_exception >>>> reraise(exc_type, exc_value, tb) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>> line 1612, in full_dispatch_request >>>> rv = self.dispatch_request() >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", >>>> line 1598, in dispatch_request >>>> return self.view_functions[rule.endpoint](**req.view_args) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask_login.py", >>>> line 792, in decorated_view >>>> return func(*args, **kwargs) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgprocess\__init__.py", >>>> line 62, in index >>>> return make_response(response=BatchProcess.list()) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgprocess\processes.py", >>>> line 584, in list >>>> details = desc.details(p.command, args) >>>> File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\tools\backup\__init__.py", >>>> line 190, in details >>>> res += html.safe_str(cmd + self.cmd) >>>> AttributeError: 'BackupMessage' object has no attribute 'cmd' >>>> >>>> >>>> Thanks, >>> Khushboo >>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a113c9c4025d1860567fd8c93 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, Mar 22, 2018 at 9:58 AM, Khushboo Vashi <<= a href=3D"mailto:khushboo.vashi@enterprisedb.com" target=3D"_blank">khushbo= o.vashi@enterprisedb.com> wrote:


On Thu, Mar 22, 2018 at 3:20 PM, Dave Page <dpa= ge@pgadmin.org> wrote:
Hi

On Thu, Mar 22, 2018 at 9:25 AM, Khushboo Vashi &= lt;khu= shboo.vashi@enterprisedb.com> wrote:
Hi Dave,

On Wed, Mar 21, 2018 at 9:05 PM, Dave Page <dpage@pgad= min.org> wrote:
We've run into a number of unexpected issues with th= e v3.0 release that I think we need to resolve before moving forwards. For = the time being, only patches critical to fix these issues should be committ= ed.

I'll try to look at 1, though I do have another = deadline I need to meet.=C2=A0
Akshay, can you look at 2 please?<= /div>
Fahar is already looking at 3.
Khushboo, can you look a= t 4 please?

Thanks all.

1= ) There is no longer a system tray in Gnome 3.26 and later, and thus the ru= ntime won't initialise in Fedora 27 and later. We need an alternative f= or this, either a tray replacement that the RPM can depend on, or better ye= t, support whatever it is Gnome expect such apps to use these days.

2) Starting a second instance of the app bundle on Mac do= esn't always open a new pgAdmin window as it should. It works fine in t= he debugger, or if you start the app with a command like: "/Applicatio= ns/pgAdmin\ 4.app/Contents/MacOS/pgAdmin4". It doesn't work i= f you double-click the appbundle or use a command like "open /Applicat= ions/pgAdmin\ 4.app"

3) Fahar saw a crash on = Windows 7. I couldn't reproduce this on my copy, but apparently his is = a fresh installation.

4) On my Windows 7 machine, = after running a backup I get no status window, and see the following in the= logs:


We have tried to reproduce this issue on Windows 7 and Windows 8, = but couldn't reproduce it, It is working fine on both the environments.=
Can you please provide the options which you have selected while= taking a backup?

They were all the default options - I just selected a database, right= -clicked to select backup, and entered a filename.
=C2=A0
With the default options, it is working fine.=C2=A0<= /div>

Can you see any=C2= =A0 way in which the exception below could conceivably happen? Perhaps if r= un on a system that has process logs from an older version of pgAdmin?
=C2=A0

Traceback (most recent call last):
=C2=A0 = File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\werkzeug\serving.py", line 209, in run_wsgi
=C2=A0 =C2=A0 ex= ecute(self.server.app)
=C2=A0 File "C:\Program Files (x86)\p= gAdmin 4\v3\venv\Lib\site-packages\werkzeug\serving.py", line 197= , in execute
=C2=A0 =C2=A0 application_iter =3D app(environ, star= t_response)
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3= \venv\Lib\site-packages\flask\app.py", line 1997, in __call__
=C2=A0 =C2=A0 return self.wsgi_app(environ, start_response)
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packa= ges\flask\app.py", line 1985, in wsgi_app
=C2=A0 =C2=A0= response =3D self.handle_exception(e)
=C2=A0 File "C:\Progr= am Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py",= line 1540, in handle_exception
=C2=A0 =C2=A0 reraise(exc_type, e= xc_value, tb)
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\= v3\venv\Lib\site-packages\flask\app.py", line 1982, in wsgi_app
=C2=A0 =C2=A0 response =3D self.full_dispatch_request()
= =C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-package= s\flask\app.py", line 1614, in full_dispatch_request
= =C2=A0 =C2=A0 rv =3D self.handle_user_exception(e)
=C2=A0 File &q= uot;C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\a= pp.py", line 1517, in handle_user_exception
=C2=A0 =C2=A0 re= raise(exc_type, exc_value, tb)
=C2=A0 File "C:\Program Files= (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 16= 12, in full_dispatch_request
=C2=A0 =C2=A0 rv =3D self.dispatch_r= equest()
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\ve= nv\Lib\site-packages\flask\app.py", line 1598, in dispatch_reques= t
=C2=A0 =C2=A0 return self.view_functions[rule.endpoint](**= req.view_args)
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4= \v3\venv\Lib\site-packages\flask_login.py", line 792, in decorate= d_view
=C2=A0 =C2=A0 return func(*args, **kwargs)
=C2= =A0 File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgproce= ss\__init__.py", line 62, in index
=C2=A0 =C2=A0 return= make_response(response=3DBatchProcess.list())
=C2=A0 File &= quot;C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgprocess\pr= ocesses.py", line 584, in list
=C2=A0 =C2=A0 details =3D des= c.details(p.command, args)
=C2=A0 File "C:\Program Files (x8= 6)\pgAdmin 4\v3\web\pgadmin\tools\backup\__init__.py", line 190, = in details
=C2=A0 =C2=A0 res +=3D html.safe_str(cmd + self.cmd)
AttributeError: 'BackupMessage' object has no attribute &#= 39;cmd'

<= br>
Than= ks,
Khushboo=C2=A0

--
Dave Page
B= log: http://pgsna= ke.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com=
The Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Enterpri= seDB UK: http://w= ww.enterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a113c9c4025d1860567fd8c93--