Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hifUB-0005Vi-VC for pgadmin-hackers@arkaria.postgresql.org; Wed, 03 Jul 2019 13:39:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hifUA-0002p2-Qr for pgadmin-hackers@arkaria.postgresql.org; Wed, 03 Jul 2019 13:39:46 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hifUA-0002gP-Ew for pgadmin-hackers@lists.postgresql.org; Wed, 03 Jul 2019 13:39:46 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hifU7-0005jl-PH for pgadmin-hackers@postgresql.org; Wed, 03 Jul 2019 13:39:46 +0000 Received: by mail-wm1-x344.google.com with SMTP id g135so2257511wme.4 for ; Wed, 03 Jul 2019 06:39:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pwFW43EP6pEX4Owe53nEtWpjC4Q6R+wcJ8DwbMU29hI=; b=fqysKv6HiihOzrfeRb2gd9TmsJzgROS1RPFC31q9vKPF7xOKlfmntSnoTwR4x9EMYt KOqdUf9tCAWT5kfkw3xJRUAb442tooiRd0DHjSkuMVOvEuuzSU0JVNLUoZxljZnAj8Oi iv7ST3lcjy77SXx106Uwc47wflkfM9dfI/L9ffdmbvNqnn4z8gYd3JlgH68dvyQ5kPUL WXM7LSsT4QhMNXg5qIi4oy4xy17Zdcsc5zEPhBhXaZpXkeW6pYAH+cW681IgvhtH1rfB T+CiKyam70aBepUpl0Ntxhel2IR7BIWQ+MoxVuILunukRlnI0Hj2fE6SVNqwVYHzAIr5 hJiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pwFW43EP6pEX4Owe53nEtWpjC4Q6R+wcJ8DwbMU29hI=; b=EZQQbuV2QOdTFE2x7MwKqrIiBcSumXCVkm0cmRkzvCJVt6/92yfgafl+nexmX5ENV/ Ow/PD5619PYdLYY8fD/xizk19/gSZsip7f4B5mIL2hl5AEnYoXCqw0JV3Z0FXJB2WUeM ekzHaYmwOpt1GdMbRMOHBLUZCRuIs4MVSXUYok9XtSf9IYCsto1ZzMkdBpeZF9U45A+T pSLU0S9C0h2zWRoVe25XAEAp3afZeqBCm+f6Ybzh3z34OWUukn+wHZ1Wetd7aZXLYdWA Zmyo7AFmLFuCeeweu7NkX3xCbbi9NQPSwYyuU0PKAUyHDznf/AISNkOIfM4XmsJZnX62 rsDQ== X-Gm-Message-State: APjAAAXbqkCDF1XHYV/Hg0w90qF5gPdrNGRMbRmBJ3scKrZCaFcTXczV fO9ChW3gK1SaD5xM5NAdKEKd1Y/Cnhx5lDovcdFxPw== X-Google-Smtp-Source: APXvYqyTqb+hkEYSFbA5XrkxV+GP6PTrl7dCDDRrmLm6kOufrVrICYUyQr8PWNH+ms3Wz+NomyiE6eHjXhE3qwH6p2U= X-Received: by 2002:a05:600c:20c3:: with SMTP id y3mr8443375wmm.3.1562161182741; Wed, 03 Jul 2019 06:39:42 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Wed, 3 Jul 2019 14:39:30 +0100 Message-ID: Subject: Re: RE-SQL tests for Roles & Resource Group nodes To: Murtuza Zabuawala Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000612cde058cc6fe50" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000612cde058cc6fe50 Content-Type: text/plain; charset="UTF-8" Thanks, applied. On Wed, Jul 3, 2019 at 2:30 PM Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > PFA updated patch with corrections in the print messages. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > > On Wed, Jul 3, 2019 at 5:36 PM Dave Page wrote: > >> Hi >> >> On Wed, Jul 3, 2019 at 8:35 AM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Murtuza >>> >>> I have tested the patch and I think below string should be modified: >>> Server(Type: #ppas) is not supported for the Resource Groups module - >>> Skipped >>> Server version(120000) is not supported for the Resource Groups module - >>> Skipped >>> >>> It misleads, that server type 'ppas' is not supported for the Resource >>> Group, it should be changed to "Resource groups are not supported by PG - >>> Skipped". Similarly for version string should be ''Resource groups are not >>> supported by PPAS server less/greater than " >>> >> >> Agreed. >> >> >>> >>>> Please note that our framework considers test cases from all the >>>> modules as one single test case, If we need module wise detailed summary >>>> report for the reverse engineered SQL tests then we may have to change the >>>> framework. >>>> >>> >> We're just treating all the re-sql tests as one test in the higher-level >> suite. Maybe we'd want to change that in the future, but I think it's fine >> for now. >> >> >>> >>>> >>>> Regards, >>>> Murtuza >>>> >>>> >>>> On Tue, Jul 2, 2019 at 5:52 PM Dave Page wrote: >>>> >>>>> Hi >>>>> >>>>> On Tue, Jul 2, 2019 at 8:17 AM Murtuza Zabuawala < >>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>> >>>>>> ++ Attaching patch >>>>>> >>>>>> On Tue, Jul 2, 2019 at 12:46 PM Murtuza Zabuawala < >>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Dave, >>>>>>> >>>>>>> Please find the updated patch, >>>>>>> >>>>>>> - Added a mechanism to check for supported minimum/maximum version >>>>>>> and a server type in the framework. >>>>>>> >>>>>> >>>>> There's still a problem with this I'm afraid - it says in the summary >>>>> that the re_sql test cases were all skipped, which is not the case. I think >>>>> we should just skip the irrelevant tests in the re_sql module, but not mark >>>>> the entire module as being skipped: >>>>> >>>> >>>>> =============Running the test cases for 'Regression - PG >>>>> 11'============= >>>>> >>>>> runTest >>>>> (regression.re_sql.tests.test_resql.ReverseEngineeredSQLTestCases) >>>>> >>>>> Reverse Engineered SQL Test Cases >>>>> >>>>> >>>>> Create IMPLICIT Cast >>>>> >>>>> Alter IMPLICIT Cast >>>>> >>>>> Drop IMPLICIT Cast >>>>> >>>>> Create EXPLICIT Cast >>>>> >>>>> Alter EXPLICIT Cast >>>>> >>>>> Drop EXPLICIT Cast >>>>> >>>>> ... skipped 'Server(Type: #ppas) is not supported for the Resource >>>>> Groups module' >>>>> >>>>> >>>>> ---------------------------------------------------------------------- >>>>> >>>>> Ran 1 test in 0.480s >>>>> >>>>> >>>>> OK (skipped=1) >>>>> >>>>> >>>>> ====================================================================== >>>>> >>>>> Test Result Summary >>>>> >>>>> ====================================================================== >>>>> >>>>> >>>>> Regression - PG 11: >>>>> >>>>> >>>>> 0 tests passed >>>>> >>>>> 0 tests failed >>>>> >>>>> 1 test skipped: >>>>> >>>>> ReverseEngineeredSQLTestCases (Reverse Engineered SQL Test Cases) >>>>> >>>>> >>>>> ====================================================================== >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000612cde058cc6fe50 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied.=C2=A0

On Wed, Jul 3, 2019 at 2:30 PM Murtu= za Zabuawala <murt= uza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA updated patch with corrections in t= he print messages.

--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0<= a href=3D"http://www.enterprisedb.com/" rel=3D"noreferrer" target=3D"_blank= ">http://www.enterprisedb.com
The Enterprise PostgreSQL Company

=


On Wed, Jul 3, 2019 at 5:36 P= M Dave Page <dpag= e@pgadmin.org> wrote:
Hi

<= div dir=3D"ltr" class=3D"gmail_attr">On Wed, Jul 3, 2019 at 8:35 AM Akshay = Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Murtuza

<= /div>
I have tested the patch and I think below string should be modifi= ed:
Server(Type: #ppas) is not supported for the Resource Gr= oups module - Skipped
Server version(120000) is not supported for = the Resource Groups module - Skipped

It mislea= ds, that server type 'ppas' is not supported for the Resource Group= , it should be changed to "Resource groups are not supported by PG - S= kipped". Similarly for version string should be ''Resource gro= ups are not supported by PPAS server less/greater than <server version&g= t;"

Agreed.
=C2= =A0

Please note that our framework considers test cases from all th= e modules as one single test case, If we need module wise detailed=C2=A0sum= mary report for the reverse engineered SQL tests then we may have to change= the framework.

<= /div>
We're just treating all the re-sql tests as one test in the h= igher-level suite. Maybe we'd want to change that in the future, but I = think it's fine for now.
=C2=A0


Regards,
Murtuza


On Tue, Jul 2, 2019 = at 5:52 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Tue, Jul 2, 2019 at 8:17 A= M Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
<= /div>
++ Attaching patch

On Tue, Jul 2, 2019 at 12:46 PM Murtuza Za= buawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave= ,
P= lease find the updated patch,

- Added a mechanism to check for supported m= inimum/maximum version and a server type in the framework.

There's stil= l a problem with this I'm afraid - it says in the summary that the re_s= ql test cases were all skipped, which is not the case. I think we should ju= st skip the irrelevant tests in the re_sql module, but not mark the entire = module as being skipped:

=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3DRunning the test cases for 'Regression - PG 11'=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

runTest (regression.re_s= ql.tests.test_resql.ReverseEngineeredSQLTestCases)

Reverse Engineered SQL T= est Cases

Create IMPLICIT Cast

Alter IMPLICIT Cast

Drop IMPLICIT Cast

Create EXPLICIT Cast

Alter EXPLICIT Cast

Drop EXPLICIT Cast

=C2=A0... skipped 'Server(Type: #ppas) is not supported for = the Resource Groups module'

------------------------= ----------------------------------------------

Ran 1 test in 0.480s

OK (skipped=3D1)<= /p>

=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

Test Result Summary

=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

Regression - PG 11:

0 tests passed

0 tests failed

1 test skipped:

ReverseEngineeredSQLTestCases (Reverse Engineered SQL = Test Cases)



--
Thanks = & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Priv= ate Limited
Mobile: +91 976-788-8246
=


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Ent= erpriseDB UK: htt= p://www.enterprisedb.com
The Enterprise PostgreSQL Company
=

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--000000000000612cde058cc6fe50--